From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD9E2C4363C for ; Thu, 8 Oct 2020 04:08:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DADD2085B for ; Thu, 8 Oct 2020 04:08:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2dSCGplF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DADD2085B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Eof74wKpZi7fD2s1F6iXRYwmDpi1XF0M+SKTNAV1sK4=; b=2dSCGplFzZNa6sBWCQYLNES8N 0lh3Xst06tFxaj8YghZL/Sl9bdfNeFmADpgnJXuG9nwL0ACKtlrOlqNjtOOU8GjWAxtOrSzThRj4s czEqbQTgj2NvqiJAmcDSCb8tYn6lD++em1tXcP1nS+d3h15hcO4uf4mYBiFVPnvgOjsZLX3Co4ydz Dn2VNh+phICLe2ih64AIJX7rleR7hEPsNjTfWDSYdgxP4vwS7mtfQC05EbqIRiQ8w7CNwOojuYJLB qCpym3gwzjYwY32mN0L8wTPiel0JGQR4Meu9Io8Vgd9pYUUafZdtIF2B3ynsOr0E7uUJwF4RSeWI8 qYJLRj7ww==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQNCd-0005Le-Bl; Thu, 08 Oct 2020 04:06:51 +0000 Received: from mail-eopbgr1310133.outbound.protection.outlook.com ([40.107.131.133] helo=APC01-SG2-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQNCa-0005LH-Ga for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2020 04:06:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dsQ+leEkg/X/7xpPS67ELku4le2SNAcFzta4CKieR+ZobHSeuDIFlwtHTL29WBZYjYbqXS8kyEjpcFA7X6vU7IHuPamhkUKlXpW7UgaX310xzsaISRtQztq0+RFxQdQIbWxXIS2C7qTiOCy91Q6Jk5Wo01n3RX7VcjkRbrFnvzfM5hPSxnnqBeqVeTNSvNPeg5jIUkD8HkBEaAZqjHDU93dJZOyPrplTp00LftE34lOpml3ea48HEPYepVik65i0pPRC1NWHr6W3UHAzLmhnVU1DfLoCYuGpsMowJF4UDINkljuff/aNrbGWGzX6jgYbaDAGRxv8zU+gOoUjYDvziQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3dRatU3WhHbEAs1635M2wsD51wIgoqEe77HPr/8O/Xo=; b=UAc7gdx2/q+WlJKQp7cgjamzCOtvP3Hhyx8H84s361YP/0QdVKLIpIRdfoHQ22rCOGKQHFas9v4j6vYHrZ4AjPeWnVTIBQQuzKWnC8Q4kcbXfX47eR3r1JH9K47gdY+G34kMLng+KbQiP4H5cHGTXOwaTg18Frkmylka2sXnGwJaM/sE1g9G5smTXhPW/bf5OZhvYFsRjvwX2CcvAgWJk9CNl1/+5w04MnnDJM1STUl/FSebvdGufdpYzQo0Zh1tmxwdUoAzlPBk6qQ+vINqAmxwIe4QptmkqwtAI9eGS7lZckAJoU36hIK1ts2ndsnpekjh1V9xp9SgxMAFriDijg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none Received: from HK0PR06MB3380.apcprd06.prod.outlook.com (2603:1096:203:82::18) by HK0PR06MB2580.apcprd06.prod.outlook.com (2603:1096:203:67::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34; Thu, 8 Oct 2020 02:33:50 +0000 Received: from HK0PR06MB3380.apcprd06.prod.outlook.com ([fe80::6def:b61:3beb:f3d5]) by HK0PR06MB3380.apcprd06.prod.outlook.com ([fe80::6def:b61:3beb:f3d5%6]) with mapi id 15.20.3455.023; Thu, 8 Oct 2020 02:33:50 +0000 From: Ryan Chen To: Joel Stanley Subject: RE: [PATCH 1/1] clk: aspeed: modify some default clks are critical Thread-Topic: [PATCH 1/1] clk: aspeed: modify some default clks are critical Thread-Index: AQHWlWUpDwyjj9Eb9EeIGPpnHXDUp6l/Q2cAgAAIW6CADMT0gIAA+GOA Date: Thu, 8 Oct 2020 02:33:50 +0000 Message-ID: References: <20200928070108.14040-1-ryan_chen@aspeedtech.com> <20200928070108.14040-2-ryan_chen@aspeedtech.com> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: jms.id.au; dkim=none (message not signed) header.d=none;jms.id.au; dmarc=none action=none header.from=aspeedtech.com; x-originating-ip: [211.20.114.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fe9fd4f6-2924-4002-d85a-08d86b32975d x-ms-traffictypediagnostic: HK0PR06MB2580: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: R1o9gNyMvknzapEpeHFdWGvC5wFEOBPdUcHfrnPQ22zrTbUX4ugCUEKSXlv1tHLSswkpizf62KpTHPeuMxQ4nxO6McsxeTeDk3UL1MVaQJ0B6j40rGSP86T/omdnhIV41RNzHi4uU7FiiFQSrh0XB/W8B/T90xfarwoCyW009JiIMZJLJ1Gctcld9I8th5tGpLdadhTu6FumL+ix6hhx1Xf9eG+xUNRZMy6KLmtFzXAUNRDIH32XjIxyTcAdAu1juuFYZZsWUsUADcPgS54zDotu5t18dTiRIITB3nYlxtV8Pk1WfKDzYogOunp/GLn8N0nxXYcRQbRvY2igyxGcOqQ6QrY4B+BKWhofGT6cXzMbtBdB651/M+jTiSCnpoLzwHHUqAYOjW5pRCCmDGic8g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HK0PR06MB3380.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(396003)(39840400004)(136003)(376002)(346002)(83080400001)(71200400001)(33656002)(7696005)(83380400001)(2906002)(86362001)(53546011)(26005)(66556008)(76116006)(66946007)(316002)(6506007)(64756008)(66476007)(66446008)(54906003)(186003)(52536014)(8936002)(55016002)(478600001)(8676002)(966005)(5660300002)(4326008)(9686003)(6916009)(107886003)(55236004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: bKNM1/iK2VQusTtCUoO5107/HXYvSzBnywUdILfKOO8KCEiLj0k/YZkMqO7X8uJn9t8Df+J0DWFExOsLXWcxmYT7AGZWvacV2yrQVejGsAw3+czy68m2Fq1AmRbLHYQtpdjCZj9oy7zvUU8YIfT1etSo7XKjefMpIyZ9mwzsT3sxNGDOji/4GX4y6nNvh4VS/cSt5x4PeaFr7H2VqB+ESx+A3jYbl0IBvipy7pCyfjsR1xIw9qUR6K3o//b5AIJrDlEg7VO3apn1kCEWhVb/eLqiqP45KEul5V/awJfRwivINPJOgHI0xy+P2wPKsN4yjQz/DWBooQkQarHmS5vKnbbYPcGlKTw+xV6oD6ebgMBpxwCU6xeMuKrd0aKH4vC6pD8a7xDroZsfTfdeUpOf62Ydx48ARu+Hm7XGbD5BmPrYQ0uMop6bjhPBk8wqVKVpwOCGsekANFP92tx/tc2pgD982AZrDjFRP5Mco3QoYRPDkqC/vRmbIFV3A28ta9Ou6/7p77ndJYA5DMrtQqYU+3t+U+3Fzpp52aXdff/lQa9cBWI9HVb/cPsJ5z8hTOnc3r5aFf8vEkXOEdCiUQje892DaL28crXgxVnGm9Fx6i6eQQ/Ulq35r9adNpG1awPYkzjc+Wu4E01kQl8K3YGH4g== MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3380.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe9fd4f6-2924-4002-d85a-08d86b32975d X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2020 02:33:50.3772 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ODrSAVwcK9ZS6sSedxpF1N1HSpiZWw9OYBUWhqRQSYH9qjCCoLXJMiHFKC1I8DGuiq47dpKw/em+zmLAXLw0rDL1nac7dOEqFw9610faDtY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2580 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201008_000648_585691_3509960E X-CRM114-Status: GOOD ( 37.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: BMC-SW , Jae Hyun Yoo , linux-aspeed , Andrew Jeffery , Michael Turquette , Linux Kernel Mailing List , Stephen Boyd , "linux-clk@vger.kernel.org" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Joel Stanley > Sent: Wednesday, October 7, 2020 7:34 PM > To: Ryan Chen > Cc: Jae Hyun Yoo ; Andrew Jeffery > ; Michael Turquette ; Stephen > Boyd ; linux-clk@vger.kernel.org; Linux ARM > ; linux-aspeed > ; Linux Kernel Mailing List > ; BMC-SW > Subject: Re: [PATCH 1/1] clk: aspeed: modify some default clks are critical > > On Tue, 29 Sep 2020 at 08:40, Ryan Chen > wrote: > > > > > From: Joel Stanley > > > Sent: Tuesday, September 29, 2020 4:04 PM > > > To: Ryan Chen ; Jae Hyun Yoo > > > ; Andrew Jeffery > > > Cc: Michael Turquette ; Stephen Boyd > > > ; linux-clk@vger.kernel.org; Linux ARM > > > ; linux-aspeed > > > ; Linux Kernel Mailing List > > > ; BMC-SW > > > Subject: Re: [PATCH 1/1] clk: aspeed: modify some default clks are > > > critical > > > > > > On Mon, 28 Sep 2020 at 07:01, Ryan Chen > > > wrote: > > > > > > > > In ASPEED SoC LCLK is LPC clock for all SuperIO device, > > > > UART1/UART2 are default for Host SuperIO UART device, eSPI clk for > > > > Host eSPI bus access eSPI slave channel, those clks can't be > > > > disable should keep default, otherwise will affect Host side access > SuperIO and SPI slave device. > > > > > > > > Signed-off-by: Ryan Chen > > > > --- > > > > drivers/clk/clk-aspeed.c | 8 ++++---- drivers/clk/clk-ast2600.c > > > > | 8 > > > > ++++---- > > > > 2 files changed, 8 insertions(+), 8 deletions(-) > > > > > > > > diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk/clk-aspeed.c > > > > index 411ff5fb2c07..d348c4fd3f9f 100644 > > > > --- a/drivers/clk/clk-aspeed.c > > > > +++ b/drivers/clk/clk-aspeed.c > > > > @@ -54,15 +54,15 @@ static const struct aspeed_gate_data > > > > aspeed_gates[] > > > = { > > > > [ASPEED_CLK_GATE_DCLK] = { 5, -1, "dclk-gate", > > > NULL, CLK_IS_CRITICAL }, /* DAC */ > > > > [ASPEED_CLK_GATE_REFCLK] = { 6, -1, "refclk-gate", > > > "clkin", CLK_IS_CRITICAL }, > > > > [ASPEED_CLK_GATE_USBPORT2CLK] = { 7, 3, > > > > "usb-port2-gate", > > > NULL, 0 }, /* USB2.0 Host port 2 */ > > > > - [ASPEED_CLK_GATE_LCLK] = { 8, 5, "lclk-gate", > > > NULL, 0 }, /* LPC */ > > > > + [ASPEED_CLK_GATE_LCLK] = { 8, 5, "lclk-gate", > > > NULL, CLK_IS_CRITICAL }, /* LPC */ > > > > [ASPEED_CLK_GATE_USBUHCICLK] = { 9, 15, > "usb-uhci-gate", > > > NULL, 0 }, /* USB1.1 (requires port 2 enabled) */ > > > > [ASPEED_CLK_GATE_D1CLK] = { 10, 13, "d1clk-gate", > > > NULL, 0 }, /* GFX CRT */ > > > > [ASPEED_CLK_GATE_YCLK] = { 13, 4, "yclk-gate", > > > NULL, 0 }, /* HAC */ > > > > [ASPEED_CLK_GATE_USBPORT1CLK] = { 14, 14, > > > > "usb-port1-gate", > > > NULL, 0 }, /* USB2 hub/USB2 host port 1/USB1.1 dev */ > > > > - [ASPEED_CLK_GATE_UART1CLK] = { 15, -1, "uart1clk-gate", > > > "uart", 0 }, /* UART1 */ > > > > - [ASPEED_CLK_GATE_UART2CLK] = { 16, -1, "uart2clk-gate", > > > "uart", 0 }, /* UART2 */ > > > > + [ASPEED_CLK_GATE_UART1CLK] = { 15, -1, "uart1clk-gate", > > > "uart", CLK_IS_CRITICAL }, /* UART1 */ > > > > + [ASPEED_CLK_GATE_UART2CLK] = { 16, -1, "uart2clk-gate", > > > "uart", CLK_IS_CRITICAL }, /* UART2 */ > > > > [ASPEED_CLK_GATE_UART5CLK] = { 17, -1, > "uart5clk-gate", > > > "uart", 0 }, /* UART5 */ > > > > - [ASPEED_CLK_GATE_ESPICLK] = { 19, -1, "espiclk-gate", > > > NULL, 0 }, /* eSPI */ > > > > + [ASPEED_CLK_GATE_ESPICLK] = { 19, -1, "espiclk-gate", > > > NULL, CLK_IS_CRITICAL }, /* eSPI */ > > > > > > This is fine for systems that have eSPI. For systems that do not use > > > eSPI, the clocks are not "required". > > > > > > I was sent a similar patch by Jae some time ago: > > > > > > > > > https://lore.kernel.org/openbmc/697a184b-ef99-a46e-bf98-4d339b3aafd8 > > > @lin > > > ux.intel.com/ > > > > > > Better is to associate drivers with these clocks, and those drivers > > > will ensure they are left enabled. > > > > > > Alternatively, we will need to come up with a device tree binding to > > > describe the hardware requirement that these clocks are left on. > > > > > ASPEED BMC SoC have SuperIO device that default enable, even without > BMC fw boot. > > Host can use SUART1/SUART2/GPIO.... > > That the reason even Linux kernel boot should not change the SoC default clk, > that is the impact. > > Ok, that makes sense. Linux will not enable these clocks if a driver is loaded > for them though, so we should load a driver for them. > > ESPI: We do not have an upstream driver for eSPI, but once you submit one this > will solve the eSPI issue. > > LPC: The existing LPC driver will enable the clock, so by loading that this clock > will be left enabled. > > UART1/UART2: This is harder, as the SUART mode means the BMC does not > load a driver for these devices. We could add a property to the device tree to > describe the clocks that must be left on? That following the example, BMC is stop in u-boot stage, the eSPI and LPC UART1/2 can still work fine. But after boot into Linux, the eSPI and SUART1/2 can't work anymore, it is disappear. That is not consistence between U-boot and kernel. The reason is the same with AST SoC also have VGA device capability. And another point of view, clk framework provide CLK_IS_CRITICAL flag to support this, instead add more driver for this. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel