From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AE2BC00144 for ; Mon, 1 Aug 2022 13:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xGR2a8HBggucduWKfDrSGATjHPf7Q3nXWyTJLwEXCWA=; b=rKaD3E66HjnJI4 2yw5DZkADFJLU0K3UPwG/M522+LwGLXrxbhDVzDA7ezQqhjRCai4xd8wOcYkyg7/D4Nkbpa43Ot/c 8hTySfPjbMIVFVq5COg2nwRwhMwC0wD5kzrq3CTaHrlmcZrfQIeAJ7x0Krrgwu/QKlArFp84xXInG Amqma5oGL7udgcax817cKwIugHQqvXCBr54K+3AnIrbzVIt1kqdLUoqzpeJp1jr4tKfs/E5ieYswp 7+p9fDh3DOXPKd0OIaRRSXYOjOyIvbP3EejOZpg7C1GM8q+avbdWjw/9ER4dZRAmbD0SjctiqUBAi 0GVTb6NlJbpjhV+pXh7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIV4K-006VAs-UK; Mon, 01 Aug 2022 13:02:49 +0000 Received: from mail-dm6nam04on2073.outbound.protection.outlook.com ([40.107.102.73] helo=NAM04-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIV4B-006V5L-UB for linux-arm-kernel@lists.infradead.org; Mon, 01 Aug 2022 13:02:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GJncnmsOTuIlKoIo6khqM+HvQZh5/Kxu6X0RaVNz1jUCK/sKXgfEaZyf9zdBThCkOBQ2qvYkIem2+NM1urwmbrp0DlCZkLmpDXWIWV98ru9VpSsW/C+0aq3/EQl99MU95cyzTBBRCYxtCUif+iDBgBNxhN0dTW+AE0yfjdzqvYSDnL2IIkGfIgqg4y5oVRHy8qLMjR4l2NNEKDWh0myRNc/Gennooe7a9TR6pLDrjjBfIhr+LtWtxgsp0vmz/MBFthI+WZQIAAGOwFyGcyfs1T9iQwhVznqs+ufyJN5jQAMI21tqfatMRMX/XFmAqL0mku8qGuIpTUPQj/rw59jEtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v5l/saffsFtHk39a6efbutMsXvbljNfj8duFl7ku4mU=; b=AnX+k1eV8xO31cKhflAfc/+9sLa15fuuO30Uqtl8vqIkHu/NuXc4mEUX0+CKG/+ZBe5xBIwl42oSASE1a1C8tkxEKQC7HO6Zz3EXo1CDlV5LiiHLRGIjsZQgec1dJ8JwBxpe5XetR/sJO1g11TWFLWH3mG1BTEYMuZXWenNQSthAO8qXxmCxUDIxdfv8uWP+9DLRhjY0Q7gA1Y+QLbr6oOGB46mEjuDnG61bqx1FhNKDdrlpt9Zh+129NAWhG5qUffgr7T2ibu+TfVoLaCdNmjJepPhd/q4tqPmgEBq1upGfwWF+egEQnM2WZtZbZv6qhpFq5SBJ2zHVmrLJ6C3+Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v5l/saffsFtHk39a6efbutMsXvbljNfj8duFl7ku4mU=; b=QZuCTxSPeH59WoNMVkbv7wpk6+e+M29uM2GAOlCMwG93uTRA7oO7WlAnZ14fqZjQiHRyLlz3wqK/Xa6nSQBgVQc7myf3K55WCA602iavnmg+g6oq3vGPIxr7yLeShdW3/zUIKWwBxhwt0mN0R2lnDfsFrxr1Rk6lvX9elu5/TCk= Received: from MN0PR12MB5953.namprd12.prod.outlook.com (2603:10b6:208:37c::15) by MW5PR12MB5622.namprd12.prod.outlook.com (2603:10b6:303:198::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 1 Aug 2022 13:02:31 +0000 Received: from MN0PR12MB5953.namprd12.prod.outlook.com ([fe80::bd1b:8f4b:a587:65e4]) by MN0PR12MB5953.namprd12.prod.outlook.com ([fe80::bd1b:8f4b:a587:65e4%3]) with mapi id 15.20.5482.012; Mon, 1 Aug 2022 13:02:31 +0000 From: "Pandey, Radhey Shyam" To: "Claudiu.Beznea@microchip.com" , "michal.simek@xilinx.com" , "Nicolas.Ferre@microchip.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "gregkh@linuxfoundation.org" CC: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "git (AMD-Xilinx)" , "git@xilinx.com" Subject: RE: [PATCH v2 net-next 2/2] net: macb: Add zynqmp SGMII dynamic configuration support Thread-Topic: [PATCH v2 net-next 2/2] net: macb: Add zynqmp SGMII dynamic configuration support Thread-Index: AQHYo4KewBDB6DbmFk6t7/0QH3lPKq2Z7pgAgAAWHkA= Date: Mon, 1 Aug 2022 13:02:31 +0000 Message-ID: References: <1659123350-10638-1-git-send-email-radhey.shyam.pandey@amd.com> <1659123350-10638-3-git-send-email-radhey.shyam.pandey@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d1312191-e50c-40c0-56f8-08da73be185e x-ms-traffictypediagnostic: MW5PR12MB5622:EE_ x-ld-processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uW9kvJGznMmgedMjZRTGyaix1X+nJYiUO6sWb2IIyws3DQgOOxFMaki9XXTn1+QCzh0I3lMP5ojGHuuWSn4hKfs0bhERk5hO1tRRhyRJdtR3H+uDzWan6ml14kqONjzm0vF9BBfaow55BUpW4xUzddUNtbKuFQJbCUooMc8TYKnZi9hLejExBkHdWQIJTHP9aC8ejDkwdLHp4kQ4ZdxGblwwQY9nFz2PQxCZlBHc2KK0lJRA+XPy3mqR0XM5Vetv5dM61wvMh7R15xmp9rHcq6jIA2VJxBGlM5mtgo2pP5em4wC2C7t5s3W8GyH2o/3HModXy+7khZVEy7uXgWBRrh3Ie8e+eclfLzn9KLak3yVgc87loWV09Xy+vYQb0LpdUDWLS0ac48ZDKg7HjazMPLyGxynC2x0e9C9BBKk6aiCkZA43AQHuNQ8M7HSDovNUUhjYVFO+W81rKE8CRY+KAHjunKuM0a7VlL09UDp30cDAeQ7TeO6LtfHDCvAxBKtiGoRDoq9YXZGfoJmALhN2usiRS0v2SVDj2GremLismU0iIjEDhnUGelmRlrQ0tT5+jSicMl8riZYj2s7t0FNK/83iKBoEJ/JseAKheyEwIsns+x8Yia0fkYS5pWfWiWlHq3SqzAJGyIc6aHggySjyPVaKxtyFp7gSH7bPbk5zsSps2+7UxLqA/ae/e1rlF9WZ9L0hVKS/0rHpEEwpE6+cTRNhtBZ3CUlGYe7IuAiGbCb7dsg8YDPlrnl/2QW0t51NF11Vt7zm2BIfpsAaPJ2K1QKpSTcDaPiUBMdB5Bzhh04= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR12MB5953.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(39860400002)(376002)(396003)(346002)(38070700005)(52536014)(64756008)(33656002)(186003)(6506007)(8936002)(5660300002)(7696005)(86362001)(38100700002)(41300700001)(83380400001)(2906002)(53546011)(66946007)(110136005)(7416002)(107886003)(9686003)(71200400001)(478600001)(316002)(55016003)(76116006)(4326008)(66446008)(66476007)(66556008)(122000001)(8676002)(54906003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cWVCMFg4UVg1WkFwckxUVGtBL25sWmpGalUwdG05aFlMVDliNHhIZlhTdzVa?= =?utf-8?B?NHNyU1dZNmNwSnhCNDE5ZXVGenRPRTdrdmRuTnVQeEREbTdUTjhZWHVwRnNr?= =?utf-8?B?V2YyZk4rN3hPNE5VZFRwQldhemRrZlFXSUJEM0VvMjlESFVBYmpZQm9Xc3dq?= =?utf-8?B?OXd3UVQva3ZEVUE4aS9EQk1rTEdIR3Q4MVNRUXZBM2dVcytNazk5aFJUbGc0?= =?utf-8?B?bTNRcjhGTHRYSEx4THkvNkZKZ1dta0t6MmNrVkdhVFVJYjhJNjdSem9DVnIr?= =?utf-8?B?emNITUM1VHpJRVV1WFVDOTBpc3F4Q2F2R0pLTFpSWGlLZzUrY0xrOWF2L0lC?= =?utf-8?B?NXVXd3ovTDFqUjNLRjFlemRzZC8vWEN3VVE3VHU5YlV4MFdJZ0hKM2lEbDFR?= =?utf-8?B?ZmdhbUh5d3Z3S1NnR29rRnM1L3A0L01hTDE4VzR4OFVMc0prZUpsOFlFalZy?= =?utf-8?B?NktRV2NZWnpZcmFOZlV0WVNUUEx6Z3F2N01TVGI0VFFySmMyZnJVKzREdVE5?= =?utf-8?B?YStQSUlzdy9YUngrT1F0cFkrcDZMVFZTcnc5RGpQVGhmVjQxTmwxdG53Nkx4?= =?utf-8?B?dWlHNHVmSDhyYzUzb0NEditLYjNhZllEVnVLV2U1UFArelpSelhQckZZN0Zi?= =?utf-8?B?NUhxUHNwTE5JMnlNb2JoQmFNQ1R1QUFmbEVBVVZwQ21LMHZWY2tGVkdCWVlU?= =?utf-8?B?TThQSEZiVTh5WFZvSXJJNnBPWXJpQmN6Y0h6S3pvWkV5YVhsY21TbSttd3BC?= =?utf-8?B?WmptcHVpV0MrR3NiVXJYYkFKRlJ3OXZtWllIYTZ4MDFxTXY3cG9tQkQyTFAv?= =?utf-8?B?bmMva09OZThhTkltVXlJZEhYbTV0QnN4TlZrNnFFVXYwcXovczBTNjA5aW00?= =?utf-8?B?dWtWZ1hDVmg1NnZidnJKWXVVTE16ZDNDaFNvQlMvMmdrcFNyMHBZdmlWWFdq?= =?utf-8?B?anhsbmhPa0ZzcllDWWhBNVlXWTFWVVJZSEMyb1RIT0hUUVB2U3Jzb0NQRHV2?= =?utf-8?B?MklNOWJEb1VZdU9BM29GV2daMlJyd0FRY3ZzbmtUOUlQZ3VVQk9ha2RaUkVp?= =?utf-8?B?Y1FabzY0NCtOTXBxbW9CQXFYblh3WE8wUkh6UDhCbnN6czBTbFlPckd0andJ?= =?utf-8?B?N0M1Z3lkbHQ0YlFnYWZPaTBHK25MSlFkMnlMcERlSTRnczFiSlRUbFZoMHFM?= =?utf-8?B?MGdyTElOeXp6MCtYOW5wZXF4QjZKRHJoVHpuZnF1dG4rUGpCQ3c5dk13WVBT?= =?utf-8?B?bE5BN2s1ZmtqT2NuazJ1czhnZzZSUGtsRnBRZG55OGxBTmNCUXNFV2R0R1oz?= =?utf-8?B?bmtqZm52ckpZbW5md3VtQ2RDQ2JRRXEzNm02czFwQllJMk5McnBFTDVjMDR4?= =?utf-8?B?b2lRYVpkT0ZxZlBoVzJNZFNNYnptcDNTblcrTThDNU5RTjdnWElpOEIrUE1C?= =?utf-8?B?K0F3NlpDRGplN3ZZcytoczhmR3NHYWtCS0JiMy9QV3p2U2pUSUtheUVHMkM0?= =?utf-8?B?RTFCN29YRjJwRG5oYUd1SzhCaDVBLythT01kOG1yWnRtSlIyQTdwZ3lXUmpi?= =?utf-8?B?L2h0eWxDU2FEemF2YXVtNkdoQ2tvb3hMblUxL2dwb1FaRWFwSkI3aXl0bi9C?= =?utf-8?B?K08zdXY1aVZ6ZUtiYlBLazU3UzkwamlHbE1OY2ZBL1lGYlpEaVIrVC9sQXZ5?= =?utf-8?B?Rk9WVkwvOWhCS3cxR1U3b3RoUXVoa2NaUEFtOXZqUFc5TG1VMmN5cExmZnhU?= =?utf-8?B?YWEzdXpzWDFlT2Y3N3Q2SWZBc0c3TGJFaEhwdHphUURtdlRKd2hrK2RiQW5R?= =?utf-8?B?S1crWERXSXN6NmZBdGtUcFNrSFNUMTFBSGRDN3RLYzkvdHlzRTBHejZpTC90?= =?utf-8?B?T1I1Nmh6SEdUdFlYR3RPWVBwVlNMUzhJZzdzV1V5bkZNc1Q1RGZuQVNRcFlB?= =?utf-8?B?bFZTSlpla21qSG94cy9NaVBiMFkwRzViZ2VyeGh4aVBlL2h6ajM4N1oya2FY?= =?utf-8?B?UkV0ZVEwVmZwYndGUnN5WnpIZnVpYUpMVlE0VktYWDF5eGNWa0M0RGxvT2VT?= =?utf-8?B?OHBvL01KR3Eyc21kaWpNVmlWSXJuQVhyQlNQM3piWjZFUXlFV3hvaHdCa3pq?= =?utf-8?B?R1h1Vk1KZ3M0TjQxckd6TjBIZ2JnK2ozSGRFd1BsVXJaL1o4VGYveFNMdjdZ?= =?utf-8?Q?lyB+4f2aO/L4IJuOEr9Jlds=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5953.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1312191-e50c-40c0-56f8-08da73be185e X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2022 13:02:31.6006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 97icgT/QEYNrzXC+lG2j9H+n75679+y14qV6j8HeN3zzJQPvN4d87jR7z+1AmmgM X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5622 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220801_060240_072750_B08A284A X-CRM114-Status: GOOD ( 29.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Claudiu.Beznea@microchip.com > Sent: Monday, August 1, 2022 5:06 PM > To: Pandey, Radhey Shyam ; > michal.simek@xilinx.com; Nicolas.Ferre@microchip.com; > davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > pabeni@redhat.com; gregkh@linuxfoundation.org > Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > netdev@vger.kernel.org; git (AMD-Xilinx) ; git@xilinx.com > Subject: Re: [PATCH v2 net-next 2/2] net: macb: Add zynqmp SGMII dynamic > configuration support > > On 29.07.2022 22:35, Radhey Shyam Pandey wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > > the content is safe > > > > Add support for the dynamic configuration which takes care of > > configuring the GEM secure space configuration registers using EEMI > > APIs. High level sequence is to: > > - Check for the PM dynamic configuration support, if no error proceed with > > GEM dynamic configurations(next steps) otherwise skip the dynamic > > configuration. > > - Configure GEM Fixed configurations. > > - Configure GEM_CLK_CTRL (gemX_sgmii_mode). > > - Trigger GEM reset. > > > > Signed-off-by: Radhey Shyam Pandey > > Reviewed-by: Andrew Lunn > > Tested-by: Conor Dooley (for MPFS) > > --- > > Changes for v2: > > - Add phy_exit() in error return paths. > > --- > > drivers/net/ethernet/cadence/macb_main.c | 25 > > +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/drivers/net/ethernet/cadence/macb_main.c > > b/drivers/net/ethernet/cadence/macb_main.c > > index 4cd4f57ca2aa..517b40ff098b 100644 > > --- a/drivers/net/ethernet/cadence/macb_main.c > > +++ b/drivers/net/ethernet/cadence/macb_main.c > > @@ -38,6 +38,7 @@ > > #include > > #include > > #include > > +#include > > #include "macb.h" > > > > /* This structure is only used for MACB on SiFive FU540 devices */ @@ > > -4621,6 +4622,30 @@ static int init_reset_optional(struct platform_device > *pdev) > > "failed to init SGMII PHY\n"); > > } > > > > + ret = zynqmp_pm_is_function_supported(PM_IOCTL, > IOCTL_SET_GEM_CONFIG); > > + if (!ret) { > > + u32 pm_info[2]; > > + > > + ret = of_property_read_u32_array(pdev->dev.of_node, "power- > domains", > > + pm_info, ARRAY_SIZE(pm_info)); > > + if (ret < 0) { > > + phy_exit(bp->sgmii_phy); > > Could you move this to a single exit point and jump in there with goto? > Same for the rest of occurencies. Ok, will make to use of common exit path and send out a new version. > > Also, I notice just now that phy_init() is done only if bp->phy_interface == > PHY_INTERFACE_MODE_SGMII, phy_exit() should be handled only if this is > true, too. If phy interface is not SGMII bp->sgmii_phy would be NULL and calling phy_exit should still be fine as these phy APIs has already a NULL check. > > > + dev_err(&pdev->dev, "Failed to read power management > information\n"); > > + return ret; > > + } > > + ret = zynqmp_pm_set_gem_config(pm_info[1], > GEM_CONFIG_FIXED, 0); > > + if (ret < 0) { > > + phy_exit(bp->sgmii_phy); > > + return ret; > > + } > > + > > + ret = zynqmp_pm_set_gem_config(pm_info[1], > GEM_CONFIG_SGMII_MODE, 1); > > + if (ret < 0) { > > + phy_exit(bp->sgmii_phy); > > + return ret; > > + } > > + } > > + > > /* Fully reset controller at hardware level if mapped in device tree */ > > ret = device_reset_optional(&pdev->dev); > > if (ret) { > > -- > > 2.1.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel