From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08CE2C31E5D for ; Tue, 18 Jun 2019 04:59:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB7C52085A for ; Tue, 18 Jun 2019 04:59:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cilVNSMQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="AqLbGOr0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB7C52085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ls1XOKJd2k21mLtjPlCe3coBe/aDPK3AQZwae2fYSEo=; b=cilVNSMQoZZdkV eS4Kg7soD+Epw0ndkaFGwNfBIXR/vFOciJcJbsTrWzF12USgy/rtbbABgpUirYAe21ZWmfkHLyy5m Xx8A7YO4OHGLANO6vcf02EwKlaIYRy/QIGFwcqyk/pjb0yU69p9UJQCJPDZ4bM5FUxEvICRKEOkt/ 4ayYWbwP+91rN022/aqqcN7k4bVDWPvPSFv5Nraj1Mad7lZgG3eWUn4Yarxk5qC3PMfsfkFAWfQuq 9AQipbfoRwnbaoOxwAvwQsLHKbh0Aopg6LuaSVLpLV1loJwg4jrtF4lEFBOW+xdW1j3cVjUnsEVJK qAX3SC8ef1nDwWVp24XA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hd6DN-00041E-56; Tue, 18 Jun 2019 04:59:25 +0000 Received: from mail-eopbgr750074.outbound.protection.outlook.com ([40.107.75.74] helo=NAM02-BL2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hd6DJ-00040e-OE for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2019 04:59:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6YkMxd8j2d8QMpQ7UnpLoxtqgbUrfqoLnenExYUsNW8=; b=AqLbGOr0lXVVp00q/WibCwYdyGpayaeaTWozDV+NFowb6wWrFmWJiha8ZGwMNOQj3i0e0Lu15VKu5yXjqrFUeFMsZ422+DQssSh/6cvaFrWAlmraQnf3w9WU0fSnF7Tlp2hdMcLVyGQ/D/a56p6joB9PqxOxGnW25si/wYsI+Aw= Received: from MN2PR02MB6029.namprd02.prod.outlook.com (10.255.7.10) by MN2PR02MB6365.namprd02.prod.outlook.com (52.132.175.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.11; Tue, 18 Jun 2019 04:59:16 +0000 Received: from MN2PR02MB6029.namprd02.prod.outlook.com ([fe80::e55a:e2d1:953f:ed3b]) by MN2PR02MB6029.namprd02.prod.outlook.com ([fe80::e55a:e2d1:953f:ed3b%4]) with mapi id 15.20.1987.014; Tue, 18 Jun 2019 04:59:16 +0000 From: Manish Narani To: Ulf Hansson , Michal Simek Subject: RE: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup Thread-Topic: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup Thread-Index: AQHVIDwWKZKZdF95gUaFGq/oqBvspKafu1mAgAADioCAAA8FAIAAIhYAgAAJ3oCAAOY6IA== Date: Tue, 18 Jun 2019 04:59:16 +0000 Message-ID: References: <1560247011-26369-1-git-send-email-manish.narani@xilinx.com> <1560247011-26369-4-git-send-email-manish.narani@xilinx.com> <5feac3fb-bef3-b7d1-57d6-81e115e1f555@xilinx.com> <948514a0-e310-75fd-e8a8-6ef8bb14e41f@xilinx.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=MNARANI@xilinx.com; x-originating-ip: [149.199.50.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c1f67496-6674-4497-2c5e-08d6f3a9b702 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:MN2PR02MB6365; x-ms-traffictypediagnostic: MN2PR02MB6365: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 007271867D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39850400004)(396003)(376002)(136003)(366004)(189003)(199004)(51914003)(13464003)(72206003)(76176011)(6436002)(14454004)(102836004)(53546011)(7696005)(99286004)(7736002)(66066001)(86362001)(3846002)(73956011)(2906002)(52536014)(6116002)(64756008)(229853002)(76116006)(66476007)(6636002)(5660300002)(316002)(305945005)(8936002)(6246003)(71190400001)(33656002)(25786009)(476003)(53936002)(4326008)(55016002)(446003)(11346002)(486006)(256004)(26005)(66446008)(478600001)(81166006)(81156014)(9686003)(8676002)(66556008)(71200400001)(74316002)(66946007)(68736007)(54906003)(6506007)(186003)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR02MB6365; H:MN2PR02MB6029.namprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: xilinx.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: QcghaE8dkJ5+B7n7sZVwficMMEzeZiaBluozbADTyJQqwo+9H56I5gy/6TAwVc8kG8oFYYeLUOqblJEOWtrlgc/twC9saZiinqN1Q34E05yOZf3Y+xLRAe9vaPHLah731x3CO7bEcfpTljKq+cY6UFehUkboarhSElRXEg6in7jWtgFBrBj8uDZpIltbEKxH625Y8c6vQgzPGNf1GaNhgbpLQvMjzNqHrZ8W5cxZT/Bail82wlPBTvxj2BuZz6Z8E3862PvONif8+2/e5stjHDIVMfGQmiQPOMQweJPRQBL2vWMxTIFpjTXpITN0Y6JTGAlgW9wYN+jurtFM6ObA/fqaxgsAU1w05x6+MhNal0XyL23PUWYU1ZfaVg5Q5KMR3nH7hI6tVm0lGXUF5FbRoU6q7OYTPaAJmW5blpxWLPQ= MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1f67496-6674-4497-2c5e-08d6f3a9b702 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2019 04:59:16.2860 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mnarani@xilinx.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB6365 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_215921_797229_7DFD87DA X-CRM114-Status: GOOD ( 23.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , Nava kishore Manne , "linux-mmc@vger.kernel.org" , Adrian Hunter , Linux Kernel Mailing List , Jolly Shah , Rajan Vaja , Rob Herring , Olof Johansson , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Uffe, Thanks for the review. Please find my comments below. > -----Original Message----- > From: Ulf Hansson > Sent: Monday, June 17, 2019 8:29 PM > To: Michal Simek > Cc: Manish Narani ; Rob Herring > ; Mark Rutland ; Adrian > Hunter ; Rajan Vaja ; Jolly > Shah ; Nava kishore Manne ; Olof > Johansson ; linux-mmc@vger.kernel.org; DTML > ; Linux Kernel Mailing List kernel@vger.kernel.org>; Linux ARM > Subject: Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP > Platform Tap Delays Setup > > [...] > > > >> > > >> > > >>> In regards to the mmc data part, I suggest to drop the > > >>> ->set_tap_delay() callback, but rather use a boolean flag to indicate > > >>> whether clock phases needs to be changed for the variant. Potentially > > >>> that could even be skipped and instead call clk_set_phase() > > >>> unconditionally, as the clock core deals fine with clock providers > > >>> that doesn't support the ->set_phase() callback. In the current implementation, I am taking care of both the input and output clock delays with the single clock (which is output clock) registration and differentiating these tap delays based on their values (<256 then input delay and >= 256 then output delay), because that is zynqmp specific. If we want to make this generic, we may need to register 'another' clock which will be there as an input (sampling) clock and then we can make this 'clk_set_phase()' be called unconditionally each for both the clocks and let the platforms handle their clock part. What's your take on this? Thanks, Manish > > >> > > >> In connection to another version of this driver for latest Xilinx chip > > >> it would be better to keep set_tap_delay callback in the driver. The > > >> reason is that new chip/ip is capable to setup tap delays directly > > >> without asking firmware to do it. That's why for versal IP there is a > > >> need to call different setup_tap_delay function. > > > > > > The ->set_tap_delay() callback is for ZyncMp pointing to > > > sdhci_arasan_zynqmp_set_tap_delay(). This function calls the > > > clk_set_phase() API. > > > > > > What does ->set_tap_delay() do for the latest version? > > > > There is different set of default tap delays which should be programmed > > and it is done just via writing to registers which are the part of > > controller address space. > > Okay, I see. > > Not sure what makes most sense to do here, but it sounds to me like > another ->set_phase() callback should be implemented for the clock > provider. In other words, calling clk_set_phase() should continue to > works just fine for this case as well. If it turns out to be > inconvenient, we can always add the ->set_tap_delay() at a later point > when it makes more sense. > > [...] > > Kind regards > Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel