From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 169F2C49ED6 for ; Wed, 11 Sep 2019 10:57:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8B362089F for ; Wed, 11 Sep 2019 10:57:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kzVuyD6c"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="o58ht/pK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="v6F6r6XM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8B362089F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+sLTOGMweGQn5Z3Cw+qPDUbLe8qSfnVsNOX9QGrjIWw=; b=kzVuyD6cxQmYZ7 EYH/D6ChRSzjtV3bZJBWzzk/Ur3rHbgw2p5VeUad8NdAQSKlP6CsBjAmDpgt40KH//qcJHos+CPtR sVhVo0I0n7KIf39Lk87aydtEGOr9dMqF1BiDKHvyKgmiy2lVpQZGYWXyjUj3SzyBJUpexYlFVWQVI FS9igh4e0osQQ6CaYOWe1JTNHzgD7c+seDyELUHgBZl1FfCWvdOAoXkpRliUhX+waoXsa7wJQG8RY onk/opmWMUPiT4hNxCemws88XkXlJaR79uPT3WGuRz1MLWOnbHV61vDWfMh6z3Kw/ujdw2B6jcBN1 LRxWgZx7d3/mW/q1QqNA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i80J2-0008Vl-GL; Wed, 11 Sep 2019 10:57:00 +0000 Received: from esa5.hgst.iphmx.com ([216.71.153.144]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i80Iv-0008QU-Hc; Wed, 11 Sep 2019 10:56:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1568199413; x=1599735413; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=sUFy62V12BwpeA+iJe293nD+g2KS8NuuSG9P6NFcZO0=; b=o58ht/pKsUa9E1+QGTHQutFMHYgiC621NkbHfjkEDu8zzjBR81avRQXB 5goE8UvA3eQtilz4Qk7TBu1zcOfg4JbInnfLp/1U8ew5OzvMuEAPGMBY2 W1KYO8s6LZ/1sWETnGb6CodwZuNSJScWt5rG1nS73bYDJ2mFc4wYKGPGV g7tBFfA4wmpiHjA1W6wOwpRSVZpvfczddrQOQvLD1LPNCUoMMpdgzxcWZ N+nOj7C+6RRRKYwwAVn0w2VlvUZKwrzuQOSceNxdjAzSTpjYp+SDyM9YW +6Q6DRZPkF9QOb+0ngy1ZtNy2v/AR6aq0vY+QG2PRebIHmVPuGX1o/WA9 A==; IronPort-SDR: M7rB/e8fbVJlyXkSLoKIMZE6yVrKAvvSZ1w+XI5bUE20j2M0l6QhHdqBJ7YYyjg2Br5W/kpO+z NwrnADxNRJxFKxLQ0gjL8SEFLxmMTxhy44oqS7pc40tYCaqgXtF4BXTdiUp+drq/+5OjDWadK6 zMg75+UyX2Nz8XBPHWJOJkfYCmI10tdSRH96GGrM5zRREtxJY+oVen6T4ANQUHY2IR1v+zugMX ezbZaG7sX+FqC+weH0NEuvuJ/7Ffqud3Bl+YJmHyBzGwJn6rt0YrMp3e7nIkxIYAVz83kUimXS xaU= X-IronPort-AV: E=Sophos;i="5.64,493,1559491200"; d="scan'208";a="118859565" Received: from mail-dm3nam03lp2051.outbound.protection.outlook.com (HELO NAM03-DM3-obe.outbound.protection.outlook.com) ([104.47.41.51]) by ob1.hgst.iphmx.com with ESMTP; 11 Sep 2019 18:56:49 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cZ9XdsRo2Zh3t4ZxM1VZJboCZfTKi2qMltLs+IDbuq0A/y1PBg9/aoQbsV6PNhXBKS0P2Xb2F9Gr0sHY4nH4p7qQmvP9EPE6ycWRPfLfzMst+Nz4qjS28K1xfBmB/Vb5z7JKlJbQ16RHeqW2YWt9Xx14+GFW4ZtEExd5Mq3tBKZnm4Zbya4rlAM3fgkUSVUzpuIZcoKAOpqZmL9wA79Vr5ZAHH6/ri3oAhwwE1KQDVV9kuCQo8fCr5DvVFfTXsmVite/9q2bd/WWX+7fypHcIyxicnUQZus9fJytkP4ngBES5h+Tcsza4gFjXJDtQLxEk6Chf3MtWTeDJB23uSIjuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rbxjv8MXFBnD9UmmcyNeYuu7BaY377X3li+Ke/Q3Nms=; b=JJTi9hyco/6tYNol88U+nE4egiKeGBpSUegDbnpal7ysv7Wmn3zlx108n4j2D6w/5kWq9DELR5RkaRf8a5/HyQi59muVFzxSdMqZ+nyo/YdlhImYpnQM5hm25KuTSE/C776B5OvNb11CyCsi7AzOg+ZpoC/Gg4oC6czlNenBmme5ykgQRhpPWVH37KgfG+Ro1lb5G48/bbqm4IwCAs7JHQ/JhVglFvMrj7h+zDDVHm5ogR9c//R9FmHFylmrlzgNw0dR/txkwZaut35B7ZRo/jPcdh/GS9aWsOg29KFm2MxvRDZBlZtQTD3p+FH2ZwRRgZLSd0rOD12wxaKdsWi5ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rbxjv8MXFBnD9UmmcyNeYuu7BaY377X3li+Ke/Q3Nms=; b=v6F6r6XMVDZBA11S9zYLLulc/PeBbvyleEsxw/kDIDp0EoXbdutYpzTVfa18BTWpTxZSsyS72l5WVly+ZQSQi2bKcxN2Z/iWGFx1dM29nXSYnLJIyuftEBDEPlO8F/Xx3LcTYS+Y1sqlvCymZ0BMdyM9ttui7rEwhQu9ThW9+uM= Received: from MN2PR04MB6991.namprd04.prod.outlook.com (10.186.144.209) by MN2PR04MB6942.namprd04.prod.outlook.com (10.186.145.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.15; Wed, 11 Sep 2019 10:56:48 +0000 Received: from MN2PR04MB6991.namprd04.prod.outlook.com ([fe80::9c2b:ac1b:67b8:f371]) by MN2PR04MB6991.namprd04.prod.outlook.com ([fe80::9c2b:ac1b:67b8:f371%2]) with mapi id 15.20.2241.018; Wed, 11 Sep 2019 10:56:48 +0000 From: Avri Altman To: Stanley Chu , "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "alim.akhtar@samsung.com" , "pedrom.sousa@synopsys.com" , "sthumma@codeaurora.org" , "jejb@linux.ibm.com" , "bvanassche@acm.org" Subject: RE: [PATCH v1 2/3] scsi: ufs: override auto suspend tunables for ufs Thread-Topic: [PATCH v1 2/3] scsi: ufs: override auto suspend tunables for ufs Thread-Index: AQHVaIUfYjJD70fr/kKF3DSWp7K95acmTYpw Date: Wed, 11 Sep 2019 10:56:47 +0000 Message-ID: References: <1568194890-24439-1-git-send-email-stanley.chu@mediatek.com> <1568194890-24439-3-git-send-email-stanley.chu@mediatek.com> In-Reply-To: <1568194890-24439-3-git-send-email-stanley.chu@mediatek.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Avri.Altman@wdc.com; x-originating-ip: [212.25.79.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d7d85e6f-1c41-459d-0255-08d736a6be42 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:MN2PR04MB6942; x-ms-traffictypediagnostic: MN2PR04MB6942: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0157DEB61B x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(136003)(366004)(346002)(396003)(39860400002)(376002)(199004)(189003)(446003)(476003)(81166006)(81156014)(6116002)(3846002)(186003)(66556008)(66476007)(64756008)(66446008)(229853002)(76116006)(4326008)(86362001)(14444005)(8936002)(66066001)(7416002)(66946007)(8676002)(256004)(26005)(76176011)(55016002)(7736002)(11346002)(305945005)(316002)(53936002)(9686003)(7696005)(74316002)(71190400001)(52536014)(478600001)(486006)(71200400001)(5660300002)(110136005)(54906003)(99286004)(2201001)(6436002)(15650500001)(2906002)(33656002)(102836004)(6246003)(25786009)(2501003)(14454004)(6506007); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR04MB6942; H:MN2PR04MB6991.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: P/gEi7NLvroocXTSWjO3cu+yqj/OA/PON3sE+hqKO1qBm1Qiwqgn6m0qWuDrUV7unEuWjJGhjGY3GCsdDjI52QBdLcQyP06bWjA4suLd8N6fQmHvY6q4sGjEQZfNGe/fxTBBxcyTKQCtLCy+Tf42BJUPjgmoruAZLIFJPgMHeDFik6AF21HFUB6l17QIsaJf5jtVf0cYHcDeWiBkBKov2OuXTthqba55s3uCwdVJfabwPvhQKQUzlztJBxopuK49HhBmjhhxuz7W/PThuDM+QbeW0S7/3+wQ4lBobSCTKXgi1wN9DrJECHFvx1ZO7xk+DJegDKgbhC7fmiO3WBgFjrgE9uZuaLcpH6uNNmb8+Jkpb5LKKdm9I41FznqlXqdbMrUhd+6suSOErkihrAnfh6kPvTA6rJm0Bs7LOjOHjH0= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7d85e6f-1c41-459d-0255-08d736a6be42 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2019 10:56:47.8721 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FefgIR256x1G0769bJoc8dcHKSommTbfKQ4pYFC1pcKPb8awOwITJZz2UjuZMZAMEERGvMLs9eUY+uVQL5GVLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6942 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190911_035653_591201_680D5500 X-CRM114-Status: GOOD ( 18.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "marc.w.gonzalez@free.fr" , "andy.teng@mediatek.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "evgreen@chromium.org" , "subhashj@codeaurora.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "vivek.gautam@codeaurora.org" , "matthias.bgg@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "beanhuo@micron.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > Rework from previous work by: > Sujit Reddy Thumma > > Override auto suspend tunables for UFS device LUNs during initialization so > as to efficiently manage background operations and the power consumption. > > Signed-off-by: Stanley Chu Reviewed-by: Avri Altman > --- > drivers/scsi/ufs/ufshcd.c | 8 ++++++++ drivers/scsi/ufs/ufshcd.h | 10 > ++++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index > 30b752c61b97..d253a018a73b 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -88,6 +88,9 @@ > /* Interrupt aggregation default timeout, unit: 40us */ > #define INT_AGGR_DEF_TO 0x02 > > +/* default delay of autosuspend: 2000 ms */ #define Typo? > +RPM_AUTOSUSPEND_DELAY_MS 2000 > + > #define ufshcd_toggle_vreg(_dev, _vreg, _on) \ > ({ \ > int _ret; \ > @@ -4612,9 +4615,14 @@ static int ufshcd_change_queue_depth(struct > scsi_device *sdev, int depth) > */ > static int ufshcd_slave_configure(struct scsi_device *sdev) { > + struct ufs_hba *hba = shost_priv(sdev->host); > struct request_queue *q = sdev->request_queue; > > blk_queue_update_dma_pad(q, PRDT_DATA_BYTE_COUNT_PAD - 1); > + > + if (ufshcd_is_rpm_autosuspend_allowed(hba)) > + sdev->rpm_autosuspend_delay = > RPM_AUTOSUSPEND_DELAY_MS; > + > return 0; > } > > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index > a43c7135f33d..99ea416519af 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -714,6 +714,12 @@ struct ufs_hba { > * the performance of ongoing read/write operations. > */ > #define UFSHCD_CAP_KEEP_AUTO_BKOPS_ENABLED_EXCEPT_SUSPEND (1 > << 5) > + /* > + * This capability allows host controller driver to automatically > + * enable runtime power management by itself instead of waiting > + * for userspace to control the power management. > + */ > +#define UFSHCD_CAP_RPM_AUTOSUSPEND (1 << 6) > > struct devfreq *devfreq; > struct ufs_clk_scaling clk_scaling; @@ -747,6 +753,10 @@ static inline > bool ufshcd_can_autobkops_during_suspend(struct ufs_hba *hba) { > return hba->caps & UFSHCD_CAP_AUTO_BKOPS_SUSPEND; } > +static inline bool ufshcd_is_rpm_autosuspend_allowed(struct ufs_hba > +*hba) { > + return hba->caps & UFSHCD_CAP_RPM_AUTOSUSPEND; } > > static inline bool ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba) { > -- > 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel