From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B45CFC4332F for ; Wed, 12 Oct 2022 10:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W2ixMCKGRww88M+2bFFH0vf65tQEDlH4YpZw9Kx60mQ=; b=XtpZLZSoYtu2oI U0KZKr33Ip5ABQkNxz+2fizN8o3eh0pgPZejxF4sZAZhtztL5Ml3T4zJPSryEkgEwUz87GXdLYnTj 8HWRpj0vd6o+gy1fitp/g9chrqQdyYq3KMsGwfHqmazUGtNccEUokAzHy/D/5nC5aitHDLjY/V/NW B2YLAlFqyEacgJUZzAK04MsVSqHDyaJkwLKB0YZwRRYxfOKDlBw0ILg0loIpSmIlKn4/6yRZVYxxy a2wYUHJxrzIk9x50PXU+RkKCffvRvzfCpgOvzhk0bE6nwnYc4NhtuEW9VAOp+5iaT+L3r70qDmg4Q 6IebBxUxvwNI5SORYTbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiZ4M-007h04-Q2; Wed, 12 Oct 2022 10:34:35 +0000 Received: from mail-dm3nam02on2041.outbound.protection.outlook.com ([40.107.95.41] helo=NAM02-DM3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiZ4H-007gyb-Of for linux-arm-kernel@lists.infradead.org; Wed, 12 Oct 2022 10:34:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ib66tedVGxRIYKaBLRSeka6eFIPYKI8dz2MIJcazeBXE1gqEmGXT8AqpWvBcYD6dDgrYpdDmuFhdyh90a8PMa0Dg22hpgqzYE1tsT1ZQMGDNKMeJDpEyTXYGolChI5W+IMvAx/PkIHf4SLN+jn/UL06vPPjQmcWt0TFPZu5Cf2/UTP3H3MG0cqK5DLkg+wWufvkT9sF3oMnEQQ03AurytTx3Vwwpks6HmHDveKKGuj35wh8tDN6a7V7eh2du7QxvLp8bGP0yXWDTD88taVDJAMWtrXEIM5h6/UQdVsgWaQdC1a9AE379VkWIWLmbsRS5HOgm2UfswGLdkTYhz0KEhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8H82YeQdZ65jmCLPdhwfvGTkwVlz1+X9NsJMnlrlKoU=; b=Y77lDrlf6nSK2VliO9AxbtZWgzN3VZOVJtaQ7zBGI99+/aoHI4yt0CMmkq4p9OrOuFoE4txGpLIN3LPf7xQSsN/j6HwA68XHoiUBnPWlREji5ROmxzCAZOkBXQV5HyfkCaP3ZsYzF17IOcxhio/8oaR2DRemX+VjZSwl9Z3hUncFsX5MGryZ4ShI5kZdio9m3YHxrbKk1r0eo5VjPZsN1H8+jlCB0/5NSH3oEyG2QftfQvpaW5eETD6utPNdXeo9KvGt8jYoOg2u1IXrlsQukKMYj4I1yR4m5ykzuUUg+AUpcOewXnTGpG0/hL5qEw12okgqFDdg7Nfmftbk55ukcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8H82YeQdZ65jmCLPdhwfvGTkwVlz1+X9NsJMnlrlKoU=; b=xHSqyQrnIDAXBYW5oWZouCb2nJ0xlOv3exZlRErVGqbyBHe453U4calJl3ltdIS3EOh1IyfQbD25+Z/DaCMRSZMQU/xIAKfztXLUOy+7b0dzHCx8e87EC7/Ty3Aq3Mn1BX87oI2QSFQ7kNL7hLjeCwyujO3hBmtJKW9+ncrQSgM= Received: from MN2PR12MB4358.namprd12.prod.outlook.com (2603:10b6:208:24f::12) by MW6PR12MB7085.namprd12.prod.outlook.com (2603:10b6:303:238::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Wed, 12 Oct 2022 10:34:24 +0000 Received: from MN2PR12MB4358.namprd12.prod.outlook.com ([fe80::a094:c6b2:d306:d7bf]) by MN2PR12MB4358.namprd12.prod.outlook.com ([fe80::a094:c6b2:d306:d7bf%3]) with mapi id 15.20.5709.022; Wed, 12 Oct 2022 10:34:23 +0000 From: "Radovanovic, Aleksandar" To: "Gupta, Nipun" , Marc Zyngier , Robin Murphy CC: "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "gregkh@linuxfoundation.org" , "rafael@kernel.org" , "eric.auger@redhat.com" , "alex.williamson@redhat.com" , "cohuck@redhat.com" , "Gupta, Puneet (DCG-ENG)" , "song.bao.hua@hisilicon.com" , "mchehab+huawei@kernel.org" , "f.fainelli@gmail.com" , "jeffrey.l.hugo@gmail.com" , "saravanak@google.com" , "Michael.Srba@seznam.cz" , "mani@kernel.org" , "yishaih@nvidia.com" , "jgg@ziepe.ca" , "jgg@nvidia.com" , "will@kernel.org" , "joro@8bytes.org" , "masahiroy@kernel.org" , "ndesaulniers@google.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kbuild@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "kvm@vger.kernel.org" , "okaya@kernel.org" , "Anand, Harpreet" , "Agarwal, Nikhil" , "Simek, Michal" , "git (AMD-Xilinx)" Subject: RE: [RFC PATCH v3 4/7] bus/cdx: add cdx-MSI domain with gic-its domain as parent Thread-Topic: [RFC PATCH v3 4/7] bus/cdx: add cdx-MSI domain with gic-its domain as parent Thread-Index: AQHYwfdzMPgE56itm0GRwc9i4G18eq3T9LKAgDbLT4CAAAON8A== Date: Wed, 12 Oct 2022 10:34:23 +0000 Message-ID: References: <20220803122655.100254-1-nipun.gupta@amd.com> <20220906134801.4079497-1-nipun.gupta@amd.com> <20220906134801.4079497-5-nipun.gupta@amd.com> <87h71juxuk.wl-maz@kernel.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-10-12T10:34:20Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=9eba8937-eed0-45ce-8661-54be192ea195; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB4358:EE_|MW6PR12MB7085:EE_ x-ms-office365-filtering-correlation-id: 3b83d138-3afc-46e0-f359-08daac3d5474 x-ld-processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tGIs1GPXWNxXkDB1PLqtVQfeD0c6+OUhy4UVdmZlg2f3ZlGohzOL5tCDvzO/VEINeIu/TCl1ZDh1FXMFs3eXKe9+dP0fcGQqf5rvKbsgLGMyWwjZMPSFAlNOvVxT6bC6qN9po+SIMl9+5req6ro6hTJlZ6xjSuKGyJHZDcOqQgZ18wXPKYaDpmAlnD6uTooXZYcXMWdp7Ths4XoM/61intwa6puRLc4lzhWuM59h5AWxnmOLywOjBQ43sGzc0Dm13PTbB2TgDegRcocH5qlRnHqWKrkudvn2kvpnmz4t/pa7tt3Y5jfEYls3cIjk0VisNkjszhvXjR/orZXwPYZ22pWtZDm9ib6sB/36HdNGh5nX3to5uajjz6cyz3nxuj0jMLYFYt5/q2Oz9ChEO7GBmH4vQ1usxFQSl7JuCMIoDQ/7NgVwDVN2apLecagA/KT/UFhsxr0r+WGX/BlAG5qat8Ddm90SzwYlMhJzzkX/6sJCeY+j0Rh9dhRBuuSxWTED53FTlERsnsLow17hEuDemN6vnwpFsbQmkbhH8Yn5NxG9LaGqWhHdk0uAXm+EEmm8lpDaek/ViADCZ6z9txxk81x+xuGgruvHczA6lep8LLUf9VZxiNhhRbBfBeTKC/SBGgXwRL5NU/TRDFraD29tgAQMPX3psGgDKai38Ht+doA4EjZw4MunWQtzz478rdSTedfaz9RL/ZDnMs8ZqVmUWq7NQuRwT/NUEedOJDeVvg2U8mR0KwFgUCldBGVnC5D5zZIOA2H6Lh24N35Ye9G9qg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4358.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(376002)(136003)(346002)(396003)(451199015)(33656002)(86362001)(5660300002)(7416002)(38100700002)(122000001)(186003)(7406005)(38070700005)(2906002)(6506007)(7696005)(478600001)(76116006)(26005)(66476007)(83380400001)(64756008)(66946007)(8676002)(53546011)(316002)(66556008)(66446008)(52536014)(8936002)(9686003)(4326008)(41300700001)(110136005)(71200400001)(55016003)(54906003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2TeRKvfOr8/o5qM8NkQ3YxH7GFgxaMo+to9zGqep7/rmDem3sF25dW7pHLgL?= =?us-ascii?Q?vE1dhkR6AbXyPoCBdy3RLPaMbTpWrvWqDqSlZ4AUrhHcWn5/nvmQET6rEHNp?= =?us-ascii?Q?rbNmiRVQgaXXIhSy/FDsvXzv76ei2IlpAhYW1LJ4LgMVtJ9ttJK/dG/qAxjd?= =?us-ascii?Q?7SGo3bI48RmlW/fIMjbLZm/Q2Erk9cAwnqqOfBvUpRsP1CDMfQj/5glaKHud?= =?us-ascii?Q?+5+YMnz373BycLKfYL43jKNuboN7L4o1mQ4q3og9121IHmFdBoiqnBRQug5c?= =?us-ascii?Q?/ZUQXGpZqw0DNV9sTqR67xlyYrxmzC95zQH+tmfPpCcKiqDXfPWmRIrYTIJd?= =?us-ascii?Q?wl2mRKJSFIWuzhwR7RcFCmRryKWRhL7lD1fouiL/RZqOt0VmMb//Nh1W5zqe?= =?us-ascii?Q?dtyUmZD17yUth3QHc+aEE4xXbDekLcp7HiWS3jmjUZlsXhKac+ZoYRbScym+?= =?us-ascii?Q?jU719nueW/n7eI88VwBpOv6v9zZgpmHfkqho7QVxIeqqwZXSBxn2otUeRD9q?= =?us-ascii?Q?baWRQMronvnrDkzVTh3PGmQh1i3nqexSpTGFGp/vosmrKX1eo+4GVDBnOYC8?= =?us-ascii?Q?hiwymGfGR7ej8mprwdQ4DCbMks6hBRHgTiOc+Tg+xfynqGiE1fz8VWQWOXq1?= =?us-ascii?Q?tbCCNzDA2SUs4aHG+UN5BYB6YIYgemY8v+g4ZYZnNzzRzrVvzbPly1qBfVPI?= =?us-ascii?Q?2xtyHz2stxAv6acDWASGNwzV0XxupODYiJDoYylfa0iamT49baIuSbCvHpC+?= =?us-ascii?Q?ZZzfV3CWnVWkbgz2SzbALNtZoLRXZEEOvdlfn3V6bkZ7l98Y5JkXj+O6DFHH?= =?us-ascii?Q?7Prl2lISaQXwVLRh/1jCceKhRv8oisoVse4LtHCI93pMGTaBDheofewaFWsJ?= =?us-ascii?Q?c2aSE+JXXKOaR1snQO36erCZBG7tAZC1pR+1LznfYMfT7DEd3JZqzuNSDlCR?= =?us-ascii?Q?gzm6+mwKRVWnh7zWMfn4kWIWvfAS927y/mrq+qw8gaxcgoOJnIT6Odq8lX/n?= =?us-ascii?Q?N9rczlkZWd3YuNNS7rNqAbuWLezhBuL7F2Z1sV/IDnV2Z/dOmvJmx+YX3jgI?= =?us-ascii?Q?iA8IRCA4iEDBUYY3yR0wJUm4fbvqh8IdeVkZrpiMUZDrit38YceyvbkR09kZ?= =?us-ascii?Q?eiGACzkqvqP5TErotLF+3O6CVQZSFsvi9XDLPL2V5CpaamPBBuPpDZWyd02O?= =?us-ascii?Q?YuSndh6huR1eT4GhYOuGSbhNTyX8yujQqIKKF8bq9GxyToF8DhCYd946/kME?= =?us-ascii?Q?Iw4BlDMJ5Tyxnc0j1eAIs8Ikqtx0fLUqfQz2C1GniPeJ78JJjMxLwEMdII85?= =?us-ascii?Q?VEMICuFVbLU7gXLm02VCVLgJ5dxyaJyXKO+nmRUq6exv5zTh7ClFlDQ2x+Mb?= =?us-ascii?Q?RM5j4/5QINTzucq3Q+bZbXTX0BBEwBwMiqPzMBIY8IKaBeF5myKW/Tb76PCd?= =?us-ascii?Q?K5YGql2Mk9mZlKUy0z4IYX4GS+Fxxle1oBQX602N7aQw367MoOZdlOE8lSEU?= =?us-ascii?Q?T7uk4X6/O17jwZjNwClHaDvCbUuOAuczHBF+ImDFGeOYhYUnnjkY6LYyS9hd?= =?us-ascii?Q?59vu2MFEQXCEKzqa4MI=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4358.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b83d138-3afc-46e0-f359-08daac3d5474 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 10:34:23.5656 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ELffysMwAJdlZA241Xg/NGPlR2Fev9/lxctBBjyCLdnIHeywujRXkpyldZu+itHmEyavcuGsio1zpWQ16163Lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7085 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_033430_635789_6A0C36E1 X-CRM114-Status: GOOD ( 25.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [AMD Official Use Only - General] > -----Original Message----- > From: Gupta, Nipun > Sent: 12 October 2022 11:04 > To: Marc Zyngier ; Robin Murphy > > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > gregkh@linuxfoundation.org; rafael@kernel.org; eric.auger@redhat.com; > alex.williamson@redhat.com; cohuck@redhat.com; Gupta, Puneet (DCG- > ENG) ; song.bao.hua@hisilicon.com; > mchehab+huawei@kernel.org; f.fainelli@gmail.com; > jeffrey.l.hugo@gmail.com; saravanak@google.com; > Michael.Srba@seznam.cz; mani@kernel.org; yishaih@nvidia.com; > jgg@ziepe.ca; jgg@nvidia.com; will@kernel.org; joro@8bytes.org; > masahiroy@kernel.org; ndesaulniers@google.com; linux-arm- > kernel@lists.infradead.org; linux-kbuild@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; kvm@vger.kernel.org; > okaya@kernel.org; Anand, Harpreet ; Agarwal, > Nikhil ; Simek, Michal ; > Radovanovic, Aleksandar ; git (AMD- > Xilinx) > Subject: RE: [RFC PATCH v3 4/7] bus/cdx: add cdx-MSI domain with gic-its > domain as parent > > [AMD Official Use Only - General] > > > > > > > > > +} > > > + > > > +static void cdx_msi_write_msg(struct irq_data *irq_data, > > > + struct msi_msg *msg) { > > > + /* > > > + * Do nothing as CDX devices have these pre-populated > > > + * in the hardware itself. > > > + */ > > > > We talked about this in a separate thread. This is a major problem. > > We discussed this further with the hardware design team and now have the > correct and complete understanding here. As the CDX devices are FPGA > based, they don't exist yet, so it would be possible to construct them in such > a way that the eventid is programable. > > To make it generic for CDX devices, we have added a firmware API which > provide the mappings (MSI vector ID to eventID) to the fabric, that can be > referred by the device while generating the MSI interrupt. > > Also, there is an existing table to have GITS_TRANSLATOR iova address > (address in > msi_msg) for CDX devices, which can be programmed by the firmware. So, > providing IOVA address to device would also not be a problem here. > > We would be rolling out RFC v4 with these changes soon. > > Regards, > Nipun Just to be clear, there will be some HW limitations with the proposed solution, so let's just make sure that we're all OK with it. For the MSI EventID, the HW interrupt logic assumes the MSI write value is equal to the MSI vector number. However, the vector number is programmable for most (all) of the interrupt sources, which isn't exactly the same as saying EventID is programmable for a vector number, but can be used to emulate the desired behaviour, with a translation table in firmware. The limitation here is that we support at most 16 bits of EventID (and this still needs to be confirmed for all interrupt sources) As for GITS_TRANSLATER, we can take up to 4 different IOVAs, which limits us to 4 CDX devices (should be sufficient for current HW use-cases). Also, it means that the address part must be the same for all vectors within a single CDX device. I'm assuming this is OK as it is going to be a single interrupt and IOMMU domain anyway. Thanks, Aleksandar _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel