From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD53C2B9F4 for ; Thu, 17 Jun 2021 06:39:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CAE16101A for ; Thu, 17 Jun 2021 06:39:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CAE16101A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rWFQ35ARSPr8+cV1wEoIpAYuttkM9DySUDfdYAAEDIw=; b=KQyZlLdQqhZapn 7G/iXwfsJgrN+kxRRdsE5bUPwPxlYSMKMBdVFO0S37xSCzPp/6AgFXhd73fvqZw6OqMoWet7FMOSu ZLoDOlLFpPV9um4jh9zSnuBcStTgx4153C2wXStrKiBYH+ZXW10Sfb2Jgia3LxrmoKhgsUV9Yqxux l71hyZ1wxz/EcB8TEHuuyBzM9rYZJ1DcEu7FUv6vCnhwGCMcuozhf8y+601SRaqhMYhNcScfjeJve r2+Di3db9L2NYKYlxJWzcTjQDOhh+0TkcEg8mi1c3EgBDKwRZqtJ+wWMPqfVCptby6hnstngZR/a5 qNiXyyivXTDesMw3gxWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltleY-00994t-Fb; Thu, 17 Jun 2021 06:37:26 +0000 Received: from mail-mw2nam10on2064.outbound.protection.outlook.com ([40.107.94.64] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltleV-009948-3Y for linux-arm-kernel@lists.infradead.org; Thu, 17 Jun 2021 06:37:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ObjfOrHH84zFOruphDjlMWVfOkhXsa9pMqwuEt0gWV+dNZtjdIigcjPXuAZOoeOTFC6zigN8MdWDIGxpSnjgTh3bl+9dzOgvQpOCY64qgocOEMCRs1UEorey/bUhHWU+5sCa/q4ZJk18iHasOOnQaBuvenohK6iwS0N5Oh19bo7uRt8DxoWLbWa9ZkP+SApPi9gZSU9Fw7dmUyFwCKRXCZ+bgWc0RjzEPKNfjJrTsQNXtX2Wn+ksqDsQVPY3kOQht3Hu6XTS4BfkoAyZ9kWavKClOzBaufq9/zZiVdol+Qjawa4Sp9VosAArQ6dnrh5uUejFWmKzEOEJ9lBiJFtfyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DhCxy/Oy0EA8PlGggQZ+buDPY3CS6r27/K3tyT/COnQ=; b=iyX3BPAKNkdV9l6ebmiMs46FV0/Agq5MvGVISQlrpuYuPqlFfWPXBmGY7zWjPe6InPv2KOrzPXlX5uxwYvD8MpHIEzum8yh41RWCuYf/H1IxzhYMmepWG3NvZtkxiRmtfaHmhqPmq6wUwkbGqHPYX0URcPIMgN83zSjPMgL/cxgLkh+3T0F6Hiz+Dh2QJJ8Iz2Yn8jPFiT1VDfI+DptWH17Gf5JSSTaIvnivJQN34lWrq/vgW4Bm0jg5gmg7nkuxHCQXDLQJOcH1IOFLlrzfjcguzC97nQwpDcew9mWit/Qhu9r4OCmXSP5rqRICLe1rqogGAb19sc0wisa8tym4dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DhCxy/Oy0EA8PlGggQZ+buDPY3CS6r27/K3tyT/COnQ=; b=LWgyRbJoHmhf6vCd2HAquZjlqxOvrQc77QQXXy1SNSKT5nnEJHy3dBwCD/QBpIGPded1aXjdBfn9NlYODGjm/l1t+ycedEcLnQgJPdJAQVa1gcZFE9JRtDVrc/Jl0IZyBtkunzCY0koDCPxHYxxl4SxmIkctdEyIe8S0q/RvViw= Received: from MW2PR02MB3881.namprd02.prod.outlook.com (2603:10b6:907:11::31) by MWHPR0201MB3499.namprd02.prod.outlook.com (2603:10b6:301:77::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Thu, 17 Jun 2021 06:37:19 +0000 Received: from MW2PR02MB3881.namprd02.prod.outlook.com ([fe80::19b4:f7eb:1422:317c]) by MW2PR02MB3881.namprd02.prod.outlook.com ([fe80::19b4:f7eb:1422:317c%6]) with mapi id 15.20.4219.026; Thu, 17 Jun 2021 06:37:18 +0000 From: Sai Krishna Potthuri To: Andy Shevchenko CC: Linus Walleij , Rob Herring , Michal Simek , Greg Kroah-Hartman , linux-arm Mailing List , Linux Kernel Mailing List , devicetree , "open list:GPIO SUBSYSTEM" , git , "saikrishna12468@gmail.com" Subject: RE: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Thread-Topic: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Thread-Index: AQHXN1HnJ1dD/z2380CasZDNOXc+DarCQxoAgAQix4CAAHWwAIAAH53ggBdJowCAOdKhMA== Date: Thu, 17 Jun 2021 06:37:18 +0000 Message-ID: References: <1619080202-31924-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> <1619080202-31924-4-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=xilinx.com; x-originating-ip: [149.199.50.130] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e8aafad9-3264-4e8d-f3a4-08d9315a5ac4 x-ms-traffictypediagnostic: MWHPR0201MB3499: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YCZQ5FGbs/R/PkvAY0zzvnRyRaldKaD/X+4+FfPgzLjyjwFvbc8md5m8H9fOVYWbjPMRXPZaW4uk/lzLse3/3LJD+GlJkQnQwXpB3gTcL2dqWnOac2ZMPkLzVfZ+miJJVghuI3a/M5Xg0IXbpIBjGmqsTQm+ENJ/mpxDDvaLCjC2AYB9WDPB1E89VdkoliERo/jlL2MJ25PPfww5N9m46ZYTPhLinNSUNEGxpdFel/T1Hem3c5vpW/ivqiydtMyNlXcLtcXDzeSsIvnwmUfU043JL/cmSLuUsoChIhXAMM8am/RMrDTDytrzdLO4YkoB3BkTSKopCLmSWX297rx16xzWfh51fP7QP4sNrg+iPuznnZsmTYvLKadncExECQVsWEsGFDcfBOyK6sqMJCturuSboLrkusSNGVrQNUNPlDHcCM+xqBHSLky3PRZR4eEP5SvlKl9WYDnZskWxDXBqSKT1FfYGRm7HrlYK52Q33IYJjnx6lK8lGiViB3T/jOPgAy8CGctWe/+TY7aKk2mmLjC13TI+Z5PkXZLibJeurWBIO9hNU420ChLk8cixvaACF09upCeVmJzIU+mJH2bMdJy6Hu7luJYVFr9WUCrAVMg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR02MB3881.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(136003)(396003)(346002)(39860400002)(5660300002)(4326008)(7416002)(122000001)(86362001)(6916009)(83380400001)(26005)(71200400001)(53546011)(2906002)(52536014)(186003)(6506007)(54906003)(38100700002)(7696005)(8936002)(478600001)(8676002)(66446008)(66556008)(66476007)(66946007)(33656002)(316002)(9686003)(76116006)(64756008)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?emtLZWxJd2E3a0lIUUF2OFAwVU44TVVhZ3diR1Q5eUNhMGk3cWJSWlhRdS8v?= =?utf-8?B?QUxTeTlTSjgwbGJsSm4zRXVZSlZkOHpnbVRiU2FMNVFpQ0l4dFgyZ1hCTVFI?= =?utf-8?B?OW9lQ2M2OXNmMUlRcGNYL0Nzbmdac01jS2ZBUVBDOElFd05MOU1aSzNaTnhV?= =?utf-8?B?Vm5HMWF2SWdtSmlBWjk5a1o5dE1teWk5VHVNNzdtS0NIVzM5emVLWkJFWTRK?= =?utf-8?B?bzc4QXFaVjlxYTVkTEFTbThCbURUakQzM0g4UkRtRWVqclFMSEphUlJsNUY5?= =?utf-8?B?NkIwSGNuY3lFeGt6TE5xZG5ScHpheEQ0clFJd00rMy9GS0R6SUowTytwR1RR?= =?utf-8?B?QnlhckJ1VTZETElmY1VraUNTaU5TeTliTUMwK01ZbWlSWE5LNCt5NjFmVmxm?= =?utf-8?B?aEJCYmtDOE5FVW9iYTlqU21YcUtkTWVYTm5vZmpieHFSNlZIZ3Z6KzNRVm1G?= =?utf-8?B?WTA1ZjZrSHZoYWFUd0prbGZkQUJVTC9vNXpOdlJBbFdGZDMxZ1UrVmVnRHJ2?= =?utf-8?B?K1lWd3dMTzFZcjNyQUkwOHBWV1NBS0xzRjF6STdtZ0RXd1pLWTlsVm90RDhX?= =?utf-8?B?dWl6ekMwUFQ4TlZHL2RuL2FMSVFnczFUa1RSL2FiTURac3c0c0M2eGJFSnJQ?= =?utf-8?B?TTRQek9kUjF3ckF6ZTV2SUVqbEdZaGVva1cwcU5wck1CdWlJSFRGaUY5V1Z3?= =?utf-8?B?anBhMFYrU211R3VDMW52Y2Ntb3U1Sk96cnZmM29hQUo3V0lEVkJGQWJGcGcx?= =?utf-8?B?TzBCb21TRitzakNERWl5ekdKRXpjQzh3ZHZlS3poZmdIRUk4akEyZzRMRmZJ?= =?utf-8?B?aStaakRTWUFURi84UWtnd2JabjZBS25mR3dZNFFyeHl2OS9wTXhhbE1lQjBF?= =?utf-8?B?MitUU2c3ZXJyWGVvYW14U1ZaTC82d3NIUEFSWGFiaVFXY2J2cWQxaEF4WXJC?= =?utf-8?B?MDQrUmw4VUt2bUwwVERwejZHTUg1MUNqYzQ0RDZ3K2tZYWNYNUhwWU9zdldI?= =?utf-8?B?OFN1aWQwNGY4WCtHWk85c3hkQjdQdUtjRXJuWVJNVWFzMVhTQmdLaGVyNTZH?= =?utf-8?B?SC84aU9TelNmNStsNllJVVk2UGxmTVJaT2cxSGcrbEQxa1drZEs2V2pkVmRn?= =?utf-8?B?TkJwTmlkVDZFMi9uVzArUXZuSGtabDl1Q1FVTUlZVUlPTTM4cmZpZGhtNXlT?= =?utf-8?B?SUtIZXdYRUNFQVZWaTJXelFvWGZob2cxQTFZdkl5d3dvekRteWFkdm9HTjF4?= =?utf-8?B?ajVNamJYK1BmT05YSm5jZEErbUdSTCtad3RRcHBMMmFGd1lrSUFaZ21QYWov?= =?utf-8?B?R2hHcWdyUEErTS8zaGsvdnJtaEQwYmZvekF2eGgyNk0ydUhBQUhRZit3aGlw?= =?utf-8?B?cFoydDVpN2VWRHpheEY1ZFBvUUNEMEtub2tnY2RkL1Y0U0RzbkE2bDlCejMz?= =?utf-8?B?N2F0YXovSVV1YTVteTkwRWk5Zm5hOXp1WGx3N1NDU3VjcTRjckZ5R29YZGF3?= =?utf-8?B?MjJJUUNhblRRVjBEaEU4TUVTUTlRNllOR1dQc1VYQzUrNTJnUU80YmJxcmlR?= =?utf-8?B?M1BFVmVncmREL2RmcVFXY0FtVUZIbWw5bmJQa1pIL0lFdkgrMjVBNzMwZS8y?= =?utf-8?B?OGN2N2NuUGVvVm1WdEVKNWozNE1oYlU4VGRRTDB3VUNtbytTQ0xsYWJMdU9T?= =?utf-8?B?NUpiOGNNVGoxNGF5UTJlYXNKUXhrdjZYSnlWTFI2SG9nVmx2MDRsN0NrQ21Q?= =?utf-8?Q?vWaSBKgJWnEaUyt8u2tmzFfjhQVQRB6ltO9+ZxU?= MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR02MB3881.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8aafad9-3264-4e8d-f3a4-08d9315a5ac4 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2021 06:37:18.7351 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FWAMgJOZLrHSyz5Hgub9tyqWnW9CbzhTYO3O6GPr7MOsJ5L84ZCjXvfu59zBvlZkQe2cyJqyTbZc90R18M5d5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0201MB3499 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210616_233723_192364_1E20C42B X-CRM114-Status: GOOD ( 26.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ping! > -----Original Message----- > From: Sai Krishna Potthuri > Sent: Tuesday, May 11, 2021 6:08 PM > To: Andy Shevchenko > Cc: Linus Walleij ; Rob Herring > ; Michal Simek ; Greg Kroah- > Hartman ; linux-arm Mailing List kernel@lists.infradead.org>; Linux Kernel Mailing List kernel@vger.kernel.org>; devicetree ; open > list:GPIO SUBSYSTEM ; git ; > saikrishna12468@gmail.com > Subject: RE: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support > > Hi Andy Shevchenko, > > > -----Original Message----- > > From: Sai Krishna Potthuri > > Sent: Wednesday, April 28, 2021 11:04 AM > > To: Andy Shevchenko > > Cc: Linus Walleij ; Rob Herring > > ; Michal Simek ; Greg Kroah- > > Hartman ; linux-arm Mailing List > > ; Linux Kernel Mailing List > > ; devicetree > > ; open list:GPIO SUBSYSTEM > > ; git ; > > saikrishna12468@gmail.com > > Subject: RE: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver > > support > > > > Hi Andy Shevchenko, > > > > > -----Original Message----- > > > From: Andy Shevchenko > > > Sent: Monday, April 26, 2021 7:35 PM > > > To: Sai Krishna Potthuri > > > Cc: Linus Walleij ; Rob Herring > > > ; Michal Simek ; Greg Kroah- > > > Hartman ; linux-arm Mailing List > > > ; Linux Kernel Mailing List > > > ; devicetree > > > ; open list:GPIO SUBSYSTEM > > > ; git ; > > > saikrishna12468@gmail.com > > > Subject: Re: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl > > > driver > > support > ... > > > > > > > > > + ret = zynqmp_pm_pinctrl_get_config(pin, param, &arg); > > > > > > + if (arg != PM_PINCTRL_BIAS_PULL_UP) > > > > > > + return -EINVAL; > > > > > > > > > > Error code being shadowed. Instead check it here properly. > > > > > > > Are you mentioning the case where ret is also a non-zero? > > > > If yes, then I will update this check to if (!ret && arg != > > > > PM_PINCTRL_BIAS_PULL_UP) > > > > return -EINVAL; > > > > > > No, this is wrong in the same way. > > > > > > > ret non-zero case, we are handling at the end of switch case. > > > > > > I meant that you need to pass the real return code to the (upper) caller. > > Here we are checking for valid argument and not the return value of the > API. > > If the read value(argument) is not valid and return value of the API > > is zero (SUCCESS) then framework expects driver to be returned with > > '-EINVAL' and it is a legal error code in this case. > Do you agree on this? > I am ready with the other changes, will send out the patch to address your > comments. > > Regards > Sai Krishna _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel