From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6070EC433ED for ; Fri, 14 May 2021 15:16:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92BE8613F7 for ; Fri, 14 May 2021 15:16:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92BE8613F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yefCwDJbaNJdLPzcBQeJ9ymXXruJCz2JOXxB+Ya4INg=; b=eFwGuhiChZxz7ky34oKrQhHVf xGGO+5EH9YPGPp+ViFxrA7hVrNkW7nl4h5sgiCLjhS3b1cvJtB4PIOKUA+bCReBOmiZdK68Wkj/5H Q5MvbTTxwG2k/IpKz2LCjUWL+FMC4s/+k8i8lM6TpFXMwfLmIu62DtG8KUOg8rXnw99oMAip3apiL AZnM6lRXSfSfxlUpJo8y6WCrcgRCG421CGtE//OqG9ZFCfI1328oZdVlSWYGgBR2gqhgSOVYe2lz6 I4KVhJlin8MpHDhLTveHmO29A21yXSEcJQTagND8cQ3UrPFiIFMsCzc+MoNpXIOp/qZnaK9LK5FCz MdqdnBboA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhZWe-008NfE-A5; Fri, 14 May 2021 15:14:52 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhZWb-008Nf3-3D for linux-arm-kernel@desiato.infradead.org; Fri, 14 May 2021 15:14:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=/O7XbQLYw3LBv771OUD7/xWoT1k+8HEz3/8vhfahFfU=; b=Pzn9Qmg6d86K+t2xAvgtXXXrO2 NgIst+ioAw+05CNT/upI0BiXJg0La6F1JDsjNzQ6X0z7XvgCyFERNPxlaLlcHFqejGii3kPrM6Rpf vp44xkw+6DUenm6jjapGWOWjT9h0dOPmAxAQmKy4glJRpS3cKWpHOlfTnX4BwP1upK4xTikm9P9yA b3UXwxFQyjfuWu4QjqSX//1aBv3FjTqSyiOHV5XZ2dt5X/1LFqCxORrkPAla07c7QcnF3BVKGZgcL ixdgERPMKUuXzqG2oPI1sKxRc4b4x2GElTp2yyU9K87ramCcKSz0e+rW7RvSGmn3mDY0eEFbDpgXr mS8aMocA==; Received: from mail-dm6nam10on2135.outbound.protection.outlook.com ([40.107.93.135] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhZWX-00C4cU-UL for linux-arm-kernel@lists.infradead.org; Fri, 14 May 2021 15:14:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iUvLnbmHKmKQxCu/JZfF1hOlXKP0ZdO0veATG5JltT/3BFBytw9PZXEzrf+xbKbERCZXfJ9hAMRJ3aYg7OOg5Edq9hVitrM2KraQsjDXsx5hylVNEFnoWEIR88xvL6IcN9I2KgWxSVBpqZjxIsXkz5zqzK1fKYAcIwD/mKAxYZsC0pCuIlU0lUrZzMXUY0XquK6piBiCOnMfObcxVJU/vbWAIYSlwOZijp4GTpBHn5PkgW21scVHCDLGfXir240vXE/Hnkc12tq/PTv4Z/9eNBDeZRsM/Xi9qkil0pQ1C3XSEeADKrAmgr8eoiYhOyAnfNATE9djN9dKpvCLOG8i6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/O7XbQLYw3LBv771OUD7/xWoT1k+8HEz3/8vhfahFfU=; b=ByOdT5fDG+3iwQnkOF7msTK22LcXlemy/0ZS+mX7jR5lK5dVwgVsop9zR2lLjXrOadT671cnvVWaSDEq/sfDy8eN7DJrTiGOi8uePEXF+v8e3bTjkzwd3/5ENPZ9xGIvaIkuPKeIG/KA3UFUCkLGPqPjNR/bFx0qd9yMHMXdsNtsSbKA51WcfKueD3LcxnwC4ukUQS+NgFGBcgxxao715LwI1uFlraloMULr/U4UmnhGJmAq0oIeyRVzrIflwvtaZBzr6C00d6ML75Q8Z5wCM8ue9VHZFPWrmNF8Zu0tZizqjOCVfpgbskYr9llYKuPb3xZ33VR2kHQaPdeldDtgHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/O7XbQLYw3LBv771OUD7/xWoT1k+8HEz3/8vhfahFfU=; b=WBrOcSjL9WyztxX2DqvStGNNcAzYjmU2VHQKjWMaIdndxfH3u0/sNtAXpm0ViCGyYBFak5CB8MWgh+ez1aqW4Hw6wxufSt7mBd4/27VB+0AYAvCAZvryYEFxVc9qCtWNO88mEmTK5ESSJ9FxabBjz0czlRiLAw1+Uh1m69LFHYM= Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by MW4PR21MB1955.namprd21.prod.outlook.com (2603:10b6:303:71::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.7; Fri, 14 May 2021 15:14:42 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c30:6e04:401d:c31f]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c30:6e04:401d:c31f%4]) with mapi id 15.20.4129.023; Fri, 14 May 2021 15:14:42 +0000 From: Michael Kelley To: Mark Rutland CC: "will@kernel.org" , "catalin.marinas@arm.com" , "lorenzo.pieralisi@arm.com" , "sudeep.holla@arm.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-efi@vger.kernel.org" , "arnd@arndb.de" , "wei.liu@kernel.org" , "ardb@kernel.org" , "daniel.lezcano@linaro.org" , KY Srinivasan Subject: RE: [PATCH v10 2/7] arm64: hyperv: Add Hyper-V hypercall and register access utilities Thread-Topic: [PATCH v10 2/7] arm64: hyperv: Add Hyper-V hypercall and register access utilities Thread-Index: AQHXR1WfbpYqXyQd1EyiAk5Edk8t8qri8WSAgAAjnhA= Date: Fri, 14 May 2021 15:14:41 +0000 Message-ID: References: <1620841067-46606-1-git-send-email-mikelley@microsoft.com> <1620841067-46606-3-git-send-email-mikelley@microsoft.com> <20210514125243.GC30645@C02TD0UTHF1T.local> In-Reply-To: <20210514125243.GC30645@C02TD0UTHF1T.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=eedfe2eb-b6aa-4f1b-983e-22cf800d8e82; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-05-14T15:00:11Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [24.22.167.197] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 30e4fb4f-1023-442a-cfef-08d916eaffd9 x-ms-traffictypediagnostic: MW4PR21MB1955: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: trQd9T6alOYf49QTVm7tGcRaN1R0c3/POvdKpylhjVS4wUVXPc3Rf1xzi0fAQDQbsk6/fNGbY3jd2gt1Uf+HrfA7u+YAfdikEPgAVLthB24nGhj0kaLAro+zcJt5jz3Q47jbKkKpMhHDphyHQLYaVPG+vQD24FPLl7g9C1L67dTXRD/HCRYpa5HAEfeDrfgFgArr4o0zPWE33NZ+Z/dyvZb7G0EDDseAwiyjZR418IIjjoN3fp1SoNqT+b1SoIuHO+Nq40VR9VY6dOFfpNilZOjNMG9Zx44tqgpvgKVO9htHnU7Hcwg00qZ10FKdm2e6+C8iFq+wAhMnnSkAMOgNuzMg8qr+m7Q7zFrqeV6lQlpM2NISC3KrUhB0IoLxpN2r7OhyZeyeInTIwxSiEAK2uBjvqx5gnorC8P7K1UEHpT/PMnNQWAtz+30R6sx1gIGaxK4aQW8bjRT4sE2G38kG51IWHnNJO5zZWX5bOVgBM/m3ADxpJKMEFnetvGIkTO0KF4q+jKTlthfdmgr9VFzywxdUCqHeN/oUYw0WMXBN4YSyL3qz4dPZGXZQKumAAm6pDjv8EqX+XWU9U8oUTsHR3Rbps3CxurmAHRgup9Ike3s= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR21MB1593.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(82960400001)(82950400001)(26005)(316002)(4326008)(33656002)(66476007)(10290500003)(86362001)(6506007)(71200400001)(66446008)(38100700002)(2906002)(7696005)(107886003)(478600001)(5660300002)(64756008)(52536014)(76116006)(66946007)(9686003)(6916009)(8936002)(8990500004)(7416002)(54906003)(55016002)(66556008)(8676002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lGyU5ZxwN2KPMlOwZYenr1TJL+CbHNMQexpMmAPY+4rcT9oc+2M/qq6GDpne?= =?us-ascii?Q?tdM1xiaEDpv/Ag/jX+FsSA/0e/tSOpNoq6i7B7YBvKvET0HsHm92qVKL35nM?= =?us-ascii?Q?3yB09NcUNhKVaZYD3XWnkIMuU6vExVMWvoBXpWGSqnqeHWL1qaKlu3T8nqRD?= =?us-ascii?Q?yFBoDtE9SxSwFJlcELlxuc9GoC9im0Uuxunp9t69Uhakhl6fHzYZWh4+V2UV?= =?us-ascii?Q?jgZzGehWLSjMEZXTfyl1wn7ktdqYdHLkBzufNcDz2ufbJSDAREAXl/kIPSQb?= =?us-ascii?Q?09eUFSahZhXOQlI+6JK5aDA1KexUvoB+eWovDWjo3KwgcbBOrX08slUAJHKF?= =?us-ascii?Q?FWI+nVbhnzI9aWqhSU9+r15n0+wG5UpKb+czFtai8l58szYmbwnKtCM+l2pO?= =?us-ascii?Q?XysRR4Y6wMsve3LdvozIhXym6VmUzcZlDDVrBdJP7FYZeH7Ff6gakDXwhcVA?= =?us-ascii?Q?XC4Az32ax8qKBdmnUM93AMQ+0zllcdYqBkRjjTVHCYMAcQCvpWiwDfuSQexJ?= =?us-ascii?Q?Sfn1U1tzcyQQlnQ9tOQY5Aj6Puz93NKxehlq8eJX2ymW4ZDguBASmXSIDuSN?= =?us-ascii?Q?NHL5jW5g5I9ZdzI4tiI8myqK9MYohfMb0HQZHQZn8L07U93mBiS46C5PEEBn?= =?us-ascii?Q?2SgLq8tytD25SOdoUYtzmMZSQIOX2GLBRpgifRIhiSfkOqGkf+j/K+u+25OJ?= =?us-ascii?Q?hkumXk6AZRxuH9Cn4HuFS5Yh+WpiuII+bAnWVm0CBM8exe7bcJ0+uwJa0uCe?= =?us-ascii?Q?rJzzUIfKYKam4xxGd3RquHrMNq3I/faEgB1XqAEtUJpx4DCNiBXyyAF0VaBG?= =?us-ascii?Q?LTIqiFyxF674uduLDfJfUJH+6K6gnnp3wc6hcwtfOvs0J9Kd5i+7By1EXbi9?= =?us-ascii?Q?4VJl9kjGm97Xq0CR2A5WIhA9FqUO7h0SUd7iZk6NhIApZwmGXqMQ6/Frm5pO?= =?us-ascii?Q?TwaZO3M2E8bAkPLCx64Ut8rAoIpD6+at6ejS3lfY?= x-ms-exchange-antispam-messagedata-1: +f82z7U0EEwWNjZqFCvZ2MWVDg0ZidHyGgYXdILQDntX6TtZ4AuvUx/1aVtc099OhHHS7ghTewGrWjiGEPmO9mfilRw4d/YmPEOhoTmKDevklYUn2DPUIzjbIcyUVL4pBHEXN3Y0F1wMHFppfIHxLO933cHktXeIThuTsVUv8JrHWLcpcYFQXFAO9Zg2upEXhwfebHk5nJ7lC7Oh6qO373GppF1R0r4DHOH/KEh2+TvSKz7v9VKqVOLb+4MNxRp3TXRDR6TwCro+Bd2N3g2Hd9FCbz5nA+GUmLjb76PiAEqJn+VFRCX/+g5A5agMziqVcqAj+vYyMHnPn7yVkrIKUbF/ MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30e4fb4f-1023-442a-cfef-08d916eaffd9 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2021 15:14:41.9049 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FDPe5uNhThntJ7h1B1dUyRjyoBQUJ7s6AtnZBOXZoHM03Aw33uW25VKpnb6rAiERtgg7nbbGQFVK4LoDpJqcs6jOnVi3PqfI+W56lBKx5D4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR21MB1955 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_081446_144920_FDBA7160 X-CRM114-Status: GOOD ( 23.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Mark Rutland Sent: Friday, May 14, 2021 5:53 AM > > On Wed, May 12, 2021 at 10:37:42AM -0700, Michael Kelley wrote: > > hyperv-tlfs.h defines Hyper-V interfaces from the Hyper-V Top Level > > Functional Spec (TLFS), and #includes the architecture-independent > > part of hyperv-tlfs.h in include/asm-generic. The published TLFS > > is distinctly oriented to x86/x64, so the ARM64-specific > > hyperv-tlfs.h includes information for ARM64 that is not yet formally > > published. The TLFS is available here: > > > > docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/reference/tlfs > > > > mshyperv.h defines Linux-specific structures and routines for > > interacting with Hyper-V on ARM64, and #includes the architecture- > > independent part of mshyperv.h in include/asm-generic. > > > > Use these definitions to provide utility functions to make > > Hyper-V hypercalls and to get and set Hyper-V provided > > registers associated with a virtual processor. > > > > Signed-off-by: Michael Kelley > > Reviewed-by: Sunil Muthuswamy > > --- > > MAINTAINERS | 3 + > > arch/arm64/Kbuild | 1 + > > arch/arm64/hyperv/Makefile | 2 + > > arch/arm64/hyperv/hv_core.c | 130 +++++++++++++++++++++++++++++++++++ > > arch/arm64/include/asm/hyperv-tlfs.h | 69 +++++++++++++++++++ > > arch/arm64/include/asm/mshyperv.h | 54 +++++++++++++++ > > 6 files changed, 259 insertions(+) > > create mode 100644 arch/arm64/hyperv/Makefile > > create mode 100644 arch/arm64/hyperv/hv_core.c > > create mode 100644 arch/arm64/include/asm/hyperv-tlfs.h > > create mode 100644 arch/arm64/include/asm/mshyperv.h > > > +/* > > + * hv_do_hypercall- Invoke the specified hypercall > > + */ > > +u64 hv_do_hypercall(u64 control, void *input, void *output) > > +{ > > + struct arm_smccc_res res; > > + u64 input_address; > > + u64 output_address; > > + > > + input_address = input ? virt_to_phys(input) : 0; > > + output_address = output ? virt_to_phys(output) : 0; > > I may have asked this before, but are `input` and `output` always linear > map pointers, or can they ever be vmalloc pointers? > > Otherwise, this looks fine to me. > The caller must ensure that hypercall arguments are aligned to 4 Kbytes, and no larger than 4 Kbytes, since that's the page size used by Hyper-V regardless of the guest page size. A per-CPU 4 Kbyte memory area (hyperv_pcpu_input_arg) meeting these requirements is pre-allocated that callers can use for this purpose. On the x86 side there's also a similar hyperv_pcpu_output_arg, but there are no use cases for it on ARM64. Michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel