* [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock
@ 2022-08-24 8:04 Li Jun
2022-08-24 8:04 ` [PATCH 2/2] clk: imx: imx8mp: add shared clk gate for usb suspend clk Li Jun
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Li Jun @ 2022-08-24 8:04 UTC (permalink / raw)
To: abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel, festevam
Cc: linux-imx, robh+dt, krzysztof.kozlowski+dt, linux-clk,
linux-arm-kernel, devicetree
usb suspend clock has a gate shared with usb_root_clk.
Signed-off-by: Li Jun <jun.li@nxp.com>
diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h
index 9d5cc2ddde89..1417b7b1b7df 100644
--- a/include/dt-bindings/clock/imx8mp-clock.h
+++ b/include/dt-bindings/clock/imx8mp-clock.h
@@ -324,8 +324,9 @@
#define IMX8MP_CLK_CLKOUT2_SEL 317
#define IMX8MP_CLK_CLKOUT2_DIV 318
#define IMX8MP_CLK_CLKOUT2 319
+#define IMX8MP_CLK_USB_SUSP 320
-#define IMX8MP_CLK_END 320
+#define IMX8MP_CLK_END 321
#define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0
#define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] clk: imx: imx8mp: add shared clk gate for usb suspend clk
2022-08-24 8:04 [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock Li Jun
@ 2022-08-24 8:04 ` Li Jun
2022-08-25 20:34 ` Abel Vesa
2022-08-24 12:52 ` [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Li Jun @ 2022-08-24 8:04 UTC (permalink / raw)
To: abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel, festevam
Cc: linux-imx, robh+dt, krzysztof.kozlowski+dt, linux-clk,
linux-arm-kernel, devicetree
32K usb suspend clock gate is shared with usb_root_clk.
Signed-off-by: Li Jun <jun.li@nxp.com>
diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
index e89db568f5a8..5b66514bdd0c 100644
--- a/drivers/clk/imx/clk-imx8mp.c
+++ b/drivers/clk/imx/clk-imx8mp.c
@@ -17,6 +17,7 @@
static u32 share_count_nand;
static u32 share_count_media;
+static u32 share_count_usb;
static const char * const pll_ref_sels[] = { "osc_24m", "dummy", "dummy", "dummy", };
static const char * const audio_pll1_bypass_sels[] = {"audio_pll1", "audio_pll1_ref_sel", };
@@ -673,7 +674,8 @@ static int imx8mp_clocks_probe(struct platform_device *pdev)
hws[IMX8MP_CLK_UART2_ROOT] = imx_clk_hw_gate4("uart2_root_clk", "uart2", ccm_base + 0x44a0, 0);
hws[IMX8MP_CLK_UART3_ROOT] = imx_clk_hw_gate4("uart3_root_clk", "uart3", ccm_base + 0x44b0, 0);
hws[IMX8MP_CLK_UART4_ROOT] = imx_clk_hw_gate4("uart4_root_clk", "uart4", ccm_base + 0x44c0, 0);
- hws[IMX8MP_CLK_USB_ROOT] = imx_clk_hw_gate4("usb_root_clk", "hsio_axi", ccm_base + 0x44d0, 0);
+ hws[IMX8MP_CLK_USB_ROOT] = imx_clk_hw_gate2_shared2("usb_root_clk", "hsio_axi", ccm_base + 0x44d0, 0, &share_count_usb);
+ hws[IMX8MP_CLK_USB_SUSP] = imx_clk_hw_gate2_shared2("usb_suspend_clk", "osc_32k", ccm_base + 0x44d0, 0, &share_count_usb);
hws[IMX8MP_CLK_USB_PHY_ROOT] = imx_clk_hw_gate4("usb_phy_root_clk", "usb_phy_ref", ccm_base + 0x44f0, 0);
hws[IMX8MP_CLK_USDHC1_ROOT] = imx_clk_hw_gate4("usdhc1_root_clk", "usdhc1", ccm_base + 0x4510, 0);
hws[IMX8MP_CLK_USDHC2_ROOT] = imx_clk_hw_gate4("usdhc2_root_clk", "usdhc2", ccm_base + 0x4520, 0);
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock
2022-08-24 8:04 [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock Li Jun
2022-08-24 8:04 ` [PATCH 2/2] clk: imx: imx8mp: add shared clk gate for usb suspend clk Li Jun
@ 2022-08-24 12:52 ` Krzysztof Kozlowski
2022-08-25 20:34 ` Abel Vesa
2022-09-02 18:22 ` Abel Vesa
3 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-24 12:52 UTC (permalink / raw)
To: Li Jun, abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel, festevam
Cc: linux-imx, robh+dt, krzysztof.kozlowski+dt, linux-clk,
linux-arm-kernel, devicetree
On 24/08/2022 11:04, Li Jun wrote:
> usb suspend clock has a gate shared with usb_root_clk.
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] clk: imx: imx8mp: add shared clk gate for usb suspend clk
2022-08-24 8:04 ` [PATCH 2/2] clk: imx: imx8mp: add shared clk gate for usb suspend clk Li Jun
@ 2022-08-25 20:34 ` Abel Vesa
0 siblings, 0 replies; 8+ messages in thread
From: Abel Vesa @ 2022-08-25 20:34 UTC (permalink / raw)
To: Li Jun
Cc: abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel, festevam,
linux-imx, robh+dt, krzysztof.kozlowski+dt, linux-clk,
linux-arm-kernel, devicetree
On 22-08-24 16:04:22, Li Jun wrote:
> 32K usb suspend clock gate is shared with usb_root_clk.
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
>
> diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
> index e89db568f5a8..5b66514bdd0c 100644
> --- a/drivers/clk/imx/clk-imx8mp.c
> +++ b/drivers/clk/imx/clk-imx8mp.c
> @@ -17,6 +17,7 @@
>
> static u32 share_count_nand;
> static u32 share_count_media;
> +static u32 share_count_usb;
>
> static const char * const pll_ref_sels[] = { "osc_24m", "dummy", "dummy", "dummy", };
> static const char * const audio_pll1_bypass_sels[] = {"audio_pll1", "audio_pll1_ref_sel", };
> @@ -673,7 +674,8 @@ static int imx8mp_clocks_probe(struct platform_device *pdev)
> hws[IMX8MP_CLK_UART2_ROOT] = imx_clk_hw_gate4("uart2_root_clk", "uart2", ccm_base + 0x44a0, 0);
> hws[IMX8MP_CLK_UART3_ROOT] = imx_clk_hw_gate4("uart3_root_clk", "uart3", ccm_base + 0x44b0, 0);
> hws[IMX8MP_CLK_UART4_ROOT] = imx_clk_hw_gate4("uart4_root_clk", "uart4", ccm_base + 0x44c0, 0);
> - hws[IMX8MP_CLK_USB_ROOT] = imx_clk_hw_gate4("usb_root_clk", "hsio_axi", ccm_base + 0x44d0, 0);
> + hws[IMX8MP_CLK_USB_ROOT] = imx_clk_hw_gate2_shared2("usb_root_clk", "hsio_axi", ccm_base + 0x44d0, 0, &share_count_usb);
> + hws[IMX8MP_CLK_USB_SUSP] = imx_clk_hw_gate2_shared2("usb_suspend_clk", "osc_32k", ccm_base + 0x44d0, 0, &share_count_usb);
> hws[IMX8MP_CLK_USB_PHY_ROOT] = imx_clk_hw_gate4("usb_phy_root_clk", "usb_phy_ref", ccm_base + 0x44f0, 0);
> hws[IMX8MP_CLK_USDHC1_ROOT] = imx_clk_hw_gate4("usdhc1_root_clk", "usdhc1", ccm_base + 0x4510, 0);
> hws[IMX8MP_CLK_USDHC2_ROOT] = imx_clk_hw_gate4("usdhc2_root_clk", "usdhc2", ccm_base + 0x4520, 0);
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock
2022-08-24 8:04 [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock Li Jun
2022-08-24 8:04 ` [PATCH 2/2] clk: imx: imx8mp: add shared clk gate for usb suspend clk Li Jun
2022-08-24 12:52 ` [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock Krzysztof Kozlowski
@ 2022-08-25 20:34 ` Abel Vesa
2022-09-02 18:22 ` Abel Vesa
3 siblings, 0 replies; 8+ messages in thread
From: Abel Vesa @ 2022-08-25 20:34 UTC (permalink / raw)
To: Li Jun
Cc: abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel, festevam,
linux-imx, robh+dt, krzysztof.kozlowski+dt, linux-clk,
linux-arm-kernel, devicetree
On 22-08-24 16:04:21, Li Jun wrote:
> usb suspend clock has a gate shared with usb_root_clk.
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
>
> diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h
> index 9d5cc2ddde89..1417b7b1b7df 100644
> --- a/include/dt-bindings/clock/imx8mp-clock.h
> +++ b/include/dt-bindings/clock/imx8mp-clock.h
> @@ -324,8 +324,9 @@
> #define IMX8MP_CLK_CLKOUT2_SEL 317
> #define IMX8MP_CLK_CLKOUT2_DIV 318
> #define IMX8MP_CLK_CLKOUT2 319
> +#define IMX8MP_CLK_USB_SUSP 320
>
> -#define IMX8MP_CLK_END 320
> +#define IMX8MP_CLK_END 321
>
> #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0
> #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock
2022-08-24 8:04 [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock Li Jun
` (2 preceding siblings ...)
2022-08-25 20:34 ` Abel Vesa
@ 2022-09-02 18:22 ` Abel Vesa
2022-09-07 10:32 ` Abel Vesa
3 siblings, 1 reply; 8+ messages in thread
From: Abel Vesa @ 2022-09-02 18:22 UTC (permalink / raw)
To: Li Jun
Cc: abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel, festevam,
linux-imx, robh+dt, krzysztof.kozlowski+dt, linux-clk,
linux-arm-kernel, devicetree
On 22-08-24 16:04:21, Li Jun wrote:
> usb suspend clock has a gate shared with usb_root_clk.
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
Applied both, thanks!
>
> diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h
> index 9d5cc2ddde89..1417b7b1b7df 100644
> --- a/include/dt-bindings/clock/imx8mp-clock.h
> +++ b/include/dt-bindings/clock/imx8mp-clock.h
> @@ -324,8 +324,9 @@
> #define IMX8MP_CLK_CLKOUT2_SEL 317
> #define IMX8MP_CLK_CLKOUT2_DIV 318
> #define IMX8MP_CLK_CLKOUT2 319
> +#define IMX8MP_CLK_USB_SUSP 320
>
> -#define IMX8MP_CLK_END 320
> +#define IMX8MP_CLK_END 321
>
> #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0
> #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock
2022-09-02 18:22 ` Abel Vesa
@ 2022-09-07 10:32 ` Abel Vesa
2022-09-07 10:54 ` Jun Li
0 siblings, 1 reply; 8+ messages in thread
From: Abel Vesa @ 2022-09-07 10:32 UTC (permalink / raw)
To: Li Jun
Cc: abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel, festevam,
linux-imx, robh+dt, krzysztof.kozlowski+dt, linux-clk,
linux-arm-kernel, devicetree
On 22-09-02 21:22:08, Abel Vesa wrote:
> On 22-08-24 16:04:21, Li Jun wrote:
> > usb suspend clock has a gate shared with usb_root_clk.
> >
> > Signed-off-by: Li Jun <jun.li@nxp.com>
>
> Applied both, thanks!
As discussed in the thread [1], I dropped this patch from my tree for
now. You need to send a new version wil Fixes tag.
[1] https://lore.kernel.org/all/YxhxSdDGXfO%2F%2Fbgc@linaro.org/
>
> >
> > diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h
> > index 9d5cc2ddde89..1417b7b1b7df 100644
> > --- a/include/dt-bindings/clock/imx8mp-clock.h
> > +++ b/include/dt-bindings/clock/imx8mp-clock.h
> > @@ -324,8 +324,9 @@
> > #define IMX8MP_CLK_CLKOUT2_SEL 317
> > #define IMX8MP_CLK_CLKOUT2_DIV 318
> > #define IMX8MP_CLK_CLKOUT2 319
> > +#define IMX8MP_CLK_USB_SUSP 320
> >
> > -#define IMX8MP_CLK_END 320
> > +#define IMX8MP_CLK_END 321
> >
> > #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0
> > #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1
> > --
> > 2.34.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock
2022-09-07 10:32 ` Abel Vesa
@ 2022-09-07 10:54 ` Jun Li
0 siblings, 0 replies; 8+ messages in thread
From: Jun Li @ 2022-09-07 10:54 UTC (permalink / raw)
To: Abel Vesa
Cc: abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel, festevam,
dl-linux-imx, robh+dt, krzysztof.kozlowski+dt, linux-clk,
linux-arm-kernel, devicetree
Hi Abel,
> -----Original Message-----
> From: Abel Vesa <abel.vesa@linaro.org>
> Sent: Wednesday, September 7, 2022 6:33 PM
> To: Jun Li <jun.li@nxp.com>
> Cc: abelvesa@kernel.org; mturquette@baylibre.com; sboyd@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; linux-clk@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend
> clock
>
> On 22-09-02 21:22:08, Abel Vesa wrote:
> > On 22-08-24 16:04:21, Li Jun wrote:
> > > usb suspend clock has a gate shared with usb_root_clk.
> > >
> > > Signed-off-by: Li Jun <jun.li@nxp.com>
> >
> > Applied both, thanks!
>
> As discussed in the thread [1], I dropped this patch from my tree for now.
> You need to send a new version wil Fixes tag.
Thanks, I will resend those 2 patches with fix tag.
Li Jun
>
> [1]
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.
> kernel.org%2Fall%2FYxhxSdDGXfO%252F%252Fbgc%40linaro.org%2F&data=05
> %7C01%7Cjun.li%40nxp.com%7Cf62126a63a4442644c9308da90bc54ed%7C686ea1d3b
> c2b4c6fa92cd99c5c301635%7C0%7C0%7C637981435790610771%7CUnknown%7CTWFpbG
> Zsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> D%7C3000%7C%7C%7C&sdata=DRZzC7rKqNexnGN%2F%2FW5LXvhnhRwIN7CLC4KCu9z
> fTFA%3D&reserved=0
> >
> > >
> > > diff --git a/include/dt-bindings/clock/imx8mp-clock.h
> > > b/include/dt-bindings/clock/imx8mp-clock.h
> > > index 9d5cc2ddde89..1417b7b1b7df 100644
> > > --- a/include/dt-bindings/clock/imx8mp-clock.h
> > > +++ b/include/dt-bindings/clock/imx8mp-clock.h
> > > @@ -324,8 +324,9 @@
> > > #define IMX8MP_CLK_CLKOUT2_SEL 317
> > > #define IMX8MP_CLK_CLKOUT2_DIV 318
> > > #define IMX8MP_CLK_CLKOUT2 319
> > > +#define IMX8MP_CLK_USB_SUSP 320
> > >
> > > -#define IMX8MP_CLK_END 320
> > > +#define IMX8MP_CLK_END 321
> > >
> > > #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0
> > > #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1
> > > --
> > > 2.34.1
> > >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-09-07 10:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-24 8:04 [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock Li Jun
2022-08-24 8:04 ` [PATCH 2/2] clk: imx: imx8mp: add shared clk gate for usb suspend clk Li Jun
2022-08-25 20:34 ` Abel Vesa
2022-08-24 12:52 ` [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock Krzysztof Kozlowski
2022-08-25 20:34 ` Abel Vesa
2022-09-02 18:22 ` Abel Vesa
2022-09-07 10:32 ` Abel Vesa
2022-09-07 10:54 ` Jun Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).