From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1060AC32792 for ; Tue, 23 Aug 2022 10:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LwUo/YKSJs+9SCOey/KQU3dXSdyvIb8j3l3uTPpJ1MY=; b=yznUuwm+XuLMDW BzRi+978GmMqc6cyPmBf3nta7DUVIaJ2tKqRK3HwlF9n0j/3hszHu+6FRVgdmPRiClKyYZvX7/Lgw ZJ2UAEUxpxFtRN5ec2RIiUxGDjsCYFVsG2iXJAB4Mjn6x2sWYjQmtjtl711Qve8yvgnBhQM9NSwuf Ysef1F6TDqb+fLiy0nuWTEpnHsmmeY+sq0FzqYTJ/2HXyv+2O87XLSvYQzll1O6+bzqiafwjMadqG C4jKoyvLU4NMLSOUFBfM68EHh9znRDGqlwJQLHYBwbwqwLVVw+mJeMMYFuntMPTX/9mbKRwSHEPf2 1YiQlhJ1KwpciIo5YWdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQQuV-004orI-8b; Tue, 23 Aug 2022 10:13:27 +0000 Received: from mail-eopbgr00076.outbound.protection.outlook.com ([40.107.0.76] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQQs3-004o2o-By for linux-arm-kernel@lists.infradead.org; Tue, 23 Aug 2022 10:10:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PqLZjht1bqo353iMYR6m1xB5US6bSbKDzjjaDpyi7EDggILb3XkKC71inmRm77PFtn50unp6YcSiHu9FLEGQyG+S9+YYaIrFSv+1JXT6JQTPXI+rAzlKa6sSlul/adU7DepQwZryOwKRpblWrD8bDaWb2Rz7PNSzrJUPtRv2wUN0D+iU1wHhdXTQtmkFf/tKZLbQ0WrUrUkLQg3jaKl0MgXmPAnD05XuNou1ApOW8i1QmS/46q+B54r1SsVYZ7r5hiV/xHJziQdN8XdpCUNZ2/4LuhQOfYUFmJjbXbh4y1BX0mUozTd7mkiaxTb8u44tbk38qycRmoqZXIASTXYerQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xm9TadqP+hV7ia/vwQda8JVHWoH7Q+IKcmSUuorkm6M=; b=Sb9B9leoqhAg6DQZnRQSKEdcyfF33bWNEM5tkhJLDB4VHzz69PHvE+E2nvfoGa42Pssuq58UEN3aSqHf4rvVwtVWZWsiNx2+5QOpWpQOSMMUk9GX2Cb/n6eDc6ziX4NGghzL4CRG3hm8GsicNtBZXWGXiSjkbaMCft4EzUbBVMUuT4Drb6KzMcuz6myAjXNo0EnGzfoxFKbPu0aqG+hHaYdTUVSlIUMCAnFr/66y/4n7Zj/XxTCMWcKTfrdTPJMqBMpZ87hhEkxuF9XQ7/THTUb70U51AMl6UC5icsX7P4+8LxgnrHUfkUHzQPfCMh4KDNYc6Y+R30Wx/em5cKKYIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xm9TadqP+hV7ia/vwQda8JVHWoH7Q+IKcmSUuorkm6M=; b=Qf253P5J5U38P6/HIunr/dtqas2r1taXmcVKdvUfvnC11LiMvNvwzWsWi8HbSm8pGWZ6QoouACEWa5Honv2hnWB0mu7SZIn2u2adskeLD9+XQrTCblb5JF0UScWvpL+7eK1rk2pXMzHhL09XDxs4CaBiHMj75s2uJ2FOBKSabqA= Received: from PAXPR04MB8784.eurprd04.prod.outlook.com (2603:10a6:102:20f::23) by PAXPR04MB9304.eurprd04.prod.outlook.com (2603:10a6:102:2b6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.21; Tue, 23 Aug 2022 10:10:50 +0000 Received: from PAXPR04MB8784.eurprd04.prod.outlook.com ([fe80::60b7:af13:8472:2e8c]) by PAXPR04MB8784.eurprd04.prod.outlook.com ([fe80::60b7:af13:8472:2e8c%4]) with mapi id 15.20.5546.022; Tue, 23 Aug 2022 10:10:50 +0000 From: Xu Yang To: Peter Rosin , "heikki.krogerus@linux.intel.com" , "robh+dt@kernel.org" , "shawnguo@kernel.org" CC: "gregkh@linuxfoundation.org" , "linux@roeck-us.net" , Jun Li , "linux-usb@vger.kernel.org" , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [EXT] Re: [PATCH 2/4] mux: allow get mux_control from fwnode if of_node is NULL Thread-Topic: [EXT] Re: [PATCH 2/4] mux: allow get mux_control from fwnode if of_node is NULL Thread-Index: AQHYtfmQofyaU+wbwUiHXkJAjJESmq28BaqAgAA7kZA= Date: Tue, 23 Aug 2022 10:10:50 +0000 Message-ID: References: <20220822153517.3747679-1-xu.yang_2@nxp.com> <20220822153517.3747679-3-xu.yang_2@nxp.com> <6a3838dc-e979-2ef6-b332-92d5007fd41c@axentia.se> In-Reply-To: <6a3838dc-e979-2ef6-b332-92d5007fd41c@axentia.se> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57a0e84b-69d0-4243-73e6-08da84efc19b x-ms-traffictypediagnostic: PAXPR04MB9304:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6E2q5kg8aIKoYYllHxPN06R1YEUJUJUUbj37Ww2fB1NwWYRSDwwuJ34wMZfUvM1aviJi3kjIecEpaa8Mu1iqEy4ngbheTbnfU4zryZ66IYLtiQlepB5OTSKFNX/3MCpCHrCzCiM0wygP7ycfzn1Jhho2OkEz2YCTBRK+qVADLTLNMNJuS791jjQGztt/2rxsunJQWDczorIqHKYSpMNAvtfVlQPicnA6ZjHNBT6yHkQDO26viOGRRNF9Akol0n0OJKTNq8X4smPj0U8GNXw83msT0Oed8wC9EBM29aS+h9Hz0xB/NDiPeGtJnrmjgOA7rUbz7AqjCUKqmjFnRLtYDzB1Z3qLz6xsCcYx7vIsWDlN8Zp01FhVcmVqrWlWcnoJCbq369iHzuWdAUbUQX3Out713/mIN1AGS71HzNaC9a/NLXGykFaHmAECD1XL83fbf2e4D9gY+C11j9BSi52d7cm5zbHz0VeO1tgdYci681MWFk8IQx1TCzj0DYkIwJ4eVXNZrfcG8Cxwr9+LRZ7kVo6sJT3PWJWysIOjiC9w3N7Toqj/9xznPmpbJWWNDKd7tM4MbXbjJOuuMuH1TvLTOxnfB/zjlg8HbRhXRJhMKmiRtHbz2XwJo0A3Jkgm0+ZjpNpr/+H+z1FpsABSrd8e5lmwl581K7/HWk1JY8gcmHRi+QGRRkQ7aklXlL7tnq0HS1C7Q41N5pqQIZbpbh3kXzsyyvTLUKdfDWjToVlYZDdZUAfnOpWjsZTfELW/M0/ufD6kQjWcbrrlm1uAoDqzUw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8784.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(346002)(376002)(136003)(396003)(38100700002)(55016003)(83380400001)(38070700005)(110136005)(66446008)(76116006)(64756008)(66476007)(66556008)(71200400001)(54906003)(316002)(66946007)(8676002)(4326008)(2906002)(7696005)(26005)(9686003)(33656002)(6506007)(53546011)(86362001)(186003)(478600001)(41300700001)(52536014)(5660300002)(122000001)(8936002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cTNKMDFJSW5OZ3ptRHBmTjZna1U0Q1NSUE02ZHoxSXVqQ3NQS3UwSktaRGdV?= =?utf-8?B?bUFYd1VkQWpobTJxdVFGK1VWTTJnRjFnMldscGVtU1FsYXFrV053emNINFRk?= =?utf-8?B?azc2Q2xTdDhMd3hQQ0tuNkdCYzFtK0JpSGtnbjNBR3VINkt3bzQrSGxnamsx?= =?utf-8?B?V3NGSWJhMDc1WHp1bjV2L1QrM1R6QWhnNldwVElqSU1OVkRmaDllRUhZSGZT?= =?utf-8?B?YkZCQU1NNGZ2d1ZvU2tTcUsrN1NSdThSME1ndjNMdnFsYTAwR25MUUZQZ1c0?= =?utf-8?B?eFRVa05TOVpRM0M3WWhKOUIzam10M0w5ckZUWno2M3ZvbExYL2Q5VE50UnBj?= =?utf-8?B?WTBIVFVJaUNJZGlBUE4vN0hZNnlqUEg0VGgwdG1wNHZOcWtCMGhWdzlhenZK?= =?utf-8?B?YzFwWEUrR05MOFBEYUxKa0VVRTJyZkFKWDVvZm55blA5L0pZQUVQZFErcDJi?= =?utf-8?B?WEVXcnVXencyRzVYVjViWC9vY0p0R0lGOGZ1TUsrVDBtQmpBUEZ6cW1iVDV4?= =?utf-8?B?ZW9zZXhOTmw4WjZzenJTMGEyQXZaRXFUR3FaN1BNckRPcWdONXVsZVBnRXJw?= =?utf-8?B?em9pODFOZERNNlNuaTdJSDUwTGprV0RSeDgzd2VaMWMvR2I5eHBvc09qZHNR?= =?utf-8?B?b0pKYlFDVTl1K25Iem1scGRTTDBZVVlvc2F4K0tqVHFMa1ExSndqcG9qdE0z?= =?utf-8?B?T1BXaVh1ZTRuekNrclIyVXhkTlRPVWYyeTRIdWhIZFZnRmpDRHJEWjRHeXpZ?= =?utf-8?B?dk5OQmhadVlKcEllVHpNVFN3TEJFMHNiQUw1ZEJaNk5UaFhWdVFvYnBqWmtE?= =?utf-8?B?cEtmSTV1YXM2TWd0eGRFalFjYWRpNWJLZzM1R2lmb0JaUWhUQWg4MmUwN2Zk?= =?utf-8?B?UWx1NTg1MzZEQ1MwakltWGxBeGZIbWE5dUgwR2dQTVJCWkxJYnREcE9NaWtZ?= =?utf-8?B?QVF1TXVaVVU1ZldRT2xUbkx2NWgrdzQ2bjF6TU5kYWFvTENiT3hGdEo1ditX?= =?utf-8?B?LzFYZUpmRmxJR0lrcW44U1hkVEVLNmZKNFd0YW5MWk9hL3FhMjI5MVFFZlpr?= =?utf-8?B?RnBGdmxJcnltL2l5V3NDM1ljVXFGK0dvSVRlT2Q5dzYzWUpsWnZ0aEphYTR0?= =?utf-8?B?bXZoTlo0ZUh5RGlmb2hwcmZpKzRyTlBqNEkxSnB0L096YVBhb3V5L3NMcmdY?= =?utf-8?B?Y1Q5NnhBQUQyMFN3RE5qdThYNXlnL2tvSW05VjdZKzV4UzhRUlRZVVdOMTlu?= =?utf-8?B?SzRMaFpxdWpHaS9jTmRBTW4yc1FpcG5iRmV1VkhOUmpUMTc5VzVDejFQQnVU?= =?utf-8?B?QXRrMFZMem5PTFVpLzZLdDhPZDNjeGZMc0tPa3lSTWNRM2plYXl3TkZ2YkxK?= =?utf-8?B?M2tYcWxISG4zWCsvZUVTWnM4NjQzZDZBV1BQRVZMT1pPU09OUXdNL3BNR3ll?= =?utf-8?B?NFo0eTNQbi9iTEk5bklIeDRVTlhGTFdpc2pQK0VSUzBjenBNNkZkL1F0N1dD?= =?utf-8?B?eGtMWmFzSE02dUdYVzhFMFNmZTIyRkZpRXZGL0l6d21Wb05Ra2pkcDFnTEZj?= =?utf-8?B?aUpudkpWVkN0ZHNYUlJGcGllWkJGMG85Uk1GQzI3OTdoVjRla0JPbVFuVVpF?= =?utf-8?B?SmNnMC9jdWI4S1JmbWpVVVhLYUlwZHV2QUwwYlFibjR2MXNEQXdaemRNRzNO?= =?utf-8?B?YndQSTdwb3NmbC8rdXM5YldJcGZyc1JSbXFqWXRtVnc2N1A0emdkS0oxSnhF?= =?utf-8?B?WVErREtKT2tlWFFTWDFtRldMd1BmVmJtUEdvdksxYkdUZkRoU3FBRzVCYlgx?= =?utf-8?B?TEFtc3BSSTMveVM0aWMwd1AyMUs1aDhyaGx0d082MGZvRjVFeWdQOGY2VGVk?= =?utf-8?B?ZlE0SlBoSlFlaDdrY1J1VVhDV2s0N3BaL1JmSGZTcWgyOEJnQmVRcU90WlpB?= =?utf-8?B?NVpqYXZTNzgzV1FSQlJGZFJrVG5DSjMzVG44Wi9BNzFLcEtMVVk0MGhKZ1pi?= =?utf-8?B?M25ZdTc5dGxZLzZPOE0zUy9EYitOSTMyOC9ibUlVY1pvSDR0UTU0TlJmaHZL?= =?utf-8?B?aTdTZEo4d0dWRXBtMUpzeVl0SDdYMU5qTmpQK2pEcWtYKzZBUHhKWkVhNVB0?= =?utf-8?Q?ECGA=3D?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8784.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57a0e84b-69d0-4243-73e6-08da84efc19b X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2022 10:10:50.5962 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vsrN0DXAA1mZ/VxKT0ky4QrG3k6ZUY3FjioFIDjdyLSczFmLaPj850TRcPI2ieqep7DJIKUZb0mKLZdb+a+qnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9304 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220823_031055_462830_29307E73 X-CRM114-Status: GOOD ( 24.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peter, > -----Original Message----- > From: Peter Rosin > Sent: Tuesday, August 23, 2022 2:23 PM > To: Xu Yang ; heikki.krogerus@linux.intel.com; > robh+dt@kernel.org; shawnguo@kernel.org > Cc: gregkh@linuxfoundation.org; linux@roeck-us.net; Jun Li > ; linux-usb@vger.kernel.org; dl-linux-imx imx@nxp.com>; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org > Subject: [EXT] Re: [PATCH 2/4] mux: allow get mux_control from fwnode if > of_node is NULL > > Caution: EXT Email > > Hi! > > 2022-08-22 at 17:35, Xu Yang wrote: > > Since some devices may link fwnode to dev but doesn't link of_node, so > > here we could get mux_control from fwnode again. > > > > Signed-off-by: Xu Yang > > --- > > drivers/mux/core.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/mux/core.c b/drivers/mux/core.c index > > 49bedbe6316c..06d4e232e056 100644 > > --- a/drivers/mux/core.c > > +++ b/drivers/mux/core.c > > @@ -538,6 +538,9 @@ static struct mux_control *mux_get(struct device > *dev, const char *mux_name, > > int index = 0; > > int ret; > > > > + if (!np) > > + np = to_of_node(dev_fwnode(dev)); > > + > > if (mux_name) { > > if (state) > > index = of_property_match_string(np, > > "mux-state-names", > > This feels like a band aid. Is it not possible to convert the whole thing to the > fwnode interface? > Agreed. Actually, I'm hesitate to convert to fwnode interface due to not have a whole picture of all the mux controller users before. But now it should be okay to do so since all the existing drivers get mux controller based on platform device after my check. So, I will try to convert the whole thing to the fwnode interface in v2. Thanks, Xu Yang > Cheers, > Peter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel