linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: stern@rowland.harvard.edu (Alan Stern)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: ehci-platform: use helper variables in probe function
Date: Thu, 14 Jul 2016 20:58:19 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.1607142054450.28629-100000@netrider.rowland.org> (raw)
In-Reply-To: <CACna6rzdhCjHvTJSC-TCag7eCMPso-tGRRu3ajhs5jc7A6r2gQ@mail.gmail.com>

On Thu, 14 Jul 2016, Rafa? Mi?ecki wrote:

> > Okay except for...
> >
> >> -             priv->num_phys = of_count_phandle_with_args(dev->dev.of_node,
> >> -                             "phys", "#phy-cells");
> >> +             priv->num_phys = of_count_phandle_with_args(np, "phys",
> >> +                                                         "#phy-cells");
> >
> > Please indent continuation lines two tab stops beyond the original
> > line, to match the style in the rest of the source file.
> 
> I'm afraid this file doesn't have any consistent coding style for line breaks.
> 
> 1) dma_coerce_mask_and_coherent
> One extra tab after line break.
> 
> 2) devm_kcalloc
> Two extra tabs and 4 spaces. No real alignment noticed.
> 
> 3) devm_of_phy_get_by_index
> Two extra tabs
> 
> 4) devm_reset_control_get_shared_by_index
> Three extra tabs
> 
> With these pointed, do you still think I should use two extra tabs? If
> so, I'll send V2 as you suggested. Just let me know.

You're right, it's a mess.  If you send in an updated patch with two 
extra tabs, I'll create a style-only patch that fixes the other 
alignment issues.

Alan

PS: The probe routine in ohci-platform.c could use the same kind of 
local variables.  Would you like to send in patch for that routine too?

  reply	other threads:[~2016-07-15  0:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13  8:29 [PATCH] usb: ehci-platform: use helper variables in probe function Rafał Miłecki
2016-07-14 14:11 ` Alan Stern
2016-07-14 15:22   ` Rafał Miłecki
2016-07-15  0:58     ` Alan Stern [this message]
2016-07-15  5:05 ` [PATCH V2] " Rafał Miłecki
2016-08-09 13:59   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44L0.1607142054450.28629-100000@netrider.rowland.org \
    --to=stern@rowland.harvard.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).