From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4076C4CEC7 for ; Fri, 13 Sep 2019 15:36:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC13820693 for ; Fri, 13 Sep 2019 15:36:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S5+bEd7t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC13820693 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=4HiDHFwDxjhleokJDrMU6QZB7nMngTMyvY/XSpZot6Y=; b=S5+bEd7tWQlIUp RrTf/iTFomNmT26mjajfSJQOMn/fRmheJsydZyMSTTncA4pXHkw2TkCtvlHhIdmyND1AN8hxvXR2c ZWhYVccWKrwOCQRI3/iTkrBl1gAodCJk7f7A+oWQkB85Js7A0T4zerbFlsZQg7utSW8FcikeCGtM1 DbtJV5WthsLQX6cMqP31gsJKVRVAwcLoJ0xvQGeQ6WOAywjfOwKB+6vLl9cWW7bwdhkT8563xZDoz 0qSML8/1pg5SP+h6MlOk5arNvAJbtu19HJL7ChNjLQaXfSCr86hKYbDfloHVtnh/O8XjZkjLsZFcB WCFWCSR0JyLfQT2LqwtA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8nci-0004Yu-Um; Fri, 13 Sep 2019 15:36:37 +0000 Received: from iolanthe.rowland.org ([192.131.102.54]) by bombadil.infradead.org with smtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8ncf-0004XG-ER for linux-arm-kernel@lists.infradead.org; Fri, 13 Sep 2019 15:36:35 +0000 Received: (qmail 3387 invoked by uid 2102); 13 Sep 2019 11:36:30 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 13 Sep 2019 11:36:30 -0400 Date: Fri, 13 Sep 2019 11:36:30 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Paolo Bonzini Subject: Re: KASAN: slab-out-of-bounds Read in handle_vmptrld In-Reply-To: <6a0ec3a2-2a52-f67a-6140-e0a60874538a@redhat.com> Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190913_083633_640406_57E10B90 X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, x86@kernel.org, wanpengli@tencent.com, kvm@vger.kernel.org, rkrcmar@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com, hpa@zytor.com, khilman@baylibre.com, joro@8bytes.org, narmstrong@baylibre.com, mingo@redhat.com, Dmitry Vyukov , syzbot , devicetree@vger.kernel.org, syzkaller-bugs@googlegroups.com, robh+dt@kernel.org, bp@alien8.de, linux-amlogic@lists.infradead.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, jmattson@google.com, Greg Kroah-Hartman , USB list , linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, carlo@caione.org, Vitaly Kuznetsov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 13 Sep 2019, Paolo Bonzini wrote: > On 13/09/19 15:02, Greg Kroah-Hartman wrote: > > Look at linux-next, we "should" have fixed up hcd_buffer_alloc() now to > > not need this type of thing. If we got it wrong, please let us know and > > then yes, a fix like this would be most appreciated :) > > I still see > > /* some USB hosts just use PIO */ > if (!hcd_uses_dma(hcd)) { > *dma = ~(dma_addr_t) 0; > return kmalloc(size, mem_flags); > } > > in linux-next's hcd_buffer_alloc and also in usb.git's usb-next branch. > I also see the same > > if (remap_pfn_range(vma, vma->vm_start, > virt_to_phys(usbm->mem) >> PAGE_SHIFT, > size, vma->vm_page_prot) < 0) { > ... > } > > in usbdev_mmap. Of course it's possible that I'm looking at the wrong > branch, or just being dense. Have you seen https://marc.info/?l=linux-usb&m=156758511218419&w=2 ? It certainly is relevant, although Greg hasn't replied to it. There have been other messages on the mailing list about this issue, but I haven't tried to keep track of them. Also, just warning about a non-page-aligned allocation doesn't really help. It would be better to fix the misbehaving allocator. Alan Stern _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel