From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45D71C433EF for ; Fri, 8 Jul 2022 13:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PMFfrs/f4njU1pBpnjAccMd0KH1QkWGmiaPGy3UshKI=; b=eOhLEwcRz2I4+j +ptybfwG3Qut6igJfxq/PromVD8GlEzrcW5VS+aKBwVKLqER36GZ+jP4Mkbl3sxWLZOKcgRmkSc6H 5vpKPsN/SMeCYwVTKaDmoGtR0yj0XUBQTu/xH6mAlnirfEdGsVVcbesCFgiM7E7US9hdmDDE0W2/e eTPUv6tFaeo6VOeSu9Z7ikEkCTpC4PrzBDm3iPCtpAEuhAU5mrNEBO7XLtSLPXSwkD8ybMblIYBSO daqOR+g7paZvYRDfOYSp+zX9r6bofKXUmHArCTFPUQWanjFwZFhkjoG4fWvtUnYDcZH8Gm9saRS8i vLrwvndemvAR9O+6zzpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9o9D-003wUz-7a; Fri, 08 Jul 2022 13:35:55 +0000 Received: from mail-dm6nam11on2051.outbound.protection.outlook.com ([40.107.223.51] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9o99-003wSl-Rg for linux-arm-kernel@lists.infradead.org; Fri, 08 Jul 2022 13:35:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dfKDuuNbPNm6rIfl/+QtZwbThoUsAhBJQEySmFgChh0y3Wnf/eoKfC+nVbC2xdx3cGQfbuIyASM4lm2wwZECEBxqla32aCjpkY/WSUB97APsJUoSKts4aOCxnsrHlNxUGP0GYd0BdkmU5h5PHDDU8n/m/Ukz9DbNNKJRskkODAwNSWgngqiECyvOgbig0WbG98cRG1sY5GixyMw5dQGGQ/ZKIJ7ooubH+v+mQTiUKJHkIbaiGSI2meuMaz+eQATMsgWcwzeHl86vjHt6ASbchjZtzFk/v0VNMkGU8emElHJBLYoTGp6mL5egiAkgtQTORGUsxptSLiPj3Z9aPfINkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F0uYIkMqSzL0ZyNVzKeVc76uW01x8/K0C7AavcAkznU=; b=hz0KKqsBxFHERUCs10wFITCAsPdZ3BfSLmOB71yoNu9Dj4ZlnhWkxlUI+J3LnGKtk2kPKzREEXvJm/a6GEsH/5Ok893BWK2KAamy+83r+JI49HR2dc/esap8fT+0ZIupyGwtWYpcLMiFnSF5Ql4XAJKOzIQDweIdDj4zRaWfPZSYEpWevd1PV5fCeJn2ZqVXNlQbCljwbD8Ixr0fJBz8uX4zuobP2bafkNObxou2VMkZO1IaBtgP24oB4b/z0xY+iqgIg9x/Kl4scHGDb/HoY2SwVhqwjAR8QVyHBnwsaYECLg8AfaRJe1f9vtYgdN4de5rXsuG1SWMPghKq110kWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F0uYIkMqSzL0ZyNVzKeVc76uW01x8/K0C7AavcAkznU=; b=YVX8qiXLk/mLhUfQHnA2jx91hegA7eiUWv6KF7gASs+CmupBpVl3clIHg02qba/jU4FaxOnDARsu+SwB7XjD9jVOteai4gW1hvQg2vC1dTumgv12sy0PcNS9ZxUPlYB8m8b3OnMz30dGaKrtri97wMU342A/DaWOYlM0JpSlaMuHL6UZoPP+kZNEYNrlKM5HBD4MXk+Q/Wh1kX8YE9gIxj8vstZQX216HC/QlMpk0KiauakIOVHdWls8WSbVyfGXRTUyHuKpT3VpVkf6yAZnGzclX8f1M7menEDJwxuHAY0UK4C6CTx3nPA6dJSQ+8mM7iviy99Yu4mERNgNKsT8oA== Received: from SJ0PR12MB5676.namprd12.prod.outlook.com (2603:10b6:a03:42e::8) by DM6PR12MB4186.namprd12.prod.outlook.com (2603:10b6:5:21b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 8 Jul 2022 13:35:46 +0000 Received: from SJ0PR12MB5676.namprd12.prod.outlook.com ([fe80::6cdd:89c7:38f5:35b3]) by SJ0PR12MB5676.namprd12.prod.outlook.com ([fe80::6cdd:89c7:38f5:35b3%7]) with mapi id 15.20.5417.020; Fri, 8 Jul 2022 13:35:46 +0000 From: Besar Wicaksono To: Suzuki K Poulose , "robin.murphy@arm.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "mark.rutland@arm.com" CC: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "sudeep.holla@arm.com" , "thanu.rangarajan@arm.com" , "Michael.Williams@arm.com" , Thierry Reding , Jonathan Hunter , Vikram Sethi , "mathieu.poirier@linaro.org" , "mike.leach@linaro.org" , "leo.yan@linaro.org" Subject: RE: [RESEND PATCH v3 2/2] perf: coresight_pmu: Add support for NVIDIA SCF and MCF attribute Thread-Topic: [RESEND PATCH v3 2/2] perf: coresight_pmu: Add support for NVIDIA SCF and MCF attribute Thread-Index: AQHYhTLxxcyEPgAfs02S9hth/BTYH61y2SoAgAG5sCA= Date: Fri, 8 Jul 2022 13:35:45 +0000 Message-ID: References: <20220621055035.31766-1-bwicaksono@nvidia.com> <20220621055035.31766-3-bwicaksono@nvidia.com> <6c418ba1-36a6-1d54-6908-6235d8155904@arm.com> In-Reply-To: <6c418ba1-36a6-1d54-6908-6235d8155904@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 11d54675-b1e7-40bf-cea0-08da60e6c331 x-ms-traffictypediagnostic: DM6PR12MB4186:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2nedyCuvpuvvdZl+eKoDg+/YsCjc9Gz8ovfgrh6c5RiFoDqvar5Ofoop3emh5lTLfrc7dLRF5vXmkDTKogvtpIROfzA/jjRaecvPN8BevlJKJ6+2TcXlnmr+SJfxe6J0eKwt3IzejyLRx1aIsSqfynNEBZiFO2WZYlGFNoNgSpo7BibLW8dJbFQRyeLxl1znzqaxnLZX+KFWqkg6VDENubK3XNT18RUSRMABifBmXotpYuh6/wo/FhvByp5vGqpMRoRE8TinrLpS7Yb7nY4d/tonEOq9AfqIiEfng18Fa+IFiVyo/6y2RlcGyAb3z+e90uMjG9HcTvQCr0iO9voDSZlO4k0u7dZ+U4+75iVVU3NfFpprDFGnudnnlQ8x996O4lqBr8GqrhtfjzYqQklpKYKrqtXytW3qxMSeGyZJWcadbttQfFyXN1TLrtqJ7/H3ANoCVq/290fZic4NUf2FKXzYdLbJAxJNq/nPO3ApR93wPD5WqNMDG1bNEJqRbWjHhwmThhUJXV3ZV6U7uN6HsGqq1HHKYzzetZzjxZcPIc7voo02bbFByYvmT/m29GR+yZKdiwEi6FMpYhhcEOhbYHONnmDewBQ9nxVos0yUYcxhzT7xwNiiJxJsjMTK0mLFIJMChjv1N3Avf8nKKp+1oGLAhJFsL4M0Qj/AvMO3jy1eywpgO08KcM+L6FFc/4oInw+X4QkH0M+uCXvN0NdmAWvT8bDoH0pZVuJ5K5PBk1glxrZNntj/AUUupcUMfl2ckm2j/eEkCW+x9RC2uaOM5dr/gW6zqSZgG3rllDe9314yKsyLyKkcNp76bCML23mZ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR12MB5676.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(39860400002)(136003)(366004)(396003)(41300700001)(33656002)(5660300002)(38070700005)(38100700002)(52536014)(478600001)(7416002)(71200400001)(2906002)(8936002)(122000001)(316002)(30864003)(6506007)(66476007)(110136005)(53546011)(186003)(4326008)(86362001)(55016003)(54906003)(83380400001)(66446008)(7696005)(64756008)(66556008)(66946007)(26005)(8676002)(76116006)(9686003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S052TzZnZGthQko0alFTQjlFR1c1MW92L08wNmNsakZJekh1RDBVVFlzY3BT?= =?utf-8?B?UzZKVnJZOVhqSE92eGJPQUlKRDh2eXZLNkcvakpsVHhUaHZ2c1V6cGkwTFBF?= =?utf-8?B?RXNxM0R1VjBHTFhuNzNzelpNd0xKekxOZW16Y2o1bDhabVZPNnZnMWRYUWZp?= =?utf-8?B?ZHhLNVJDSHU2Y3BmeGNaR1JWOTJ1Z0hGdjUrckVEcEhlc1lneGhWZlFmUHFz?= =?utf-8?B?Qnh1SEdsTFJGL3QvZEoxalluYzFWTlBtc3NoVCtvWnFBWWpyczc5RzV5QnRQ?= =?utf-8?B?N3kvZFcwODZCYmEydnM1cWlTb0FiN1hpTTEzb2dLZG1mamFXRS82Y1RRYzk3?= =?utf-8?B?VXUrankyTWZSVnNtZXNOS09oL3hJQ1FtQWRPSnlhS3Z1Mlg1WnE2Nnh3TkM4?= =?utf-8?B?azlSbzlVVEV4OGxPVzN3dkZEN1hqY2lrOHBWbWdWTDN3R3hKVFBZc3M2SldE?= =?utf-8?B?K0NqTVlZVjBWai9mb3R3ZXdiRTRBWlpZWUNYR2Q2WDRGTWxTdGZQZzQ1aW1M?= =?utf-8?B?UVRFUUViaVdpRm9menRhNlFkd2FuME5VR3RKb3JrUWY3eUNnS1VIa2huUVNq?= =?utf-8?B?QzA0ak9mNVIvYWJUak5VcDJmL2Q4dEZENEZtSTBMNWswSWJlSk9jbW8zMFly?= =?utf-8?B?THVVNDhxU0FVNTVZT2RXc3IyUkFQWm4reVJTcWVKMVh4T2o3VzIxYkZDNEMy?= =?utf-8?B?Ujd1MUdiNmpTSXZab3NQbU5LNW9iTlFYdG9PVjMzZ3FkTXpGdXZXbDNRMk9X?= =?utf-8?B?MEpjazlZZ1lrQnFvRUR4OWNyWm5Wb1Ivb1FleCtsQnVHR3d0WUVZT1pvejhy?= =?utf-8?B?QnBzcjQyemw2Sk9IU3Q5Vm9jM3dVMWZZakVBbEgxMWJSN3pLNHFYYlN4TTlw?= =?utf-8?B?dkhLbFFOdFo5cUN1Q3pvcmo5a29nWU5vWmRndWZtZmhWbStuT0dITiszODlP?= =?utf-8?B?aWxXMW1ZLzFVSEFWMS9YSEdBV3NXSDhLSk9ySUtrWUs2MW1FTGJieGVzU2x5?= =?utf-8?B?YzhaZkNEam90d3dCTUFrQXkxeFpKSnM0NEtkL1RxaWk4WVoyTzZ1UExYc09j?= =?utf-8?B?NWE4U0llN0E1MC9nUE05b2J4R2d5MHBZZ3p0cHFuR05uUHVXUzV2ZmNvTmdC?= =?utf-8?B?MzJpU2tzU2creEFMU3M3QnI1YWZKMHhqdXZadFZaMjIxUVcyOS9aeVkvYWNP?= =?utf-8?B?VUN1TThsWStKdnhCUHNVSk0wbVlsZmFSUUpKTk1Ba1JIU0tDUlJJWHVmUEhx?= =?utf-8?B?UmpFY3QvZ29YSVRFZDFXMUYxR3M3Y0J0c2FkRzRsWTUrZk9qWWdsYkplczYr?= =?utf-8?B?WXY3aXViQmFBK3ZGT0d0d1JBQlphSGRlcmFFRHJXczBzdmtxRzB1ejNNTmNQ?= =?utf-8?B?UGtsL3hvRmZhNnoydnZqQkthSDNPeElUaEN5NStwbFY3UlhUbHFiYVlRUzFk?= =?utf-8?B?aE9oUGpUcmJTVEhsTzgyWFFWSThvTHV6d3ZDSi9QMjdWRHFRWVE5K09ZTVl3?= =?utf-8?B?VXdvUjNoRjJuZ2hKQ1JtMUUzbWRrRkx2Y09mckN3NVl0WDBqR085akpOOWZJ?= =?utf-8?B?a2NrMnY4Y1dxMnJQK1Q4Z2RBOXpMcWZKVnloRnNrUHJPTGVLTmJaY3ZOSzE4?= =?utf-8?B?VFhFSU1FZ2QvNEVIVlRuU2QxSUFPeG5ROVlMM0FkV2xUZEozOHFrMVA0L092?= =?utf-8?B?VHFRcFlGZzdHYWlhRTJ1cWU4TkRUUisrbktSSW9PVEkyaHJmOXNZMFVKMzU3?= =?utf-8?B?OTREaVVBWkZkaG1XS3hreU5jb1RGZTVCcVV1REh5eVpmdTBBOUJROTNPd1J1?= =?utf-8?B?b3BRZFdoN2wyNGpGbUUxSGNaemptU1JKY21LNXVYRjc3SjF0aUg5eDQrSFFt?= =?utf-8?B?OVR3eVdwbnp5WTRGMklMVW5JTnVKTU5UcGt6d0hHejMrT1pqUHVmRzVvYUNG?= =?utf-8?B?WElsbDlLNzVFNlVzUmdZNnkvWGNZVXpvUWJaWGc2WmxTY0tUMk1vanRuT0E2?= =?utf-8?B?TVhtNWNQS2poOTFYWXJiREM5UTJaQnZPUk15R1c2Qi90dEZua3pNRnFvd0p5?= =?utf-8?B?Q0N3azNiOGEwUnlaMWlxQ3h3dW5UQ0tEY2t2elB2cE1RbDY1c3JUdHI2NmRP?= =?utf-8?Q?LyH9aLTPMHsd385QStJRZblsU?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB5676.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11d54675-b1e7-40bf-cea0-08da60e6c331 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2022 13:35:45.9443 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jq7n6GP6kJot/LYLFFvRg7htgLvlyXm6Iauvn7+kW1P+mmwrN+8GU607oxcsrJZupnaRMSd6S1LDxkLVXCZnlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4186 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220708_063551_986677_F307C698 X-CRM114-Status: GOOD ( 22.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Suzuki, Please find my reply inline. > -----Original Message----- > From: Suzuki K Poulose > Sent: Thursday, July 7, 2022 6:08 PM > To: Besar Wicaksono ; robin.murphy@arm.com; > catalin.marinas@arm.com; will@kernel.org; mark.rutland@arm.com > Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > linux-tegra@vger.kernel.org; sudeep.holla@arm.com; > thanu.rangarajan@arm.com; Michael.Williams@arm.com; Thierry Reding > ; Jonathan Hunter ; Vikram > Sethi ; mathieu.poirier@linaro.org; > mike.leach@linaro.org; leo.yan@linaro.org > Subject: Re: [RESEND PATCH v3 2/2] perf: coresight_pmu: Add support for > NVIDIA SCF and MCF attribute > > External email: Use caution opening links or attachments > > > On 21/06/2022 06:50, Besar Wicaksono wrote: > > Add support for NVIDIA System Cache Fabric (SCF) and Memory Control > > Fabric (MCF) PMU attributes for CoreSight PMU implementation in > > NVIDIA devices. > > > > Signed-off-by: Besar Wicaksono > > --- > > drivers/perf/coresight_pmu/Makefile | 3 +- > > .../perf/coresight_pmu/arm_coresight_pmu.c | 4 + > > .../coresight_pmu/arm_coresight_pmu_nvidia.c | 312 > ++++++++++++++++++ > > .../coresight_pmu/arm_coresight_pmu_nvidia.h | 17 + > > 4 files changed, 335 insertions(+), 1 deletion(-) > > create mode 100644 > drivers/perf/coresight_pmu/arm_coresight_pmu_nvidia.c > > create mode 100644 > drivers/perf/coresight_pmu/arm_coresight_pmu_nvidia.h > > > > diff --git a/drivers/perf/coresight_pmu/Makefile > b/drivers/perf/coresight_pmu/Makefile > > index a2a7a5fbbc16..181b1b0dbaa1 100644 > > --- a/drivers/perf/coresight_pmu/Makefile > > +++ b/drivers/perf/coresight_pmu/Makefile > > @@ -3,4 +3,5 @@ > > # SPDX-License-Identifier: GPL-2.0 > > > > obj-$(CONFIG_ARM_CORESIGHT_PMU) += \ > > - arm_coresight_pmu.o > > + arm_coresight_pmu.o \ > > + arm_coresight_pmu_nvidia.o > > diff --git a/drivers/perf/coresight_pmu/arm_coresight_pmu.c > b/drivers/perf/coresight_pmu/arm_coresight_pmu.c > > index ba52cc592b2d..12179d029bfd 100644 > > --- a/drivers/perf/coresight_pmu/arm_coresight_pmu.c > > +++ b/drivers/perf/coresight_pmu/arm_coresight_pmu.c > > @@ -42,6 +42,7 @@ > > #include > > > > #include "arm_coresight_pmu.h" > > +#include "arm_coresight_pmu_nvidia.h" > > > > #define PMUNAME "arm_system_pmu" > > > > @@ -396,6 +397,9 @@ struct impl_match { > > }; > > > > static const struct impl_match impl_match[] = { > > + { .pmiidr = 0x36B, > > + .mask = PMIIDR_IMPLEMENTER_MASK, > > + .impl_init_ops = nv_coresight_init_ops }, > > {} > > }; > > > > diff --git a/drivers/perf/coresight_pmu/arm_coresight_pmu_nvidia.c > b/drivers/perf/coresight_pmu/arm_coresight_pmu_nvidia.c > > new file mode 100644 > > index 000000000000..54f4eae4c529 > > --- /dev/null > > +++ b/drivers/perf/coresight_pmu/arm_coresight_pmu_nvidia.c > > @@ -0,0 +1,312 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. > > + * > > + */ > > + > > +/* Support for NVIDIA specific attributes. */ > > + > > +#include "arm_coresight_pmu_nvidia.h" > > + > > +#define NV_MCF_PCIE_PORT_COUNT 10ULL > > +#define NV_MCF_PCIE_FILTER_ID_MASK ((1ULL << > NV_MCF_PCIE_PORT_COUNT) - 1) > > + > > +#define NV_MCF_GPU_PORT_COUNT 2ULL > > +#define NV_MCF_GPU_FILTER_ID_MASK ((1ULL << > NV_MCF_GPU_PORT_COUNT) - 1) > > + > > +#define NV_MCF_NVLINK_PORT_COUNT 4ULL > > +#define NV_MCF_NVLINK_FILTER_ID_MASK ((1ULL << > NV_MCF_NVLINK_PORT_COUNT) - 1) > > + > > +#define PMIIDR_PRODUCTID_MASK 0xFFF > > +#define PMIIDR_PRODUCTID_SHIFT 20 > > + > > +#define to_nv_pmu_impl(coresight_pmu) \ > > + (container_of(coresight_pmu->impl.ops, struct nv_pmu_impl, ops)) > > + > > +#define CORESIGHT_EVENT_ATTR_4_INNER(_pref, _num, _suff, _config) > \ > > + CORESIGHT_EVENT_ATTR(_pref##_num##_suff, _config) > > + > > +#define CORESIGHT_EVENT_ATTR_4(_pref, _suff, _config) \ > > + CORESIGHT_EVENT_ATTR_4_INNER(_pref, _0_, _suff, _config), \ > > + CORESIGHT_EVENT_ATTR_4_INNER(_pref, _1_, _suff, _config + 1), \ > > + CORESIGHT_EVENT_ATTR_4_INNER(_pref, _2_, _suff, _config + 2), \ > > + CORESIGHT_EVENT_ATTR_4_INNER(_pref, _3_, _suff, _config + 3) > > + > > +struct nv_pmu_impl { > > + struct coresight_pmu_impl_ops ops; > > + const char *name; > > + u32 filter_mask; > > + struct attribute **event_attr; > > + struct attribute **format_attr; > > +}; > > + > > +static struct attribute *scf_pmu_event_attrs[] = { > > + CORESIGHT_EVENT_ATTR(bus_cycles, 0x1d), > > + > > + CORESIGHT_EVENT_ATTR(scf_cache_allocate, 0xF0), > > + CORESIGHT_EVENT_ATTR(scf_cache_refill, 0xF1), > > + CORESIGHT_EVENT_ATTR(scf_cache, 0xF2), > > + CORESIGHT_EVENT_ATTR(scf_cache_wb, 0xF3), > > + > > + CORESIGHT_EVENT_ATTR_4(socket, rd_data, 0x101), > > + CORESIGHT_EVENT_ATTR_4(socket, dl_rsp, 0x105), > > + CORESIGHT_EVENT_ATTR_4(socket, wb_data, 0x109), > > + CORESIGHT_EVENT_ATTR_4(socket, ev_rsp, 0x10d), > > + CORESIGHT_EVENT_ATTR_4(socket, prb_data, 0x111), > > + > > + CORESIGHT_EVENT_ATTR_4(socket, rd_outstanding, 0x115), > > + CORESIGHT_EVENT_ATTR_4(socket, dl_outstanding, 0x119), > > + CORESIGHT_EVENT_ATTR_4(socket, wb_outstanding, 0x11d), > > + CORESIGHT_EVENT_ATTR_4(socket, wr_outstanding, 0x121), > > + CORESIGHT_EVENT_ATTR_4(socket, ev_outstanding, 0x125), > > + CORESIGHT_EVENT_ATTR_4(socket, prb_outstanding, 0x129), > > + > > + CORESIGHT_EVENT_ATTR_4(socket, rd_access, 0x12d), > > + CORESIGHT_EVENT_ATTR_4(socket, dl_access, 0x131), > > + CORESIGHT_EVENT_ATTR_4(socket, wb_access, 0x135), > > + CORESIGHT_EVENT_ATTR_4(socket, wr_access, 0x139), > > + CORESIGHT_EVENT_ATTR_4(socket, ev_access, 0x13d), > > + CORESIGHT_EVENT_ATTR_4(socket, prb_access, 0x141), > > + > > + CORESIGHT_EVENT_ATTR_4(ocu, gmem_rd_data, 0x145), > > + CORESIGHT_EVENT_ATTR_4(ocu, gmem_rd_access, 0x149), > > + CORESIGHT_EVENT_ATTR_4(ocu, gmem_wb_access, 0x14d), > > + CORESIGHT_EVENT_ATTR_4(ocu, gmem_rd_outstanding, 0x151), > > + CORESIGHT_EVENT_ATTR_4(ocu, gmem_wr_outstanding, 0x155), > > + > > + CORESIGHT_EVENT_ATTR_4(ocu, rem_rd_data, 0x159), > > + CORESIGHT_EVENT_ATTR_4(ocu, rem_rd_access, 0x15d), > > + CORESIGHT_EVENT_ATTR_4(ocu, rem_wb_access, 0x161), > > + CORESIGHT_EVENT_ATTR_4(ocu, rem_rd_outstanding, 0x165), > > + CORESIGHT_EVENT_ATTR_4(ocu, rem_wr_outstanding, 0x169), > > + > > + CORESIGHT_EVENT_ATTR(gmem_rd_data, 0x16d), > > + CORESIGHT_EVENT_ATTR(gmem_rd_access, 0x16e), > > + CORESIGHT_EVENT_ATTR(gmem_rd_outstanding, 0x16f), > > + CORESIGHT_EVENT_ATTR(gmem_dl_rsp, 0x170), > > + CORESIGHT_EVENT_ATTR(gmem_dl_access, 0x171), > > + CORESIGHT_EVENT_ATTR(gmem_dl_outstanding, 0x172), > > + CORESIGHT_EVENT_ATTR(gmem_wb_data, 0x173), > > + CORESIGHT_EVENT_ATTR(gmem_wb_access, 0x174), > > + CORESIGHT_EVENT_ATTR(gmem_wb_outstanding, 0x175), > > + CORESIGHT_EVENT_ATTR(gmem_ev_rsp, 0x176), > > + CORESIGHT_EVENT_ATTR(gmem_ev_access, 0x177), > > + CORESIGHT_EVENT_ATTR(gmem_ev_outstanding, 0x178), > > + CORESIGHT_EVENT_ATTR(gmem_wr_data, 0x179), > > + CORESIGHT_EVENT_ATTR(gmem_wr_outstanding, 0x17a), > > + CORESIGHT_EVENT_ATTR(gmem_wr_access, 0x17b), > > + > > + CORESIGHT_EVENT_ATTR_4(socket, wr_data, 0x17c), > > + > > + CORESIGHT_EVENT_ATTR_4(ocu, gmem_wr_data, 0x180), > > + CORESIGHT_EVENT_ATTR_4(ocu, gmem_wb_data, 0x184), > > + CORESIGHT_EVENT_ATTR_4(ocu, gmem_wr_access, 0x188), > > + CORESIGHT_EVENT_ATTR_4(ocu, gmem_wb_outstanding, 0x18c), > > + > > + CORESIGHT_EVENT_ATTR_4(ocu, rem_wr_data, 0x190), > > + CORESIGHT_EVENT_ATTR_4(ocu, rem_wb_data, 0x194), > > + CORESIGHT_EVENT_ATTR_4(ocu, rem_wr_access, 0x198), > > + CORESIGHT_EVENT_ATTR_4(ocu, rem_wb_outstanding, 0x19c), > > + > > + CORESIGHT_EVENT_ATTR(gmem_wr_total_bytes, 0x1a0), > > + CORESIGHT_EVENT_ATTR(remote_socket_wr_total_bytes, 0x1a1), > > + CORESIGHT_EVENT_ATTR(remote_socket_rd_data, 0x1a2), > > + CORESIGHT_EVENT_ATTR(remote_socket_rd_outstanding, 0x1a3), > > + CORESIGHT_EVENT_ATTR(remote_socket_rd_access, 0x1a4), > > + > > + CORESIGHT_EVENT_ATTR(cmem_rd_data, 0x1a5), > > + CORESIGHT_EVENT_ATTR(cmem_rd_access, 0x1a6), > > + CORESIGHT_EVENT_ATTR(cmem_rd_outstanding, 0x1a7), > > + CORESIGHT_EVENT_ATTR(cmem_dl_rsp, 0x1a8), > > + CORESIGHT_EVENT_ATTR(cmem_dl_access, 0x1a9), > > + CORESIGHT_EVENT_ATTR(cmem_dl_outstanding, 0x1aa), > > + CORESIGHT_EVENT_ATTR(cmem_wb_data, 0x1ab), > > + CORESIGHT_EVENT_ATTR(cmem_wb_access, 0x1ac), > > + CORESIGHT_EVENT_ATTR(cmem_wb_outstanding, 0x1ad), > > + CORESIGHT_EVENT_ATTR(cmem_ev_rsp, 0x1ae), > > + CORESIGHT_EVENT_ATTR(cmem_ev_access, 0x1af), > > + CORESIGHT_EVENT_ATTR(cmem_ev_outstanding, 0x1b0), > > + CORESIGHT_EVENT_ATTR(cmem_wr_data, 0x1b1), > > + CORESIGHT_EVENT_ATTR(cmem_wr_outstanding, 0x1b2), > > + > > + CORESIGHT_EVENT_ATTR_4(ocu, cmem_rd_data, 0x1b3), > > + CORESIGHT_EVENT_ATTR_4(ocu, cmem_rd_access, 0x1b7), > > + CORESIGHT_EVENT_ATTR_4(ocu, cmem_wb_access, 0x1bb), > > + CORESIGHT_EVENT_ATTR_4(ocu, cmem_rd_outstanding, 0x1bf), > > + CORESIGHT_EVENT_ATTR_4(ocu, cmem_wr_outstanding, 0x1c3), > > + > > + CORESIGHT_EVENT_ATTR(ocu_prb_access, 0x1c7), > > + CORESIGHT_EVENT_ATTR(ocu_prb_data, 0x1c8), > > + CORESIGHT_EVENT_ATTR(ocu_prb_outstanding, 0x1c9), > > + > > + CORESIGHT_EVENT_ATTR(cmem_wr_access, 0x1ca), > > + > > + CORESIGHT_EVENT_ATTR_4(ocu, cmem_wr_access, 0x1cb), > > + CORESIGHT_EVENT_ATTR_4(ocu, cmem_wb_data, 0x1cf), > > + CORESIGHT_EVENT_ATTR_4(ocu, cmem_wr_data, 0x1d3), > > + CORESIGHT_EVENT_ATTR_4(ocu, cmem_wb_outstanding, 0x1d7), > > + > > + CORESIGHT_EVENT_ATTR(cmem_wr_total_bytes, 0x1db), > > + > > + CORESIGHT_EVENT_ATTR(cycles, > CORESIGHT_PMU_EVT_CYCLES_DEFAULT), > > + NULL, > > +}; > > + > > +static struct attribute *mcf_pmu_event_attrs[] = { > > + CORESIGHT_EVENT_ATTR(rd_bytes_loc, 0x0), > > + CORESIGHT_EVENT_ATTR(rd_bytes_rem, 0x1), > > + CORESIGHT_EVENT_ATTR(wr_bytes_loc, 0x2), > > + CORESIGHT_EVENT_ATTR(wr_bytes_rem, 0x3), > > + CORESIGHT_EVENT_ATTR(total_bytes_loc, 0x4), > > + CORESIGHT_EVENT_ATTR(total_bytes_rem, 0x5), > > + CORESIGHT_EVENT_ATTR(rd_req_loc, 0x6), > > + CORESIGHT_EVENT_ATTR(rd_req_rem, 0x7), > > + CORESIGHT_EVENT_ATTR(wr_req_loc, 0x8), > > + CORESIGHT_EVENT_ATTR(wr_req_rem, 0x9), > > + CORESIGHT_EVENT_ATTR(total_req_loc, 0xa), > > + CORESIGHT_EVENT_ATTR(total_req_rem, 0xb), > > + CORESIGHT_EVENT_ATTR(rd_cum_outs_loc, 0xc), > > + CORESIGHT_EVENT_ATTR(rd_cum_outs_rem, 0xd), > > + CORESIGHT_EVENT_ATTR(cycles, > CORESIGHT_PMU_EVT_CYCLES_DEFAULT), > > + NULL, > > +}; > > + > > +static struct attribute *scf_pmu_format_attrs[] = { > > + CORESIGHT_FORMAT_EVENT_ATTR, > > + NULL, > > +}; > > + > > +static struct attribute *mcf_pcie_pmu_format_attrs[] = { > > + CORESIGHT_FORMAT_EVENT_ATTR, > > + CORESIGHT_FORMAT_ATTR(root_port, "config1:0-9"), > > + NULL, > > +}; > > + > > +static struct attribute *mcf_gpu_pmu_format_attrs[] = { > > + CORESIGHT_FORMAT_EVENT_ATTR, > > + CORESIGHT_FORMAT_ATTR(gpu, "config1:0-1"), > > + NULL, > > +}; > > + > > +static struct attribute *mcf_nvlink_pmu_format_attrs[] = { > > + CORESIGHT_FORMAT_EVENT_ATTR, > > + CORESIGHT_FORMAT_ATTR(socket, "config1:0-3"), > > + NULL, > > +}; > > + > > +static struct attribute ** > > +nv_coresight_pmu_get_event_attrs(const struct coresight_pmu > *coresight_pmu) > > +{ > > + const struct nv_pmu_impl *impl = to_nv_pmu_impl(coresight_pmu); > > + > > + return impl->event_attr; > > +} > > + > > +static struct attribute ** > > +nv_coresight_pmu_get_format_attrs(const struct coresight_pmu > *coresight_pmu) > > +{ > > + const struct nv_pmu_impl *impl = to_nv_pmu_impl(coresight_pmu); > > + > > + return impl->format_attr; > > +} > > + > > +static const char * > > +nv_coresight_pmu_get_name(const struct coresight_pmu > *coresight_pmu) > > +{ > > + const struct nv_pmu_impl *impl = to_nv_pmu_impl(coresight_pmu); > > + > > + return impl->name; > > +} > > + > > +static u32 nv_coresight_pmu_event_filter(const struct perf_event > *event) > > +{ > > + const struct nv_pmu_impl *impl = > > + to_nv_pmu_impl(to_coresight_pmu(event->pmu)); > > + return event->attr.config1 & impl->filter_mask; > > +} > > + > > +int nv_coresight_init_ops(struct coresight_pmu *coresight_pmu) > > +{ > > + u32 product_id; > > + struct device *dev; > > + struct nv_pmu_impl *impl; > > + static atomic_t pmu_idx = {0}; > > + > > + dev = coresight_pmu->dev; > > + > > + impl = devm_kzalloc(dev, sizeof(struct nv_pmu_impl), GFP_KERNEL); > > + if (!impl) > > + return -ENOMEM; > > + > > + product_id = (coresight_pmu->impl.pmiidr >> > PMIIDR_PRODUCTID_SHIFT) & > > + PMIIDR_PRODUCTID_MASK; > > + > > + switch (product_id) { > > + case 0x103: > > + impl->name = > > + devm_kasprintf(dev, GFP_KERNEL, > > + "nvidia_mcf_pcie_pmu_%u", > > + coresight_pmu->apmt_node->proc_affinity); > > + impl->filter_mask = NV_MCF_PCIE_FILTER_ID_MASK; > > + impl->event_attr = mcf_pmu_event_attrs; > > + impl->format_attr = mcf_pcie_pmu_format_attrs; > > + break; > > + case 0x104: > > + impl->name = > > + devm_kasprintf(dev, GFP_KERNEL, > > + "nvidia_mcf_gpuvir_pmu_%u", > > + coresight_pmu->apmt_node->proc_affinity); > > + impl->filter_mask = NV_MCF_GPU_FILTER_ID_MASK; > > + impl->event_attr = mcf_pmu_event_attrs; > > + impl->format_attr = mcf_gpu_pmu_format_attrs; > > + break; > > + case 0x105: > > + impl->name = > > + devm_kasprintf(dev, GFP_KERNEL, > > + "nvidia_mcf_gpu_pmu_%u", > > + coresight_pmu->apmt_node->proc_affinity); > > + impl->filter_mask = NV_MCF_GPU_FILTER_ID_MASK; > > + impl->event_attr = mcf_pmu_event_attrs; > > + impl->format_attr = mcf_gpu_pmu_format_attrs; > > + break; > > + case 0x106: > > + impl->name = > > + devm_kasprintf(dev, GFP_KERNEL, > > + "nvidia_mcf_nvlink_pmu_%u", > > + coresight_pmu->apmt_node->proc_affinity); > > + impl->filter_mask = NV_MCF_NVLINK_FILTER_ID_MASK; > > + impl->event_attr = mcf_pmu_event_attrs; > > + impl->format_attr = mcf_nvlink_pmu_format_attrs; > > + break; > > + case 0x2CF: > > + impl->name = > > + devm_kasprintf(dev, GFP_KERNEL, "nvidia_scf_pmu_%u", > > + coresight_pmu->apmt_node->proc_affinity); > > + impl->filter_mask = 0x0; > > + impl->event_attr = scf_pmu_event_attrs; > > + impl->format_attr = scf_pmu_format_attrs; > > + break; > > + default: > > + impl->name = > > + devm_kasprintf(dev, GFP_KERNEL, "nvidia_uncore_pmu_%u", > > + atomic_fetch_inc(&pmu_idx)); > > + impl->filter_mask = CORESIGHT_FILTER_MASK; > > + impl->event_attr = > coresight_pmu_get_event_attrs(coresight_pmu); > > + impl->format_attr = > > + coresight_pmu_get_format_attrs(coresight_pmu); > > Couldn't we make the generic driver fall back to these routines if a > "IP" pmu specific backend doesn't implement these callback ? > Yes, we can do that. I will add it on the next version. Regards, Besar > Thanks > Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel