From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF92EC432C1 for ; Wed, 25 Sep 2019 11:27:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82E7B21D7C for ; Wed, 25 Sep 2019 11:27:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UYJNxjud"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="aJRVVrNP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82E7B21D7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=df5ph4a33qPyCCnf72eb032D7vRtc8JSkDJeuHVpEYc=; b=UYJNxjudsrmgqr qVvcsTIMIiZrVHIlUUB+2b0/9vP1GkNj3TXe6lOjpr8+S/odUwoL7jRulKzUpB1cxmzugy6oKqQHN fG0hz3LYV505dvkADvDLGsyFwTaOfCs8EUgpvvRPp3jNZS20epJ34sWwlnCNR/w4d7RA9wLv+qxHT EKVmKmzdOWNO+j0ysFB5+vnNKJ6pBurotZwPvbaBbTOe7C4ultcG/Fgi/l9xrBbaheodrivmaEy7M g2bTQBq2gAgku5jhMxE3SsjKsESBPD9L3VTqjJmuEOAZWJwQuWktVilhiVL9MTduhlU3CJiAjKhWV zkfZI2x6/IUPhkS/eqDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iD5Rn-0001ge-HA; Wed, 25 Sep 2019 11:27:03 +0000 Received: from mail-eopbgr40088.outbound.protection.outlook.com ([40.107.4.88] helo=EUR03-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iD5RL-0001RA-Me for linux-arm-kernel@lists.infradead.org; Wed, 25 Sep 2019 11:26:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+F1+HPkS0uBnwSa3O/yIh6rbF4oGm94hQjYoMSLMUHCFwevgSoyyKzqDLlQJclqBIOCPf+bafshl0rax0HW3mrhpNI8aYAfBk8faszj3I2TmAou87/CdzuijpFzXQOOJ9zGqUItjfpun2bQ8sXau8YjFaRS2CHkxblIwzxLo3/CFj/3ISzK2CQ5RR/aAD1+UFavOkK4lXPtXhK558+C3IwstmkC1qZ0PqKe8aLtZPXxqe/vcampQFuUFOeY/TlhoTs4gnaOxgj6QxMFNerlFOh3cOFQUQWbINFymPqsXODedr+2neDcI8RK4MDsGGz6AjgR70h1dtNO9LLFk+1bcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9qO7ILLFmQNxwzN+9N1gQxBgSqJhTznjRVbG4QmHg8I=; b=Yhq8RKVi4oOyhp7nhO2Wrt9EjfEtFyzdRz99CnKOAe+LDzsVWzQlsFRAUMNn5o6nyQVNwz3y1kgiisHWxVrgoVsuXoKSJacvTjxnQHtPJuPy54vPrdWfHULuswRLeSG82dksu8S+UTRWZW4j5rpfRFgPJXPFVvA9wymgbc+hpwxPXYvtSAHJcAT4faBNkI1sVlGWOzKYlqbnesJTQmN8SXvOpgPBqhtBukdMnkT6IH5OH6ODdOavmYP7nxkROM986AeVwRSj+587taTG9atCLaMoUF33FO61xmXQOZAdSwITQp0ifz+YUk7SF+5Sxx9qjsaOpusjrBNIYgYW4dU4vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9qO7ILLFmQNxwzN+9N1gQxBgSqJhTznjRVbG4QmHg8I=; b=aJRVVrNPvgd3a7JsCGAHN9W0Vi+dN9gLZkKyYt6wObNTL8VmSfgG4qHJOuRV9NviwU7jMhxksf7pIC7fmSSvQJf/GMCBxKSmCZJib+67sRK2LqlCkffo7DHKLu4yjCOpdajUP9M0aNO9oa96S7T47bJvHv1EoVYnsTz6wmMcQWk= Received: from VE1PR04MB6638.eurprd04.prod.outlook.com (20.179.232.15) by VE1PR04MB6591.eurprd04.prod.outlook.com (20.179.234.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.15; Wed, 25 Sep 2019 11:26:31 +0000 Received: from VE1PR04MB6638.eurprd04.prod.outlook.com ([fe80::35d1:8d88:10f4:561]) by VE1PR04MB6638.eurprd04.prod.outlook.com ([fe80::35d1:8d88:10f4:561%5]) with mapi id 15.20.2284.023; Wed, 25 Sep 2019 11:26:31 +0000 From: Robin Gong To: Schrempf Frieder Subject: RE: [PATCH v5 11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm Thread-Topic: [PATCH v5 11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm Thread-Index: AQHVH2TUeqmuIEjDz0ugonhEiODBJqc7eN4AgAFtyHA= Date: Wed, 25 Sep 2019 11:26:30 +0000 Message-ID: References: <20190610081753.11422-12-yibin.gong@nxp.com> <29cf9f29-bdb4-94db-00b0-56ec36386f7a@kontron.de> In-Reply-To: <29cf9f29-bdb4-94db-00b0-56ec36386f7a@kontron.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yibin.gong@nxp.com; x-originating-ip: [116.231.57.185] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b506a70e-fd56-45df-ecc7-08d741ab36e1 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VE1PR04MB6591:|VE1PR04MB6591: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 01713B2841 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(136003)(376002)(346002)(39860400002)(189003)(199004)(5660300002)(6436002)(7416002)(229853002)(6916009)(6246003)(7696005)(4326008)(53546011)(6506007)(316002)(86362001)(476003)(7736002)(54906003)(33656002)(478600001)(14454004)(76176011)(256004)(64756008)(66446008)(11346002)(66556008)(66476007)(52536014)(99286004)(66946007)(4001150100001)(186003)(446003)(26005)(71190400001)(3846002)(6116002)(8936002)(76116006)(74316002)(81166006)(9686003)(2906002)(66066001)(102836004)(81156014)(25786009)(486006)(55016002)(305945005)(71200400001)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6591; H:VE1PR04MB6638.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vu4PvXgHjU7+P54i0i7kunDnpxdybREojATbBiZisR/aQheflKuyaYUCAo2W40tnqkAyDbfE9WM2N7X6e+nWLSMXNR0hQaK7N147H8PNPED6liutMzfm1kSRhxU44Bd8o1PvlOqRZRt4ot6b/DhZzvsw+MAKswoCOOU6kFSjL3NXlWYOXgeyabqR1KFMHfo7AGNEZxk2MD8yte2ysWxTYstcqx/PTplkGc/LP0iKK18/BBOzK/3X0NZBHbJ+PWmCvlYfCmHQ0tB/nwZX4aYoN1C7oE0lU8DIoWI4wW06s88t9ezUt06JsT60ShvLoySFGKI+EEtpZvL8JYoru5BRo+aMRBYXC18s3HfmmL1BUw57/v8C9BSN6uhYui8rKf1Mmls74HjmStq1KPExZWIpy9LltS+6rFcjQNoiuE1sDBk= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b506a70e-fd56-45df-ecc7-08d741ab36e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2019 11:26:30.9335 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d7kBpWi1ijmbmC86jqi8nrDmDfKleOPdhRHL8inl0UqBJOAqUr2HPqDpJV9JKWlby4qglXgTAXJMbx0CBM48Aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6591 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190925_042635_969550_7D30C65B X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "vkoul@kernel.org" , dl-linux-imx , Pengutronix Kernel Team , "dmaengine@vger.kernel.org" , "dan.j.williams@intel.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019-9-24 21:28 Schrempf Frieder wrote: > > Hi Robin, > > > From: Robin Gong > > > > Because the number of ecspi1 rx event on i.mx8mm is 0, the condition > > check ignore such special case without dma channel enabled, which > > caused > > ecspi1 rx works failed. Actually, no need to check event_id0/event_id1 > > and replace checking 'event_id1' with 'DMA_DEV_TO_DEV', so that > > configure > > event_id1 only in case DEV_TO_DEV. > > > > Signed-off-by: Robin Gong > > Acked-by: Vinod Koul > > I have a custom board with i.MX8MM and SPI flash on ecspi1. I'm currently > testing with v5.3 and as SPI didn't work, I tried two different things: > > 1. Removing 'dmas' and 'dma-names' from the ecspi1 node in imx8mm.dtsi, > to use PIO instead of DMA. This works as expected and the driver > boots with the following messages: > > spi_imx 30820000.spi: dma setup error -19, use pio > m25p80 spi0.0: mx25v8035f (1024 Kbytes) > spi_imx 30820000.spi: probed > > 2. Applying your patchset and use DMA. In this case, the flash also > works fine, but there are some error messages printed while booting: > > spi_master spi0: I/O Error in DMA RX > m25p80 spi0.0: SPI transfer failed: -110 > spi_master spi0: failed to transfer one message from queue > m25p80 spi0.0: mx25v8035f (1024 Kbytes) > spi_imx 30820000.spi: probed > > It would be great to get your patches merged and fix SPI + DMA, but for > i.MX8MM, we need to get rid of the error messages. Do you have an idea, > what's wrong? Could you check if the length of spi message is bigger than fifo_size during spi_nor probe? If yes, at that time maybe sdma firmware not loaded. if (transfer->len < spi_imx->devtype_data->fifo_size) > Thanks, > Frieder _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel