From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A844C433E0 for ; Mon, 10 Aug 2020 10:59:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBEAA20709 for ; Mon, 10 Aug 2020 10:59:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IR3QkzwV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="Z4dm7mSB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBEAA20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MVDtIJfnfWDRJB+0g9yHmebfIktxsl50Tx/nbHRrMAA=; b=IR3QkzwV4gZiMjQGPQG30/PsL GMhVv553fP1de21NvHOfSUn6k5gefGRmYpKOGcnqi07g1tQKDYlSTryOG9nKrAyGFlBJquP5jKghw V7+dbq/vPJXnEaVPv2b/e/YrjcTqxwrpFMWkO4EH2JegXfKHgwoIF6DGLJ2T8csmG0I6Y8/5h83Vn dqqy7oDWXCdbYj2q1oN2N0Fj/0IkLx+t3LToD9LJ/DvQa4AToOJk+k5NL0TD217Z+0QAiCgAbGnjK yTDwLWRhCCnUrpDR5ouWEmHcUCmQypwO/agsRlv7t1Bb/HOuFcGPBxdpF3nAjVynGHz76s0vt+9oQ 0Nz8ZGVow==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k55V6-0002F1-Hw; Mon, 10 Aug 2020 10:57:56 +0000 Received: from mail-eopbgr70042.outbound.protection.outlook.com ([40.107.7.42] helo=EUR04-HE1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k55V3-0002EK-44 for linux-arm-kernel@lists.infradead.org; Mon, 10 Aug 2020 10:57:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nI1vxZOfo8bVPn0p459ZTwjV2Qk5vbFPWqNyMWcj6+OMdnRnBwtXToy8z5dA0XRUSyeSflGT6NFQi6O/OrCtuJ7WYFCN9QMjaNnfBpe+yu7FUM6o45C/NCU38v4ZW6GYOPXSBAh26Cj2LA2+r20mqiLm7D4wodcUr6Cc7V4tG8ZEkC6GALNM6lv/E4SwQyzhovTPCb54vWgGnk5Naj8io+gfXZyS1q5TbzYuutc4PaXSbB94gqZ9DiG9hnLBmaXYcWyuoMdmuBiaWgx1hQz2Rk/o1NjrSQKWP38wMvIi2G41qjmOFUo+VwQr3A0pcYNyCRaa45vw79qac+FPVR+DFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UITveXB3IecJemRbOXRPmISdRN+7d717EyU+ydo3PDo=; b=W+3Zg2pJA4F1cpGftQ0xqGpI0rbk7Q9afvFZk0u5ONxeP/v+ttgCiAKWrpw+coFjbZslycb3arw/rSP+GF4SZZEevPucrVu8QfckU7Z6eBCS8DefBf4mbhxzFcNVOOM5JAejQS9jOWw8OPMQuSlwuXbldHMTCOdo9WWizieIzf6DPoKZRktBLrUpd/UHDJqXI9fVnGkbtMkw7jQhV0nLHO0m6EkGqTh7H8sbn2nWH+BDK1eq+ntepwwjOD/TpsgVSL9gQrAW8CLB4/SgmslZ0KGImJ1r9JX6vmz/KY6orlOHVLZZ0OkjCkN9BDdhfJDwyIfMrtQUGM6ol3dxE3GXXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UITveXB3IecJemRbOXRPmISdRN+7d717EyU+ydo3PDo=; b=Z4dm7mSBaBwkvxLAExfkil6M5cczOuBj/LihGti4oHzpVs6dOzlUJZKEPJX7QJTLPZiRkBS4i+aeiayS68WMEOKBWdt7EbIu3HdhE+XZ048jtu66mySnianHcaAiN8xPsU4jMltOJQjsgX8R5RWsR2yrVkGPnqyi6SCh6LhHEFs= Received: from VE1PR04MB6638.eurprd04.prod.outlook.com (2603:10a6:803:119::15) by VE1PR04MB6702.eurprd04.prod.outlook.com (2603:10a6:803:123::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Mon, 10 Aug 2020 10:57:42 +0000 Received: from VE1PR04MB6638.eurprd04.prod.outlook.com ([fe80::ad7f:d95a:5413:a950]) by VE1PR04MB6638.eurprd04.prod.outlook.com ([fe80::ad7f:d95a:5413:a950%3]) with mapi id 15.20.3261.024; Mon, 10 Aug 2020 10:57:42 +0000 From: Robin Gong To: Frieder Schrempf , "mark.rutland@arm.com" , "broonie@kernel.org" , "robh+dt@kernel.org" , "catalin.marinas@arm.com" , "vkoul@kernel.org" , "will.deacon@arm.com" , "shawnguo@kernel.org" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , "martin.fuzzey@flowbird.group" , "u.kleine-koenig@pengutronix.de" , "dan.j.williams@intel.com" , "matthias.schiffer@ew.tq-group.com" Subject: RE: [PATCH v11 12/12] dmaengine: imx-sdma: add uart rom script Thread-Topic: [PATCH v11 12/12] dmaengine: imx-sdma: add uart rom script Thread-Index: AQHWYaaLudfuBadzJkOiFFLip7fdHqkxDZIAgAA3DiA= Date: Mon, 10 Aug 2020 10:57:42 +0000 Message-ID: References: <1595616685-9987-1-git-send-email-yibin.gong@nxp.com> <1595616685-9987-13-git-send-email-yibin.gong@nxp.com> <89946dc6-6c0f-b3d5-9c9a-517f1ed7b5e1@kontron.de> In-Reply-To: <89946dc6-6c0f-b3d5-9c9a-517f1ed7b5e1@kontron.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kontron.de; dkim=none (message not signed) header.d=none;kontron.de; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.67] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: fb55b6dc-43e2-4a82-a3d0-08d83d1c34d9 x-ms-traffictypediagnostic: VE1PR04MB6702: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AR1k3PmDnIbOkzT7h5+/hvofwFeB62A+mrm4tgme0/cOFExjn4pFX9Lu87/O7mZhskSvwkFpT5kzJFVSlkVSjhUHp0+TGikoO11PUj3nU2cA9LKSp74d00Q4Nkj/zhxiHtMuT4VmjYN5uUkj40bRM1e+MD51QCOpTmpk0cpAG93omybGnzuKYJBO6QJqDUZmhu6eCVRSDofF8eI8m/qXHrRQEqlJ7fmBj6jcQxHzQF0/iavUilmG2XOu++8734tk1wjiHCnuW5Xy9t13Z/IJAo28ppFq+2Z8/+gmP/BLnd9ZuKlKmDEwcaEnVT0dDCrxK837XJqqmhHrV3O4xX6f5Adn6xGbNbLEmHBs/ds3/t/shsKdIDSFzFH7jmygqT8z x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6638.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(346002)(39860400002)(396003)(366004)(86362001)(64756008)(66476007)(66556008)(66446008)(66946007)(76116006)(52536014)(5660300002)(2906002)(71200400001)(478600001)(54906003)(110136005)(186003)(33656002)(7416002)(26005)(316002)(9686003)(7696005)(55016002)(8676002)(53546011)(6506007)(8936002)(4326008)(921003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 8V+Lh0dHriSmu4jKPiXLThyA85k5SJQP9TD+MoRhWQzesjXPLXoKbXpDKEWexH/jvb113TIQ29uYm1Q0Istm3wsM+bFdj0q9J783wdv752zNfXI2vEf854vRKvwTmYIpYoDkx5xr3kbWjiTYv6wDDcMYAXIADNkctzPQ5zkknYBdZXjSbPOy8YfS6CBT+p+SQNJyuxjeA/kw9LdNs2jhQA9NSB2Rz0LZTG0gwpkDPcE991elMWWTSIxlObviXqAV9aqd5/CqeNaqhApejabL+/yjd+TlPBfGNht4ZgsuCQXHQH1W2NNu/JLTf/kxonAIVC3M2jNLFXjAdT43oi+CXP1t9eH6cJ7DW0KG4zABHuYFv+YHCieNnBQvdKA5UBXWyXZXYXHF+a/TFGEvJz5sAf2nzVrwVmIcnhcF8MP4U8TdVEBv32hkQnfESR1k7gez5pdNGLZcDxQOpbrC1WWfWHCo7mEsdPDz3BVbEJC0uELjjGGCzqNPwttnoZEllGzl/G/gLvTwJ5LDnkLigaypP7wzlSdQeo18ICF1JIDY0GeoGAEEMcqKjuRwhWUERTNbWfAtqDJbIWwmqu7GKVW5ISSjizXL+7KplaAGmxgM0+FrM0JLYu9mvTZErwr2wRTkjZNtxxKa7Tu6cL8brRrz3w== MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6638.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb55b6dc-43e2-4a82-a3d0-08d83d1c34d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2020 10:57:42.7542 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gMv9ZoLEZhaZm45oVpUcS1psrYWjC2p1DqJO1g5WJ9X745/2NyWCIzRQO66gO2PF/R/8ozWxXgnE3tb2xsFYsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6702 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200810_065753_397179_AC35E83B X-CRM114-Status: GOOD ( 19.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/08/10 15:33 Frieder Schrempf wrote: > Hi Robin, > > This patch seems to break UART DMA in case the ROM firmware is used. In that > case sdma->script_number is set to SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1, so > the ROM scripts at uart_2_mcu_addr and uartsh_2_mcu_addr will never be > added in sdma_add_scripts() as they are now moved beyond the V1 max index. > > Reverting this patch fixes UART DMA with ROM firmware. > Can you please find a way to fix this or just drop this change? > Hi Frieder, Thanks for your report, could you try with the additional below patch? If that works, I'll merge it into next version. diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 5900e32..4db55b9 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1754,6 +1754,19 @@ static void sdma_add_scripts(struct sdma_engine *sdma, for (i = 0; i < sdma->script_number; i++) if (addr_arr[i] > 0) saddr_arr[i] = addr_arr[i]; + + /* + * get uart_2_mcu_addr/uartsh_2_mcu_addr rom script specially because + * they are now replaced by uart_2_mcu_ram_addr/uartsh_2_mcu_ram_addr + * to be compatible with legacy freescal/nxp sdma firmware, and they + * are located in the bottom part of sdma_script_start_addrs which are + * beyond the SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1. + */ + if (addr->uart_2_mcu_addr) + sdma->script_addrs->uart_2_mcu_addr = addr->uart_2_mcu_addr; + if (addr->uartsh_2_mcu_addr) + sdma->script_addrs->uartsh_2_mcu_addr = addr->uartsh_2_mcu_addr; + } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel