From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEF41C433B4 for ; Thu, 13 May 2021 03:51:37 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F65D61376 for ; Thu, 13 May 2021 03:51:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F65D61376 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hHH+d5i5yhUO6BIC3kRoRX1Vwa9KQyeVG0nEMUmwOdk=; b=FGid6mRfNpuRjVhCezaJ0AFp6 I31sW3vaIGH34aZCwUWl6w/Pld0lJjdcRWYsJMhSyj5oTw5RqshhZEm1d11w5cxnLT7jQz6KidEMW 78X2t+n0H6J8vhdJ0oLHA+txkH42tQABVGPvE9mUHY2hWMLsSefEiK1fpk1Z05w5nKYm1JyxjMkqN AjmHLzn3knFRbo3f8FJxkoAgo582EzplgqFRdTvCvP3pYD6w9Vy8FuNt3BtGEFYpj7d1w3PmsHcAw vo6oBWbmMiEaf3uquzz29lPtmlrX5gLx2CTu035RB6ZHyj2hCBhyx7EmjXW8aJFLRkaeb3iS8ygi0 hpqFgadvw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lh2Lt-004ekr-Uw; Thu, 13 May 2021 03:49:35 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lh2Lr-004eka-8V for linux-arm-kernel@desiato.infradead.org; Thu, 13 May 2021 03:49:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=y3dwxqGZSd/0X6zWGQ2cQ4XTcA8VzatuWZNaThnI9kI=; b=iYB/CBd7kX+TtNa1nYTuTPnDeM URy50SD60LZoSaCqc8GK4eGGROOPSuDPTocr2gV7OkR6OIzzE/WodGanixdTkYwPpZYbylZ+N4nSR 4GtKJmjZ1kgw7FVSYdfxw2tTHaI23mBIla7c3V8IB4H3iJRTEWW7Olio2zjx8H2ht1OStZwBJuQ02 T0F9yxZvBdvA5+EeBE9b/A53j6fOPbre2jiCIU0jOzeXstJSlYAVQw76o7BqxWbbYMPh5UdPD1NFg NeL187yiO511Er/y51phCLBI5dKrafJIewcfSl+UB3dYonqArKO1UwyQFQFVFH8RV4O+7yr8HM+wj 0vHIt3Lg==; Received: from mail-eopbgr30073.outbound.protection.outlook.com ([40.107.3.73] helo=EUR03-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lh2Ln-00AzUY-3T for linux-arm-kernel@lists.infradead.org; Thu, 13 May 2021 03:49:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mA5Fir1UrP1VLHpmcIR6Sfdbcq8osAocr0uwe74eOtcpOjehJBJwHP6fkU8+2dz3rSGCyFN+eZVpS9mL/H687qKXuAcYjh+bSCfNlsX2Sq7RYStJ/9XAtNkd8lZVjNrGutjanAxoCIWrpfNA9WwPfAA9N0TMnlcPd/5iopixZfhr7RZhLSOgXYcezKWpLQRRFQFTGqhgUg95qaNkJ2lXmSLnlQ3FfiHOo5gdPzpXiu/ItnZ1LlHOgsr5ZOJftiP7g8qaOtjDEEkDs0vKxbLli5JJ78QQ0KRIQtlU6u/iJtmJNTGZaoIuNheKECp4odaHbkWeTkzfQ3hooUkH3MeZkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y3dwxqGZSd/0X6zWGQ2cQ4XTcA8VzatuWZNaThnI9kI=; b=E8Vy3YiTL/iu9TnWyvS0PjWjf5Cn2wKBfF63ioRmsEuEErhu+ERk0aQuHhEgpimS1MIPlAqKoTO1J6ygyq0V2WuMIW2X8x7C/Ax9qAmeP6cDSmKOdYE4EFwV+H6CLxplcQYMpTqkWmd8ucE2092sxjdFu4CmtcF9QP1I9F2/KpHGTw0P8qVY0CiRR1wVvAzK5gF/AUiwqlPpTJKmQNfAprJgczbqSpbMu1hLvhxtBmniVYEsPe/HztkmZYX1X04NB8zcKpOW8DWcoCRr3QuZdHZJe1+5KPob2bihysex9LRswVeduw42x4MnSdWXfI9aXSyw7XDYUNuIMc5LqzBLQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y3dwxqGZSd/0X6zWGQ2cQ4XTcA8VzatuWZNaThnI9kI=; b=YgWxThHciiJyBg9tXlalhQzJ7iuMizHvmkP13mRye/Iou3+zqtQNuFFFq40bq9p2/OEoDqiATOTM6WKo1OxWz/anT27BKk4BFFmxCXDmf++bxEFSN5SCMoUrV7WX2u8Lp2GkjCzqDm53xdXQnmDeq6eY5j370styA3ywCOA7oZo= Received: from VE1PR04MB6688.eurprd04.prod.outlook.com (2603:10a6:803:127::25) by VI1PR04MB6286.eurprd04.prod.outlook.com (2603:10a6:803:f7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Thu, 13 May 2021 03:49:23 +0000 Received: from VE1PR04MB6688.eurprd04.prod.outlook.com ([fe80::bcfe:215c:1b66:6011]) by VE1PR04MB6688.eurprd04.prod.outlook.com ([fe80::bcfe:215c:1b66:6011%4]) with mapi id 15.20.4129.026; Thu, 13 May 2021 03:49:23 +0000 From: Robin Gong To: Guenter Roeck CC: "wim@linux-watchdog.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "kernel@pengutronix.de" , "linux-watchdog@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v1] watchdog: imx2_wdt: clear WDOG_HW_RUNNING before suspend Thread-Topic: [PATCH v1] watchdog: imx2_wdt: clear WDOG_HW_RUNNING before suspend Thread-Index: AQHXRhJF8Us7ySGmV06kW0fPHW7nEqrdp+uAgAIKKQCAADQMgIAA4GQg Date: Thu, 13 May 2021 03:49:23 +0000 Message-ID: References: <1620732032-7675-1-git-send-email-yibin.gong@nxp.com> <20210512141435.GL1333995@roeck-us.net> In-Reply-To: <20210512141435.GL1333995@roeck-us.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: roeck-us.net; dkim=none (message not signed) header.d=none;roeck-us.net; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.67] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bb9ae2f4-c92c-4695-930a-08d915c218f6 x-ms-traffictypediagnostic: VI1PR04MB6286: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5wv/58rwcWNc9pwbV1H0F2jVROB03u/Z3m3nEHj1ABlmDs/rNk82FTQwrNnU2lYHZxne86lXzyepXg3wor17AADUFziV9KzVRSKNPiExeJSH+K7Ar4DRChr71tddCE7CZUk+Hq7RWEUjbeUJN0gbMgg+Ba5TEMuayNkivdP6uUUL0PzTYbLkbkxiAqHZOU76T3SE4B7GeZW9/Xkutufb3yRc/HgNaCD6oV3mgJeDVg9deF2pvde9JrvNt+lnfXyLltA8lh5X0Zniiy9VS+oUju/94e5VOjPX70h+ROAB7TMDmrnafDM/cgGqwreTt0knBDRNpmeS1QrsCC5MDAfIffyU3ElO7AO82z1OMDafWVAEeFtzNOdpuCHV8MDrDXJwsVPK3Kfiigfrbh8uMZsx4UFAAo4FYYPKfDhLnTOZdZy8yUbuNgA/6rLbYX1VqlSRTtB/l9ewEy4EL71osBj1HV4cF7dZSzdV6NrqPRFqRIW3jymqM7D147TsWvltGYPJLIhO2Utgf+rcrkriRO90om2a+sWuURA93swvQRD8WkQyDvI1QmNv0RWH2rPcs50Ayp4599uOGijsW4vBmrjgCCuBO+nFrQGS633WZ2aMor0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6688.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(55016002)(76116006)(9686003)(83380400001)(478600001)(186003)(5660300002)(26005)(71200400001)(316002)(33656002)(8676002)(4326008)(6916009)(7696005)(2906002)(86362001)(8936002)(66476007)(66946007)(64756008)(38100700002)(66446008)(66556008)(122000001)(54906003)(52536014)(6506007)(15650500001)(53546011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?fYGvi3sFmCjb9QeCo1ATX34Z2nCYeWIuyWP87YP8R197oYy57yI93+bd9YLZ?= =?us-ascii?Q?H/sTJ1L7PGSCVo64enOU/buTbMWHbkE11To8umsYYMFfUjFGV0bMeVdP2zCC?= =?us-ascii?Q?yazHMyCRh2ztjO6ce+sNudz/Z7kE57D9hVNy7RPXhIOl8fYh5TSMkkK/1sb9?= =?us-ascii?Q?PfHj8q+damj9WyaytBTuPmsGMuoo2INyeX7RnzDbh3iiJFckiRgHMdUGCL/C?= =?us-ascii?Q?jpNKXzahARMHmNaFOWbLnxi2Z0ZBAkOA0ti16Oer6cbY7nQnxpjhFntm+UJU?= =?us-ascii?Q?2GxNMdh09VS4cNsevgzzQrxLZa1xSAWURr+h1nrlqdAUF9Ed7Rfp8+U02Zjo?= =?us-ascii?Q?YNzDAmDQXGnSFlweFhMdil6OQFhDpvmyhTm2qjC+YDFTcvWzqanCwXo30QOR?= =?us-ascii?Q?lKPggST6djcB4H938u0wESDB843Nzj7GzY1PypKYEWHgdCC6tnp8ET/wMnjA?= =?us-ascii?Q?YSb29gs6UDb99qoNRKwOJLOsobSZD4CP+5GRu3MsrrwU+b/jWbU8ngTpiO9T?= =?us-ascii?Q?LvCuH69TcCFQOIlwtZsN93KA1WSJp2Jjxn+SG03WqGqDwH44VPralm/FDjFh?= =?us-ascii?Q?jjMXi9N2H3kAg5IYw88BOcsafB8uIA0YfGQopcdKXT/5iSOexpLwv2lsqec+?= =?us-ascii?Q?bdqTytx3rvPGaITHCwsZH27ZC3U1yr6MbSoUwkOmlypnjAJ34Qa3gePdLigb?= =?us-ascii?Q?WMwcr89loDi2/XCUc2O6Z+3UmrVMN3b0IJ60Akz8tLzEDaBZwBi7zDyxRYTQ?= =?us-ascii?Q?f6FdC9l806rKtRAZy0xZgylPVfZEGpOjo+gX2hCQYsj+zzj/Q4dPwioCV4OL?= =?us-ascii?Q?sfIJmJORrexY8+RY+hQzsK9wuEfs+BQuh0WUnWN5iYGZ543ibMvcijMCJs0G?= =?us-ascii?Q?nIoH4VSk/kg+/Lu2UcaDUoHmMnovnenXEE5Vs1bzz9l9z+ucJBKakCz6Hefx?= =?us-ascii?Q?Det94qmbWntuNMD9ukTWJFP3+rzFUqlhmuK5gb5Vh1297A0CTrthDXiUPVOX?= =?us-ascii?Q?xWT5suVyRRzTmnQnt0pHyQ6s0Hca0u1O9MN1Oa51y0yJgj5uB5Ta9pdlA+OI?= =?us-ascii?Q?xOjc3ZMaRfQNV8fpC3C/yLlPYbVszqdidh/OwkFaOFlrohh8WS4wfmxdS5Ty?= =?us-ascii?Q?2i1SQVNVmfnaxHBEwsZbELwQ0Nq/njnNeb1H236eFKorr+DVveizeKft1tLa?= =?us-ascii?Q?pvPM0kUko1aQ/ulXbNw/4sSVLWrFlw0OjwSJR5tuSdXGJGLfqhbp55ArphCS?= =?us-ascii?Q?Jpg6IS7RUQ2jzXYmbm3Rk6Qq1VTlKvQqmwIRbNC5iCEu/DIlB0z74MGAVNuu?= =?us-ascii?Q?yOc=3D?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6688.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb9ae2f4-c92c-4695-930a-08d915c218f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2021 03:49:23.4948 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 54wdolHl1iMAnM7Rln2obQcQ2pAPIWVQqU4kVtu7Tojmoo/X+WER56QBUT2WWAFCN5xBdLYseI6O4x7mQtwdmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6286 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_204927_258745_6879E3D6 X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/12/21 22:15 Guenter Roeck wrote: > We can not assume that the situation is exactly the same for all drivers and > use a core flag to indicate some driver specific state just to avoid a > driver-internal flag. > > Either case, it looks like you are saying that the watchdog can be stopped after > all, by disabling its clock. > > > BTW, for i.mx2_wdt which watchdog can't be stop unless kernel enter > > into suspend, that seems like watchdog stop after suspend and clear > > WDOG_HW_RUNNING makes sense? > > > > Yes, if you make it official and add a stop function which disables the > watchdog by stopping its clock. Then the driver should not set > WDOG_HW_RUNNING in the first place, and use the normal mechanisms to > start and stop the watchdog. > That would include starting the clock in the start function, and stopping it in > the stop function. > Sorry, watchdog can't be stopped by disabling clock. The only way to stop watchdog is SOC enter Deep Sleep Mode(suspend) and stopped by HW, so the suspend flow looks like 'watchdog stop' which I though WDOG_HW_RUNNING makes sense. Okay, I will use internal flag instead of WDOG_HW_RUNNING in v2, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel