From: laurentiu.tudor@nxp.com (Laurentiu Tudor)
To: linux-arm-kernel@lists.infradead.org
Subject: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms
Date: Fri, 7 Apr 2017 14:00:58 +0000 [thread overview]
Message-ID: <VI1PR0401MB1856407F4A75878EA66AF51EEC0C0@VI1PR0401MB1856.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <87inmggxp7.fsf@concordia.ellerman.id.au>
-----Original Message-----
From: Michael Ellerman [mailto:mpe at ellerman.id.au]
Sent: Friday, April 07, 2017 4:22 PM
To: Laurentiu Tudor <laurentiu.tudor@nxp.com>; Horia Geant? <horia.geanta@nxp.com>; Herbert Xu <herbert@gondor.apana.org.au>; Scott Wood <oss@buserror.net>; Roy Pledge <roy.pledge@nxp.com>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; Cristian Stoica <cristian.stoica@nxp.com>; Dan Douglass <dan.douglass@nxp.com>; linux-arm-kernel at lists.infradead.org; Vakul Garg <vakul.garg@nxp.com>; linuxppc-dev at lists.ozlabs.org; David S. Miller <davem@davemloft.net>; Alexandru Porosanu <alexandru.porosanu@nxp.com>; linux-crypto at vger.kernel.org
Subject: Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms
Importance: High
Laurentiu Tudor <laurentiu.tudor@nxp.com> writes:
> On 04/05/2017 01:06 PM, Michael Ellerman wrote:
>> Laurentiu Tudor <laurentiu.tudor@nxp.com> writes:
>>
>>> Hi Michael,
>>>
>>> Just a couple of basic things to check:
>>> - was the dtb updated to the newest?
>>
>> Possibly not, it's an automated build/boot, I'll have to check what
>> it does with the dtb.
>>
>>> - is the qman node present? This should be easily visible in
>>> /proc/device-tree/soc at ffe000000/qman at 318000.
>>
>> No it's not there.
>>
>> That's running linux-next with:
>>
>> CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI=n
>>
>>
>> Does that mean I didn't update the device tree?
>
> I think so. Also, I just checked that the node is actually there by
> compiling p5020ds.dts and then decompiling the dtb.
> OK, I'll make sure I update the DTB.
>
> It will still be good if the code was a bit more robust about the qman being missing.
Totally agree. We should handle this error condition.
---
Thanks & Best Regards, Laurentiu
next prev parent reply other threads:[~2017-04-07 14:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 10:05 [PATCH 0/7] crypto: caam - add Queue Interface (QI) support Horia Geantă
2017-03-17 10:05 ` [PATCH 1/7] soc/qman: export volatile dequeue related structs Horia Geantă
2017-03-17 10:05 ` [PATCH 2/7] soc/qman: add dedicated channel ID for CAAM Horia Geantă
2017-03-17 10:05 ` [PATCH 3/7] soc/qman: export non-programmable FQD fields query Horia Geantă
2017-03-17 10:05 ` [PATCH 4/7] soc/qman: add macros needed by caam/qi driver Horia Geantă
2017-03-17 10:06 ` [PATCH 5/7] crypto: caam - avoid double inclusion in desc_constr.h Horia Geantă
2017-03-17 10:06 ` [PATCH 6/7] crypto: caam - add Queue Interface (QI) backend support Horia Geantă
2017-03-17 10:06 ` [PATCH 7/7] crypto: caam/qi - add ablkcipher and authenc algorithms Horia Geantă
[not found] ` <87vaqkvk6c.fsf@concordia.ellerman.id.au>
2017-04-04 12:42 ` [7/7] " Horia Geantă
2017-04-04 13:28 ` Laurentiu Tudor
2017-04-05 10:06 ` Michael Ellerman
2017-04-05 11:49 ` Laurentiu Tudor
2017-04-07 13:21 ` Michael Ellerman
2017-04-07 14:00 ` Laurentiu Tudor [this message]
2017-03-24 14:13 ` [PATCH 0/7] crypto: caam - add Queue Interface (QI) support Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0401MB1856407F4A75878EA66AF51EEC0C0@VI1PR0401MB1856.eurprd04.prod.outlook.com \
--to=laurentiu.tudor@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).