From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 488F2C32751 for ; Wed, 7 Aug 2019 16:42:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C0232229C for ; Wed, 7 Aug 2019 16:42:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NhV+VYpk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="sfzje78j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C0232229C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:Date :Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: List-Owner; bh=ckIS7Y4woOlMhSYNfBt9BbMzaWJqyvdN6ia0GlwuYlY=; b=NhV+VYpknOhzgT SFqucFioDHsPvOyLMwlh3/pGS4rDDmo4yvnhSKWONn9WSQ0sHRpFuqUaFX+8EIt6QcD/q05KtKUrq ji1vUnrCXZejhM1su5sGnSxmS4DiCVshkxgncpRHzY1CgUixxBMzeeKa1GTWwpAvLtPdGnBMfL2i1 qAYV9jOzfiTxnTvJ5HgT/SuLoQKNDpIDXA+anAQK49SRUP6dkz+n/FY3Qv1U8ZBPLWPu4Dvle1pKA V0/NdjwzKiXD5ALjZETnqNrdiT0aLAvNbzXbqLICqnAoCb8FIYezKkMeVQmGc/rS92eO6YPNbCXf0 804W7DLiaCrMhm10dJqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvP17-0005QI-Md; Wed, 07 Aug 2019 16:42:25 +0000 Received: from mail-eopbgr150080.outbound.protection.outlook.com ([40.107.15.80] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvP13-0005PQ-NU for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2019 16:42:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gfAljpL4mDeHv1c01nX+b263TsuhBnaCPk6bau3xOig870qeMTo8G6tIQxcgRonMcKdSnOBpYWF5yQF4+a73QAV9TTpsAfjdHZzb1yQQTcJKdtbszpLPMytIojmNkU7nYHA19v4QFV8FvpbKVtgV9+UW8T3woBysHKfWSKZjWyr76XRU8twIJgvY/NNUKBkuZim19IdmpsjaArfxQdLaYHWTRdvfVp2OItGXTCbOlcI6YjUfkuPnA+1MGpumDj3gUm5miDBASF2YcoZffY3V9jmWW4T5QxZKF5mPNp/C1FjIQEDADzszVq0xuYt0UHFV3FGL/lbiiP3g6xT4Hqd7Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6jJTcLgr82saZwMm28KzgPFSz4hKbfPLg6K4ApOKkpc=; b=amdC7UKWon0p0k3wQNfde3iaieSHJyUOGKdl6dXr+EBXoaVIyxfPRPaHEIh+Or2SI6TrL178L/jYzpE5BOfvbtGJ5vMTOn6Tm8oZ941lLadTyHi0av8yiHHkRv6id7XK4nnVgTw7bdqk9IeDGcgEXGBuNaa1LL7xn4IYSgAh1653fdXZfqxSGrjpoh222hsYqbbMNpI5jyatA/GmiUjCFQpvX9+xAHEbx6L/s8tDzZV5UZ42EkPiMVVwKOc3btrXYn7IllL8zeLZF4LaD3prXPPBGL5+yiTPKkfWcCmnjm/Hv4CTzR2aCHmJ3vB3qDQXNOj4h5MImlYFO+PKLjSHOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=nxp.com;dmarc=pass action=none header.from=nxp.com;dkim=pass header.d=nxp.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6jJTcLgr82saZwMm28KzgPFSz4hKbfPLg6K4ApOKkpc=; b=sfzje78jJjGyjs1WyPTn1B8FUohKh6C4m3hPMkH6NmMoL+cUpcz2wMqSkH0rX7MHiCxdHmBuSw+gG1ZLlL0SkdN5M17L+gw9Cywp7ALuwBFPU6LRnc+XvsxJGjKKbhYkzzRbV/3hc/laYOxgip2ivfznWqJsJqAPp+lkzsdwYaE= Received: from VI1PR0402MB2863.eurprd04.prod.outlook.com (10.175.20.18) by VI1PR0402MB3360.eurprd04.prod.outlook.com (52.134.1.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Wed, 7 Aug 2019 16:42:17 +0000 Received: from VI1PR0402MB2863.eurprd04.prod.outlook.com ([fe80::7de6:ea4b:9b5d:d023]) by VI1PR0402MB2863.eurprd04.prod.outlook.com ([fe80::7de6:ea4b:9b5d:d023%7]) with mapi id 15.20.2157.015; Wed, 7 Aug 2019 16:42:17 +0000 From: Stefan-gabriel Mirea To: "gregkh@linuxfoundation.org" Subject: Re: [PATCH 5/6] tty: serial: Add linflexuart driver for S32V234 Thread-Topic: [PATCH 5/6] tty: serial: Add linflexuart driver for S32V234 Thread-Index: AQHVTT8SPpHUwU0eqkG6Gc3hvK3zpw== Date: Wed, 7 Aug 2019 16:42:17 +0000 Message-ID: References: <20190802194702.30249-1-stefan-gabriel.mirea@nxp.com> <20190802194702.30249-6-stefan-gabriel.mirea@nxp.com> <20190805153114.GA16836@kroah.com> <20190806184042.GA26041@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=stefan-gabriel.mirea@nxp.com; x-originating-ip: [212.146.100.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8145bb2a-2585-4321-0549-08d71b563581 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR0402MB3360; x-ms-traffictypediagnostic: VI1PR0402MB3360: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 01221E3973 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(396003)(376002)(136003)(366004)(346002)(199004)(189003)(8936002)(66476007)(66556008)(64756008)(81166006)(66446008)(81156014)(86362001)(305945005)(2351001)(14454004)(5660300002)(25786009)(446003)(4326008)(26005)(229853002)(8676002)(1730700003)(6916009)(476003)(66946007)(486006)(53936002)(74316002)(186003)(99286004)(316002)(33656002)(76116006)(55016002)(256004)(66066001)(6116002)(6246003)(6506007)(53546011)(54906003)(6306002)(3846002)(7696005)(52536014)(6436002)(2501003)(7416002)(966005)(7736002)(478600001)(68736007)(9686003)(71190400001)(5640700003)(91956017)(102836004)(14444005)(2906002)(76176011)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB3360; H:VI1PR0402MB2863.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: h1B8WoIjgsnF79fvyEQ1n4NmqEch+dB3lEqkI2xGzlxWPQPNupewKqV+Xhp5WcSP2v118qP4R9e/LuQmomJQ3HOmXFWHnNkemlBiRJePKVBmnTcQR5S2g8DVrop5+6/o7UKCTA/imi9JATIqhB5LC2xnNHTkjHulZu6QeLGvUtOGw3+eaAIF3yBJvjf8nJsnCuwj/wogAU4MV6LPbnWM9X2jrM+PoOknNleyuUXk5ucJJGtzhviGwJsRjGOLPu6JqZXNfakls0ahaHd4NjJ6Af/T9/M9OWg3MAsxymFhYZoXYKdcaDiISsiNTddERv1IDoHRfjDtxmY6pnl1jRqELVWZeCz22tl4EGN4b8JFqCXAoLzX9ttJ4RQvAfuZPmAs35UTySdJUgGM3q1KSA5rRnL9W3vC4krbNMF5mcZpG4c= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8145bb2a-2585-4321-0549-08d71b563581 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2019 16:42:17.3610 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U6GzYRrtpcRqs+n1j0gsN24F+HBDXkxk3cxeQva7VvvCf4QNQf3wpU8xEGYbqVSp+7SejmBo4s+DrUpWW999wMM5vLWPLiyWpr6+/+ZCqA0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3360 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190807_094221_847853_BC707F0E X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "corbet@lwn.net" , "catalin.marinas@arm.com" , "linux-doc@vger.kernel.org" , Larisa Ileana Grigore , "linux-kernel@vger.kernel.org" , Leo Li , Cosmin Stefan Stoica , "robh+dt@kernel.org" , "linux-serial@vger.kernel.org" , "jslaby@suse.com" , "shawnguo@kernel.org" , "will@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/6/2019 9:40 PM, gregkh@linuxfoundation.org wrote: > On Tue, Aug 06, 2019 at 05:11:17PM +0000, Stefan-gabriel Mirea wrote: >> On 8/5/2019 6:31 PM, gregkh@linuxfoundation.org wrote: >>> On Fri, Aug 02, 2019 at 07:47:23PM +0000, Stefan-gabriel Mirea wrote: >>>> >>>> +/* Freescale Linflex UART */ >>>> +#define PORT_LINFLEXUART 121 >>> >>> Do you really need this modified? >> >> Hello Greg, >> >> This macro is meant to be assigned to port->type in the config_port >> method from uart_ops, in order for verify_port to know if the received >> serial_struct structure was really targeted for a LINFlex port. It >> needs to be defined outside, to avoid "collisions" with other drivers. > > Yes, I know what it goes to, but does anyone in userspace actually use > it? No, we do not use it from userspace, but kept the pattern only for conformance. >> Other than that, I do not see anything wrong with the addition of a >> define in serial_core.h for this purpose (which is also what most of the >> serial drivers do, including amba-pl011.c, mentioned in >> Documentation/driver-api/serial/driver.rst as providing the reference >> implementation), so please be more specific. > > I am getting tired of dealing with merge issues with that list, and no > one seems to be able to find where they are really needed for userspace, > especially for new devices. What happens if you do not have use it? I see. If I drop its usage completely and leave 'type' from the uart_port as 0, uart_port_startup() will fail when finding that uport->type == PORT_UNKNOWN at [1] (there may be other effects as well, e.g. due to the check in uart_configure_port[2]). So I suppose that I need to define some nonzero 'PORT_KNOWN' macro in the driver and use that one internally for 'type'. Is my understanding correct? Will there be any problems if I define it to a positive integer which is already assigned to another driver, according to serial_core.h? Regards, Stefan [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/serial_core.c?h=v5.3-rc1#n188 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/serial_core.c?h=v5.3-rc1#n2348 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel