linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Yinbo Zhu <yinbo.zhu@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Xiaobo Xie <xiaobo.xie@nxp.com>, Leo Li <leoyang.li@nxp.com>,
	Rob Herring <robh+dt@kernel.org>, Jiafei Pan <jiafei.pan@nxp.com>,
	Ran Wang <ran.wang_1@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH v2] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape
Date: Mon, 14 Oct 2019 07:47:58 +0000	[thread overview]
Message-ID: <VI1PR04MB41582B7ADE5D8786DE937CA5E9900@VI1PR04MB4158.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191014065210.GE12262@dragon>



-----Original Message-----
From: Shawn Guo <shawnguo@kernel.org> 
Sent: 2019年10月14日 14:52
To: Yinbo Zhu <yinbo.zhu@nxp.com>
Cc: Leo Li <leoyang.li@nxp.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Xiaobo Xie <xiaobo.xie@nxp.com>; Jiafei Pan <jiafei.pan@nxp.com>; Ran Wang <ran.wang_1@nxp.com>; linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [EXT] Re: [PATCH v2] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape

Caution: EXT Email

On Tue, Sep 24, 2019 at 11:29:03AM +0800, Yinbo Zhu wrote:
> layerscape otg function should be supported HNP SRP and ADP protocol 
> accroing to rm doc, but dwc3 code not realize it and use id pin to 
> detect who is host or device(0 is host 1 is device) this patch is to 
> enable OTG mode on ls1028ardb ls1088ardb and ls1046ardb in dts
>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 4 ++++  
> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 4 ++++  
> arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 1 +

> this is an arm64 DTS patch, so the patch prefix should be something like 'arm64 dts: fsl: ...'
    
> Shawn 
Hi Shawn guo,

This patch I had updated to v3, please check that v3 version.

Regards,
Yinbo Zhu.
>  3 files changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index 9fb9113..076cac6 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -171,3 +171,7 @@
>  &sata {
>       status = "okay";
>  };
> +
> +&usb1 {
> +     dr_mode = "otg";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> index 6a6514d..0c742be 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> @@ -122,6 +122,10 @@
>       };
>  };
>
> +&usb1 {
> +     dr_mode = "otg";
> +};
> +
>  #include "fsl-ls1046-post.dtsi"
>
>  &fman0 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> index 8e925df..90b1989 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> @@ -95,5 +95,6 @@
>  };
>
>  &usb1 {
> +     dr_mode = "otg";
>       status = "okay";
>  };
> --
> 2.9.5
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2019-10-14  7:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24  3:29 [PATCH v2] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape Yinbo Zhu
2019-09-24  3:30 ` Yinbo Zhu
2019-10-14  6:52 ` Shawn Guo
2019-10-14  7:47   ` Yinbo Zhu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB41582B7ADE5D8786DE937CA5E9900@VI1PR04MB4158.eurprd04.prod.outlook.com \
    --to=yinbo.zhu@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jiafei.pan@nxp.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ran.wang_1@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=xiaobo.xie@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).