Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Peng Ma <peng.ma@nxp.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Leo Li <leoyang.li@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH 3/4] dmaengine: fsl-edma: support little endian for edma driver
Date: Wed, 22 May 2019 06:33:12 +0000
Message-ID: <VI1PR04MB44319B81D1DBBB4752822813ED000@VI1PR04MB4431.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190521043807.GN15118@vkoul-mobl>

Hi Vinod,

Thank for you reply.
the registers (CHCFG0 - CHCFG15) on big endian socs as fallows:
CHCFG0		0x0
CHCFG1		0x1
CHCFG2		0x2
CHCFG3		0x3
......
CHCFG12		0xC
CHCFG13		0xD
CHCFG14		0xE
CHCFG15		0xF

On little endian socs as fallows:
CHCFG3		0x0
CHCFG2		0x1
CHCFG1		0x2
CHCFG0		0x3
......
CHCFG15		0xC
CHCFG14		0xD
CHCFG13		0xE
CHCFG12		0xF

To fit this map we should add this patch.

Best Regards,
Peng
>-----Original Message-----
>From: Vinod Koul <vkoul@kernel.org>
>Sent: 2019Äê5ÔÂ21ÈÕ 12:38
>To: Peng Ma <peng.ma@nxp.com>
>Cc: robh+dt@kernel.org; shawnguo@kernel.org; mark.rutland@arm.com; Leo
>Li <leoyang.li@nxp.com>; dan.j.williams@intel.com;
>dmaengine@vger.kernel.org; devicetree@vger.kernel.org;
>linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
>Subject: [EXT] Re: [PATCH 3/4] dmaengine: fsl-edma: support little endian for
>edma driver
>
>Caution: EXT Email
>
>On 06-05-19, 09:03, Peng Ma wrote:
>> improve edma driver to support little endian.
>
>Can you explain a bit more how adding the below lines adds little endian
>support...
>
>>
>> Signed-off-by: Peng Ma <peng.ma@nxp.com>
>> ---
>>  drivers/dma/fsl-edma-common.c |    5 +++++
>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/dma/fsl-edma-common.c
>> b/drivers/dma/fsl-edma-common.c index 680b2a0..6bf238e 100644
>> --- a/drivers/dma/fsl-edma-common.c
>> +++ b/drivers/dma/fsl-edma-common.c
>> @@ -83,9 +83,14 @@ void fsl_edma_chan_mux(struct fsl_edma_chan
>*fsl_chan,
>>       u32 ch = fsl_chan->vchan.chan.chan_id;
>>       void __iomem *muxaddr;
>>       unsigned int chans_per_mux, ch_off;
>> +     int endian_diff[4] = {3, 1, -1, -3};
>>
>>       chans_per_mux = fsl_chan->edma->n_chans / DMAMUX_NR;
>>       ch_off = fsl_chan->vchan.chan.chan_id % chans_per_mux;
>> +
>> +     if (!fsl_chan->edma->big_endian)
>> +             ch_off += endian_diff[ch_off % 4];
>> +
>>       muxaddr = fsl_chan->edma->muxbase[ch / chans_per_mux];
>>       slot = EDMAMUX_CHCFG_SOURCE(slot);
>>
>> --
>> 1.7.1
>
>--
>~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06  9:03 [PATCH 1/4] arm64: dts: fsl: ls1028a: Add qDMA node Peng Ma
2019-05-06  9:03 ` [PATCH 2/4] arm64: dts: fsl: ls1028a: Add eDMA node Peng Ma
2019-06-18 13:13   ` Shawn Guo
2019-06-19  1:47     ` [EXT] " Peng Ma
2019-05-06  9:03 ` [PATCH 3/4] dmaengine: fsl-edma: support little endian for edma driver Peng Ma
2019-05-21  4:38   ` Vinod Koul
2019-05-22  6:33     ` Peng Ma [this message]
2019-05-06  9:03 ` [PATCH 4/4] dt-bindings: fsl-qdma: Add LS1028A qDMA bindings Peng Ma
2019-06-13 18:07   ` Rob Herring
2019-06-18 13:08   ` Shawn Guo
2019-06-18 13:06 ` [PATCH 1/4] arm64: dts: fsl: ls1028a: Add qDMA node Shawn Guo

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB44319B81D1DBBB4752822813ED000@VI1PR04MB4431.eurprd04.prod.outlook.com \
    --to=peng.ma@nxp.com \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox