From: Peng Ma <peng.ma@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leo Li <leoyang.li@nxp.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/2] arm64: dts: lx2160a: add sata node support
Date: Mon, 14 Jan 2019 09:52:38 +0000 [thread overview]
Message-ID: <VI1PR04MB4431BD06BD9651BEEED031E9ED800@VI1PR04MB4431.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190113040546.GL11426@dragon>
>-----Original Message-----
>From: Shawn Guo <shawnguo@kernel.org>
>Sent: 2019年1月13日 12:06
>To: Peng Ma <peng.ma@nxp.com>
>Cc: axboe@kernel.dk; Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org;
>mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
>devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
>linux-ide@vger.kernel.org
>Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add sata node support
>
>On Thu, Jan 10, 2019 at 06:05:33PM +0800, Peng Ma wrote:
>> Add sata node support and Enable sata support
>>
>> Signed-off-by: Peng Ma <peng.ma@nxp.com>
>> ---
>> arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 16 +++++++
>> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 44
>+++++++++++++++++++++
>> 2 files changed, 60 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>> index 6481e5f..aacca27 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>> @@ -117,3 +117,19 @@
>> &usb1 {
>> status = "okay";
>> };
>> +
>> +&sata0 {
>> + status = "okay";
>> +};
>> +
>> +&sata1 {
>> + status = "okay";
>> +};
>> +
>> +&sata2 {
>> + status = "okay";
>> +};
>> +
>> +&sata3 {
>> + status = "okay";
>> +};
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> index a79f5c1..e857a14 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> @@ -762,5 +762,49 @@
>> <GIC_SPI 209 IRQ_TYPE_LEVEL_HIGH>;
>> dma-coherent;
>> };
>> +
>> + sata0: sata@3200000 {
>> + status = "disabled";
>
>We usually have 'status' at the end of property list.
>
>Shawn
[Peng Ma]
Ok, got it, thanks yure quick reply.
Regards,
Peng
>
>> + compatible = "fsl,lx2160a-ahci";
>> + reg = <0x0 0x3200000 0x0 0x10000>,
>> + <0x7 0x100520 0x0 0x4>;
>> + reg-names = "ahci", "sata-ecc";
>> + interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clockgen 4 3>;
>> + dma-coherent;
>> + };
>> +
>> + sata1: sata@3210000 {
>> + status = "disabled";
>> + compatible = "fsl,lx2160a-ahci";
>> + reg = <0x0 0x3210000 0x0 0x10000>,
>> + <0x7 0x100520 0x0 0x4>;
>> + reg-names = "ahci", "sata-ecc";
>> + interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clockgen 4 3>;
>> + dma-coherent;
>> + };
>> +
>> + sata2: sata@3220000 {
>> + status = "disabled";
>> + compatible = "fsl,lx2160a-ahci";
>> + reg = <0x0 0x3220000 0x0 0x10000>,
>> + <0x7 0x100520 0x0 0x4>;
>> + reg-names = "ahci", "sata-ecc";
>> + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clockgen 4 3>;
>> + dma-coherent;
>> + };
>> +
>> + sata3: sata@3230000 {
>> + status = "disabled";
>> + compatible = "fsl,lx2160a-ahci";
>> + reg = <0x0 0x3230000 0x0 0x10000>,
>> + <0x7 0x100520 0x0 0x4>;
>> + reg-names = "ahci", "sata-ecc";
>> + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clockgen 4 3>;
>> + dma-coherent;
>> + };
>> };
>> };
>> --
>> 1.7.1
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-14 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 10:05 [PATCH 1/2] ahci: qoriq: add lx2160 platforms support Peng Ma
2019-01-10 10:05 ` [PATCH 2/2] arm64: dts: lx2160a: add sata node support Peng Ma
2019-01-13 4:05 ` Shawn Guo
2019-01-14 9:52 ` Peng Ma [this message]
2019-01-10 10:31 ` [PATCH 1/2] ahci: qoriq: add lx2160 platforms support Peng Ma
2019-01-10 20:30 ` Leo Li
2019-01-11 6:35 ` Peng Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB4431BD06BD9651BEEED031E9ED800@VI1PR04MB4431.eurprd04.prod.outlook.com \
--to=peng.ma@nxp.com \
--cc=axboe@kernel.dk \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).