From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B862FC7618B for ; Wed, 24 Jul 2019 09:53:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B0CA21BF6 for ; Wed, 24 Jul 2019 09:53:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MeH5Jhrb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="EaXRVWMi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B0CA21BF6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H/5wALmVBNSfgPMuATI0P/7rt3lhvrUTkegR4mYYWoc=; b=MeH5JhrbFrvNgm yjNYqFTrQi7h4Y4SP3mrBoIP7bLjgH9VcfAXpZqRzHFlvjV00kNOLYnquAL1KpVa8iD0XbidLIT08 aiL9gbY7v6Mkp1atAL1j942DgPm8Xa4TCHC/Q8Fpi/9J7lg+XDfZVDu+ot9LOSvCzj96A8Ebpm0FQ wEwBmu74aRRGhNd6QYnlMc3f6ojTrLDQVfWOZHSmBRSVoQpGLIJ6S1F8qDwsEKwCDTw6xPMAKRJLY w1VFODuH0ii0mVeGX96wOnmGaFC9tNuSJM8jlWt7izgE6KjKjIo3gTtjL+5D0ZbYB7AMeFgUZ0fLq i5dkHFsA+RJWywVyANOQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqDxt-00071q-3i; Wed, 24 Jul 2019 09:53:41 +0000 Received: from mail-eopbgr140058.outbound.protection.outlook.com ([40.107.14.58] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqDxa-0006pC-6j for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2019 09:53:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D9gkJ8Hcy+kbGvKAX2jzNKiEPqtyQaVYm/tBVEYDdpNi9FDjv83sKBntR6bkhma3U9vo0JY8S9JHa+eVYbqT2zXTuFxjztEt6iaeESOr5zwvcCEdrGJaQfNFDWeAKVnQV/hB5o8S4tF9jwXsXRlBgFlsgHSPDjXtfoFoPZ5nZu3+m820qh3121iwfamTNjgBMbKplVRtlowrpzcCjq9lH+tFb2YKbnOUD4QxxG6j5LBp7KYpheWZ66pfoH+ZBoLLVXQ91345Qhcb6BdFV8vr7UzwVIEqbPzNjuEN/qPSajdBHn+/8UA8M0cd5m7B4wWCdo+WDU9rc0EUzpLppSnX8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jlJUGkDvj60iDKEM242eqpc4TePTT3N6hyEQgX3fxuU=; b=NeP+PiOzhhNRoDiRjeiD663gM2zdOIGqPQbtKptvCc+yGqWR/CZu8FjbN8tHQJdzpAxu8/HzMNWRiJ/3ZHdBEEEGRtgRDn5teeD9CoUO7PieEMst3yHAfgCK8xwMZqpU0jjDcXV87uF4nnC9YayCYDGmP52pCZxSO5z+hcj5PggGZ5BRQRwDQP358fooFWv1w0dB+Z+7g7ZbsBGe7cgeGeUfzo2GHcoCLO1CZgCzNey8VrB/xPC8R8/7w0ijBKaYikOLGu2msFKYvhZjbhNzXe9dXWWyIlk6zUFoOTadARxMA4HoT+MGCpRTAgVNMuOlIbAm3rslRN1T6HRg06+/Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=nxp.com;dmarc=pass action=none header.from=nxp.com;dkim=pass header.d=nxp.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jlJUGkDvj60iDKEM242eqpc4TePTT3N6hyEQgX3fxuU=; b=EaXRVWMiT5sXDPtu4cUDmLGeat+bjnM0Ml6BiMEm7nyGEeuC5tg0No4GWu0X1mjQdgphKdBf5JuF0lBJvpYWNlgv4XzBDfUw9wG45XErBbzGWc9VEhyVHD80oyHBulunrd1etnavusEhC07koYyjrwFiuf38v8CeshQ2bsQiTLU= Received: from VI1PR04MB4880.eurprd04.prod.outlook.com (20.177.49.153) by VI1PR04MB6062.eurprd04.prod.outlook.com (20.179.25.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.17; Wed, 24 Jul 2019 09:53:15 +0000 Received: from VI1PR04MB4880.eurprd04.prod.outlook.com ([fe80::e401:6546:3729:47c0]) by VI1PR04MB4880.eurprd04.prod.outlook.com ([fe80::e401:6546:3729:47c0%6]) with mapi id 15.20.2115.005; Wed, 24 Jul 2019 09:53:15 +0000 From: Claudiu Manoil To: Andrew Lunn Subject: RE: [PATCH net-next 1/3] enetc: Add mdio bus driver for the PCIe MDIO endpoint Thread-Topic: [PATCH net-next 1/3] enetc: Add mdio bus driver for the PCIe MDIO endpoint Thread-Index: AQHVQWmTb9jG7sYluUe4Xi/RkNWlU6bYyBMAgAC+B+A= Date: Wed, 24 Jul 2019 09:53:15 +0000 Message-ID: References: <1563894955-545-1-git-send-email-claudiu.manoil@nxp.com> <1563894955-545-2-git-send-email-claudiu.manoil@nxp.com> <20190723222454.GE13517@lunn.ch> In-Reply-To: <20190723222454.GE13517@lunn.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=claudiu.manoil@nxp.com; x-originating-ip: [212.146.100.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eca3931c-ae45-48e7-503e-08d7101cbfa3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB6062; x-ms-traffictypediagnostic: VI1PR04MB6062: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(346002)(376002)(396003)(366004)(13464003)(189003)(199004)(33656002)(55016002)(44832011)(2906002)(6436002)(486006)(66066001)(9686003)(25786009)(6116002)(8936002)(68736007)(7696005)(6506007)(478600001)(102836004)(76176011)(53936002)(52536014)(81166006)(64756008)(446003)(66476007)(74316002)(186003)(3846002)(99286004)(316002)(8676002)(14454004)(81156014)(305945005)(26005)(4326008)(7736002)(256004)(6246003)(76116006)(5660300002)(54906003)(11346002)(66946007)(66556008)(86362001)(476003)(71200400001)(66446008)(71190400001)(6916009)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB6062; H:VI1PR04MB4880.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: lkkyZvLWoNRRW0JSgafroJReIhbberx9NGIvVWAB2env4u9RNks3yj4gys0OMSnDn/ssNScCtQGNA6BsR8kRCUoYF3xk4n4rbrMeVAxA1bMDq6t78zyVtNe7cYOm9hny8qeNogH9HSMI4lXX/gYnAi87QoRIo/U3i076efcuCcU9j46cgikml2hOV75maHwaTTTQrsKXvrgERujJ+5z+RKcJdZLm0eHGZpQUUQPfsW7Ou5ICJ6Ds1pVAEGsdX1l/bA+L53DS4uktbBDjBoJtTWKVdMVAIR5fu5A51DdizlMbrLtXz20EX37dtTPgVsxM6ENaRW5bSIhrOnOGwUkT/MloCFzWRV+TV7QOaLVOYZchL6eK79cZiHUia9MqWGZn5LfexOplOriAXJojk2qJ/808ftQy94kCAZGfT9Bv+Ns= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: eca3931c-ae45-48e7-503e-08d7101cbfa3 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 09:53:15.4665 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: claudiu.manoil@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6062 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190724_025322_694058_E333D024 X-CRM114-Status: UNSURE ( 8.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , Alexandru Marginean , "linux-kernel@vger.kernel.org" , Leo Li , Rob Herring , "David S . Miller" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org >-----Original Message----- >From: Andrew Lunn >Sent: Wednesday, July 24, 2019 1:25 AM >To: Claudiu Manoil >Cc: David S . Miller ; devicetree@vger.kernel.org; >netdev@vger.kernel.org; Alexandru Marginean >; linux-kernel@vger.kernel.org; Leo Li >; Rob Herring ; linux-arm- >kernel@lists.infradead.org >Subject: Re: [PATCH net-next 1/3] enetc: Add mdio bus driver for the PCIe MDIO >endpoint > >> + bus = mdiobus_alloc_size(sizeof(u32 *)); >> + if (!bus) >> + return -ENOMEM; >> + > >> + bus->priv = pci_iomap_range(pdev, 0, ENETC_MDIO_REG_OFFSET, 0); > >This got me confused for a while. You allocate space for a u32 >pointer. bus->priv will point to this space. However, you are not >using this space, you {ab}use the pointer to directly hold the return >from pci_iomap_range(). This works, but sparse is probably unhappy, >and you are wasting the space the u32 pointer takes. > Thanks Andrew, This is not what I wanted to do, don't ask me how I got to this, it's confusing indeed. What's needed here is mdiobus_alloc() or better, devm_mdiobus_alloc(). I've got to do some cleanup in the local mdio bus probing too. Will send v2. Thanks, Claudiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel