From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05DE7C3A59E for ; Wed, 21 Aug 2019 20:40:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CACD62332A for ; Wed, 21 Aug 2019 20:40:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DUp/S8nI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="mQJI4Qnc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CACD62332A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:Date :Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: List-Owner; bh=l6iLYlM+iW0CrD1Uru/nJiVIxTTb27Y+szWmvl3Z3Ps=; b=DUp/S8nIMLDzoN JVHRcHB8A4X2RDu+ryEnSBJgVQnqKx5ZmTuVbMoiyuTmXo2tbNuYFMMFYGnZn+OfJ4BDWOPdYG6Rc +0SIKbsEjWwnLXVAVdKQ4Dk6HF6KtVzVj6fPmuzn1WoqxKFEgG22YW8ThgxhgP9ZzSQqev6BYdpxr FmEHxJEVIF1EyyHNTcHT+OMFitfl2F7zJZ2V/OupafhS4fztTap8NFjbWOxK60ubFgTMMaPwQIma0 WatIFXmXAEbIGQb61EjRfguHbSJ1y91mWCJlMtB34N0OqhD6nB9dfWCcN80rZUHySf8qGLuJYVa8v rn0lobHtqifELvWfkc7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0XOo-0007EH-Dp; Wed, 21 Aug 2019 20:40:06 +0000 Received: from mail-db5eur01on0628.outbound.protection.outlook.com ([2a01:111:f400:fe02::628] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0XOl-0006L5-37 for linux-arm-kernel@lists.infradead.org; Wed, 21 Aug 2019 20:40:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UH2oiBBQKcP2oLHqswKTCii4bFEW8jzkEk1Ild0hnuw7oslSWyyKA6kbzp+z07ObxX7T5yMqLl11lTNNo6FllwmfM1OFqQP/18Dw9HxfVdx5Zytw9NZtJ/H6jJpjwU5Mwf78uccI1XvFUXABg6CnOdV0/VLAeHR5guKF1kAOTx/xnCfRVBR6cq7vdt2S0PJQqAeA+nZdgdYWhEXJSC6/cwObx5HzxZmB2RJ7C5+gTy4Dax7TuLQgGpwlUe+2+cZx7+vjnF6kXGXNMp3pptkFgQFgXusE6CZRVCqjbgvAHoeB/4nkZmpyoEN+y3FMIfPWn27yiin2kfuB2fSWq8P1eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KTNaENpdVtJijgn3pQot9Y0mkqpi42y19eYJ8kKrnfM=; b=nZmdDe4L5zDp0kwdQLgthNgwDTrxP/yVWNYNP+gHkSxb9nEK4Xc5wuineEdVSSKnmh3CC2q6oncEwL10NawcXcgl2/+0JCqtYLpAjb6Z2w1u6FdN/CkOEc1UPbL5TeLiKTXwrWKp9BYzTtEOPDp+5y1hi4hHn+DyC8kt1TOPUSv1dWxiiL8ORZuiBA3QvSWA4o8nJzuZmEbpogVes1GV4blTSec7Q6kpyk813kGDf7OLqyV2vAfRvKSQ6eNOPesgS0rClv3OyB2YffsDLkmzXL7jH9LhYXwsqPKHrpriuzNWMqf4ZUfSHC+dglo915UDUP+tRIFTYGPMPj94JAAg/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KTNaENpdVtJijgn3pQot9Y0mkqpi42y19eYJ8kKrnfM=; b=mQJI4QncipYUoJzN9vaPSFOswBVgFZmSZ15nnpJWQ78wytlp4SaIrNemp6GMSE5VgYIbE+yjHcSHMt+e2tFfAU2zLTdUj5UwGF2mo+8SlabJXhIH1XA7iQZbDvk6RtnePeIGxwYperG8oi1i15UGK4XUt1JYV2PazsXyH+1k2QY= Received: from VI1PR04MB7023.eurprd04.prod.outlook.com (10.186.159.144) by VI1PR04MB3293.eurprd04.prod.outlook.com (10.170.231.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.18; Wed, 21 Aug 2019 20:39:56 +0000 Received: from VI1PR04MB7023.eurprd04.prod.outlook.com ([fe80::c5e8:90f8:da97:947e]) by VI1PR04MB7023.eurprd04.prod.outlook.com ([fe80::c5e8:90f8:da97:947e%3]) with mapi id 15.20.2178.020; Wed, 21 Aug 2019 20:39:56 +0000 From: Leonard Crestez To: Daniel Baluta , "shawnguo@kernel.org" , Abel Vesa Subject: Re: [PATCH v4] arm64: dts: imx8mq: Init rates and parents configs for clocks Thread-Topic: [PATCH v4] arm64: dts: imx8mq: Init rates and parents configs for clocks Thread-Index: AQHVRVgHX+vi+LJNg0ufd7EEy7KERw== Date: Wed, 21 Aug 2019 20:39:56 +0000 Message-ID: References: <20190728152040.15323-1-daniel.baluta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leonard.crestez@nxp.com; x-originating-ip: [89.37.124.34] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c61d291f-35ce-4134-8403-08d72677ba18 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB3293; x-ms-traffictypediagnostic: VI1PR04MB3293: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0136C1DDA4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(396003)(39850400004)(376002)(366004)(199004)(189003)(6436002)(7736002)(81166006)(71200400001)(2501003)(305945005)(74316002)(229853002)(25786009)(66066001)(55016002)(71190400001)(9686003)(44832011)(53546011)(6506007)(476003)(2906002)(81156014)(5660300002)(486006)(446003)(14454004)(52536014)(186003)(26005)(8676002)(102836004)(54906003)(99286004)(110136005)(6636002)(76176011)(76116006)(53936002)(7696005)(478600001)(33656002)(8936002)(316002)(7416002)(256004)(4326008)(6116002)(3846002)(86362001)(66446008)(66946007)(6246003)(66476007)(66556008)(64756008)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB3293; H:VI1PR04MB7023.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Nskwv3f3kHMYD+qYyjlM44//nPkscpkyQf2HIijZvlB3FRv4AAlXpZkzusnzI6heVhwPhd/0uUxguDeiH5i7krvGcB0vfozK2exKcippRg9VAKYrdtnjLce/4hsFBOAmXlJdXzXKYpec43wxMZuh0/mosyBWyssnUmX3g47c8fp5AdUEaVInYJAiwmdIxqUrlqJ+BkOAV0jKIxD/e1so8TV3Uj3JsiSeubqc/bNheClSFwRE4v1hSz8xQlGviQsJMizLp11M991AXDsL24qv1XW4YqYtUP3EvNutcGEW8o0ROw8WEwvDbVf7tU+hcaHodSp6KKMBKcAHoy3vMeaMnkTp9qbn9Cxb4urtkqPT9Wd1SAQ1JNnrwVHGZiYVbYBz5IXO54nMuyg2JortlqEqeXjtuCJTZrskxQWeG1vIdf8= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c61d291f-35ce-4134-8403-08d72677ba18 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2019 20:39:56.0116 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gluK+HYspweKS2HObGCCufjxR5APrAYLj7DglvaFo2Eyen7OLEseU2vIzXFaE7gar5IOxIe6Bk4x9aklZrD2vA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3293 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190821_134003_220983_9B2C03B2 X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "baruch@tkos.co.il" , Jacky Bai , Anson Huang , "ccaione@baylibre.com" , "andrew.smirnov@gmail.com" , "s.hauer@pengutronix.de" , "angus@akkea.ca" , Stephen Boyd , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , "agx@sigxcpu.org" , dl-linux-imx , Peng Fan , "festevam@gmail.com" , "S.j. Wang" , "linux-arm-kernel@lists.infradead.org" , "l.stach@pengutronix.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28.07.2019 18:20, Daniel Baluta wrote: > From: Abel Vesa > > Add the initial configuration for clocks that need default parent and rate > setting. This is based on the vendor tree clock provider parents and rates > configuration except this is doing the setup in dts rather then using clock > consumer API in a clock provider driver. > > Note that by adding the initial rate setting for audio_pll1/audio_pll > setting we need to remove it from imx8mq-librem5-devkit.dts Setting default rates for audio_pll1 and audio_pll2 in soc dtsi makes a lot of sense to me; the intention is for one to run at a multiple of 44.1k and another at a multiple of 48k. > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 02fbd0625318..a55d72ba2e05 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -494,6 +494,25 @@ > clock-names = "ckil", "osc_25m", "osc_27m", > "clk_ext1", "clk_ext2", > "clk_ext3", "clk_ext4"; > + assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1>, > + <&clk IMX8MQ_AUDIO_PLL1>, > + <&clk IMX8MQ_AUDIO_PLL2>, > + <&clk IMX8MQ_CLK_AHB>, > + <&clk IMX8MQ_CLK_NAND_USDHC_BUS>, > + <&clk IMX8MQ_CLK_AUDIO_AHB>, > + <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>, > + <&clk IMX8MQ_CLK_NOC>; > + assigned-clock-parents = <0>, > + <0>, > + <0> > + <&clk IMX8MQ_SYS1_PLL_133M>, > + <&clk IMX8MQ_SYS1_PLL_266M>, > + <&clk IMX8MQ_SYS2_PLL_500M>, > + <&clk IMX8MQ_CLK_27M>, > + <&clk IMX8MQ_SYS1_PLL_800M>; > + assigned-clock-rates = <593999999>, > + <786432000>, > + <722534400>; The audio PLLs should run below 650 mHz so please use 393216000 and 361267200 instead of 786432000 and 722534400. For the 8mm equivalent see commit 053a4ffe2988 ("clk: imx: imx8mm: fix audio pll setting"). You should also move the unbypassing of AUDIO_PLL1 and AUDIO_PLL2 here just add two more assigned-clocks and assigned-clock-parents. -- Regards, Leonard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel