From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA518C05027 for ; Mon, 6 Feb 2023 16:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pSUrywGunlVw2RYpAOd5b20Uh5y/gEbwbAr5E+8gAeI=; b=fgvUSFXYAiTPtx 5kkhN9HKZBV5T67iFdJSE1J0jy/LD8ulRP58uEdeHOBX4x5IJ6N8XSU2u+eeGmoTe15M/oW1t/o43 Mu8tTao4ZjTbOFzZnNQfBBHbUNCx6EOmv4fXbYQjafWqVO/4Pn024MnMDJkehClPSt0X82zEf4Zs8 w+QYqeOwAxtSQ/Opio1mmugs9NxkgnUfp0NSpO5ljCY1hTw6s1R4TRtA0G9zO+pHc6A537ddm2nkl 3Rghj9GPlJUdPXEWV41s2xEoloGzQKtgvlq6qze7LVvor/bkvI2p/Rxoux4AONxKdYbHg9ENvCPHV hoHfIUIsGIcwny5F23Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pP4bN-009MUM-KA; Mon, 06 Feb 2023 16:44:21 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pP4bI-009MRS-Rf for linux-arm-kernel@lists.infradead.org; Mon, 06 Feb 2023 16:44:18 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D1195B8126A; Mon, 6 Feb 2023 16:44:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA53CC433EF; Mon, 6 Feb 2023 16:44:08 +0000 (UTC) Date: Mon, 6 Feb 2023 16:44:05 +0000 From: Catalin Marinas To: Marc Zyngier Cc: Mark Brown , Will Deacon , Oleg Nesterov , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Shuah Khan , Alan Hayward , Luis Machado , Szabolcs Nagy , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 07/21] arm64/sme: Enable host kernel to access ZT0 Message-ID: References: <20221208-arm64-sme2-v4-0-f2fa0aef982f@kernel.org> <20221208-arm64-sme2-v4-7-f2fa0aef982f@kernel.org> <86y1pbywbb.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86y1pbywbb.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230206_084417_044433_FB3D9A50 X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 06, 2023 at 09:31:20AM +0000, Marc Zyngier wrote: > From a6c4aaccd33e453ffc8d8ea23a4dd4d9a263cc89 Mon Sep 17 00:00:00 2001 > From: Marc Zyngier > Date: Mon, 6 Feb 2023 09:24:40 +0000 > Subject: [PATCH] arm64/sme: Fix __finalise_el2 SMEver check > > When checking for ID_AA64SMFR0_EL1.SMEver, __check_override assumes > that the ID_AA64SMFR0_EL1 value is in x1, and the intent of the code > is to reuse value read a few lines above. > > However, as the comment says at the beginning of the macro, x1 will > be clobbered, and the checks always fails. > > The easiest fix is just to reload the id register before checking it. > > Fixes: f122576f3533 ("arm64/sme: Enable host kernel to access ZT0") > Signed-off-by: Marc Zyngier Thanks Marc. I queued it on top of the for-next/sme2 branch. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel