From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4106C433F5 for ; Mon, 10 Oct 2022 16:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LnXdpeMWLCLW+th5nCoijLDbq6a/XREbmDdM+uKMsuY=; b=I4ZWee4gcCKGmK 7b1B6MGknXZ0xevqexEYhtsfTAOujo7TMpseIngYibgISFnBeq0LD0LOCRfglJCsU5lLRcJvwMIY/ pwihCO/fih/+a7UroQUkzgmzjrJwKQ2prIvp6byCKk5ZwCedCieoevzfWRe8c4NDpq4DfWZV6D3Iw 8HBG9i5Auyx5mmRHm89znFaxnsWekqIcYBvj5skHWpqFlD3yCFO0X/vpizAwuLZ6/uSfm31W8HqMT 2qrqdCYQ1L7wb/NPoq1KYFB2VtRcRd5RAqzYXUuUzQs212/Uz3Cl8Z4XNo4LinrlVGmUOk4xAI2SP 9JCQ4xNiJHQOkCUNHVgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohvKF-001SLU-RU; Mon, 10 Oct 2022 16:08:19 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohvKD-001SKa-2M for linux-arm-kernel@lists.infradead.org; Mon, 10 Oct 2022 16:08:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KV1Y2mqbeDknPGS6WJiWl1ceMMTGCDGbeWIIQfg0APE=; b=qfbKgx5KVjEU40velEI96m5hOl GwjVPM9GX3pzhOpQbvAmhR2gou6E3FuWbQHzFszrG8YS9AYPPCkyxXumAHXNEZUYfnh5mg1B0PAah Ac2TmefCK3jkr+p7e+Ag7Jz62BxmTqR8bZl45W2ReP8arCw7s9CNV7hfsDsY0+pdca6saKAc/RJy2 aDLTlPmlj7hL9O5ypIc7ekENH/3/IA76ceo8zQ3su/iO2HqPvPmp4Q4PTVTeclkncGNtV0Zox0vMo LJ+JNHeLVhAQz+fDzjcvxPixXnOUBLorVLjzciLVWTu8mxiZZmrEWpQV5z6Ext2zIwxupftKmxven ZSzB1a4A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34668) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ohvKB-0004rf-FW; Mon, 10 Oct 2022 17:08:15 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ohvKA-0001y7-LY; Mon, 10 Oct 2022 17:08:14 +0100 Date: Mon, 10 Oct 2022 17:08:14 +0100 From: "Russell King (Oracle)" To: Ard Biesheuvel Cc: "Leizhen (ThunderTown)" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] ARM: Fix some check warnings of tool sparse Message-ID: References: <20221010095346.1957-1-thunder.leizhen@huawei.com> <20221010095346.1957-2-thunder.leizhen@huawei.com> <1ab4c651-f0ab-1107-1784-ad255dabc33a@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221010_090817_129153_05649BB1 X-CRM114-Status: GOOD ( 25.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 10, 2022 at 01:06:19PM +0200, Ard Biesheuvel wrote: > On Mon, 10 Oct 2022 at 12:58, Leizhen (ThunderTown) > wrote: > > > > > > > > On 2022/10/10 18:20, Ard Biesheuvel wrote: > > > On Mon, 10 Oct 2022 at 11:56, Zhen Lei wrote: > > >> > > >> Fix the following warnings: > > >> warning: incorrect type in initializer (different address spaces) > > >> expected unsigned short [noderef] __user *register __p > > >> got unsigned short [usertype] * > > >> warning: cast removes address space '__user' of expression > > >> > > >> Signed-off-by: Zhen Lei > > >> --- > > >> arch/arm/kernel/traps.c | 10 +++++----- > > >> 1 file changed, 5 insertions(+), 5 deletions(-) > > >> > > >> diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c > > >> index 20b2db6dcd1ced7..34aa80c09c508c1 100644 > > >> --- a/arch/arm/kernel/traps.c > > >> +++ b/arch/arm/kernel/traps.c > > >> @@ -188,9 +188,9 @@ static void dump_instr(const char *lvl, struct pt_regs *regs) > > >> } > > >> } else { > > >> if (thumb) > > >> - bad = get_user(val, &((u16 *)addr)[i]); > > >> + bad = get_user(val, &((u16 __user *)addr)[i]); > > >> else > > >> - bad = get_user(val, &((u32 *)addr)[i]); > > >> + bad = get_user(val, &((u32 __user *)addr)[i]); > > >> } > > >> > > >> if (!bad) > > >> @@ -455,15 +455,15 @@ asmlinkage void do_undefinstr(struct pt_regs *regs) > > >> if (processor_mode(regs) == SVC_MODE) { > > >> #ifdef CONFIG_THUMB2_KERNEL > > >> if (thumb_mode(regs)) { > > >> - instr = __mem_to_opcode_thumb16(((u16 *)pc)[0]); > > >> + instr = __mem_to_opcode_thumb16(((__force u16 *)pc)[0]); > > > > > > Shouldn't this be __user as well? (and below) > > > > unsigned int instr; > > void __user *pc; > > > > The __user can clear the warning, but a new warning will be generated. > > > > instr = __mem_to_opcode_thumb16(((u16 *)pc)[0]); > > ^new ^old > > > > arch/arm/kernel/traps.c:473:33: warning: dereference of noderef expression > > > > This is because dereferencing a __user pointer is not permitted. > > So this code should be using get_kernel_nofault() here not a plain > dereference of PC. So better to fix that properly instead of papering > over it with a __force cast just to make sparse happy. Why? We won't get here unless the PC can be dereferenced. If it's not able to be dereferenced, then we'd be dealing with a prefetch abort. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel