From: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
James Morse <james.morse@arm.com>, Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <maz@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Oliver Upton <oliver.upton@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
kvmarm@lists.cs.columbia.edu, kvmarm@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] arm64/sysreg: Convert SPE registers to automatic generation
Date: Fri, 21 Oct 2022 11:44:54 +0100 [thread overview]
Message-ID: <Y1J4JhJZs9w1zn6q@sirena.org.uk> (raw)
In-Reply-To: <CAL_JsqLVjWH-x3jxGQpJ3ax_ddvBqHd-P2DE=DEnrknoHuq+Qg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 516 bytes --]
On Thu, Oct 20, 2022 at 02:51:02PM -0500, Rob Herring wrote:
> On Thu, Oct 20, 2022 at 9:33 AM Mark Brown <broonie@kernel.org> wrote:
> > > +Field 11:8 EA
> > This looks like it should be described as an enum.
> 0b0000 Not_Described
> 0b0001 Ignored
> 0b0010 SError
> What's the preferred case here?
Either option is good for case I think, it's a taste question - going
with upper case is more the kernel coding style so fine there, though
sometimes it makes things hard to read.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-21 10:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 19:11 [PATCH v2 0/7] perf: Arm SPEv1.2 support Rob Herring
2022-10-19 19:11 ` [PATCH v2 1/7] perf: arm_spe: Use feature numbering for PMSEVFR_EL1 defines Rob Herring
2022-10-19 19:11 ` [PATCH v2 2/7] arm64: Drop SYS_ from SPE register defines Rob Herring
2022-10-19 19:11 ` [PATCH v2 3/7] arm64/sysreg: Convert SPE registers to automatic generation Rob Herring
2022-10-20 14:33 ` Mark Brown
2022-10-20 19:51 ` Rob Herring
2022-10-21 10:44 ` Mark Brown [this message]
2022-10-19 19:11 ` [PATCH v2 4/7] perf: arm_spe: Drop BIT() and use FIELD_GET/PREP accessors Rob Herring
2022-10-19 19:11 ` [PATCH v2 5/7] perf: arm_spe: Support new SPEv1.2/v8.7 'not taken' event Rob Herring
2022-10-19 19:11 ` [PATCH v2 6/7] perf: Add perf_event_attr::config3 Rob Herring
2022-10-19 19:11 ` [PATCH v2 7/7] perf: arm_spe: Add support for SPEv1.2 inverted event filtering Rob Herring
2022-11-04 11:30 ` [PATCH v2 0/7] perf: Arm SPEv1.2 support James Clark
2022-11-04 14:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1J4JhJZs9w1zn6q@sirena.org.uk \
--to=broonie@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=jolsa@kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).