From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22B8DFA373D for ; Fri, 21 Oct 2022 18:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yWGTDo9EvCGW+FpY2Qa3Is15lpv5ZxMqIRmMi/ebKIw=; b=wX4az46du7SLPV geDgjpcVdmGRIuvCWR+zwKym8VtQFs48xAqG+mH3l5ss/7fn3HrMvxDFZ+mjOW2HXWeWOqZAMuz06 llSpjbT9Ju8geMPC6FxyvPSucpHXNBtfKIPoOag0dsxF/5ZbrpS1OOZYdYUgHVm41xIRMoyohT2Bq k4q44sdpYu4BD9AvqVzFUe3KnIuR23KUn3Y7jdUWs26SqWbzWAIwsBesGsYUetSZhPJFMpaBWD7vb nNo1fuv9guE89LV0Bznm0IrxofsKZZzR7dU27SUImasAQ+YwKW2beEr3umJoZQ6A+S3MsOXP73liJ Jvl1kRly+gyJwAqWGu5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olweE-009Q9u-46; Fri, 21 Oct 2022 18:21:34 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olweA-009Q8V-6f for linux-arm-kernel@lists.infradead.org; Fri, 21 Oct 2022 18:21:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=C7qlKe1YIQ0m/g0CvjzV6JB9l+Ndk49KXqlrtarXqwo=; b=yfLJNg6piIj+zgpgZz1D0f02fW HFeJ4LwDg283s/JVIx2kvZKlQa2WTacN1Yz+pDAjLGFQzh/VZ4DE3PetH6/vZREMHpD7kaWwC1oEg JZEajyC6JsHUht5wiLTLezMok0vPw8fEmviXpalsVKDxSlcmwkVJb8HmMOka1CEXSeYI+qBI6eUXn Z5GLG6Q2akkry0BYKGOlSGRkN3wPXhEGtwVNHR5qT7bJhculgmO5z0qKQg6A8YFm7jN4v4+3CVarr Csmiqf50pjmLc0o8bCEbAiCqphtSguUJFCNFotc9vrVp0Gi6exHWE2xPpO9EF0H1mNz++hPvNdojo 6spUHwKg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34874) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1olwds-0000Zn-2e; Fri, 21 Oct 2022 19:21:12 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1olwdp-0004Mb-3m; Fri, 21 Oct 2022 19:21:09 +0100 Date: Fri, 21 Oct 2022 19:21:09 +0100 From: "Russell King (Oracle)" To: Christoph Hellwig Cc: Marcin Wojtas , Marek =?iso-8859-1?Q?Beh=FAn?= , pali@kernel.org, Robin Murphy , Arnd Bergmann , Andre Przywara , Marc Zyngier , Linus Torvalds , Andrew Lunn , Gregory Clement , Greg Kroah-Hartman , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org Subject: Re: REGRESSION in 6.0-rc7 caused by patch "ARM/dma-mapping: use dma-direct unconditionally" Message-ID: References: <20220930165234.729ad68c@dellmb> <20220930170205.490f1a6b@dellmb> <20221003073037.GB2108@lst.de> <20221003172533.6dc87184@dellmb> <20221004102615.05905935@thinkpad> <20221021163050.GA1194@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221021163050.GA1194@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221021_112130_262506_7BF4EB63 X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 21, 2022 at 06:30:50PM +0200, Christoph Hellwig wrote: > On Thu, Oct 20, 2022 at 07:22:07PM +0100, Russell King (Oracle) wrote: > > Is it possible that this would also cause data corruption reading from > > a SATA card on armada-38x platforms? > > armada-38x eems to be a mvebu platform, so on the account yes. > I'm not sure what SATA host driver is used there, but that must also be > doing weird thing with the DMA API for the issue to hit. None of the devices on armada-38x mark themselves as DMA-coherent, but I believe they are all DMA-coherent - certainly in arch/arm/mach-mvebu/coherency.c, all platform devices will be marked as DMA-coherent via the notifier, which basically means all devices declared in DT need to be DMA-coherent. Since the crypto engine, SD, USB and so on and so forth all use DMA, it's highly likely that all those were broken as well and this isn't limited to just mvneta as originally reported. Basically the entire platform got broken, which really isn't good. At least in this case, I have a test platform I try new kernels out on before putting it on my connectivity-critical hardware - such as the machine that my public connectivity comes through! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel