From: Herbert Xu <herbert@gondor.apana.org.au>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: heiko@sntech.de, ardb@kernel.org, davem@davemloft.net,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
robh+dt@kernel.org, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v10 00/33] crypto: rockchip: permit to pass self-tests
Date: Fri, 28 Oct 2022 13:01:43 +0800 [thread overview]
Message-ID: <Y1tiN9GSMrudUG6d@gondor.apana.org.au> (raw)
In-Reply-To: <20220927075511.3147847-1-clabbe@baylibre.com>
On Tue, Sep 27, 2022 at 07:54:38AM +0000, Corentin Labbe wrote:
> Hello
>
> The rockchip crypto driver is broken and do not pass self-tests.
> This serie's goal is to permit to become usable and pass self-tests.
>
> This whole serie is tested on a rk3328-rock64, rk3288-miqi and
> rk3399-khadas-edge-v with selftests (with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y)
>
> Regards
>
> Changes since v1:
> - select CRYPTO_ENGINE
> - forgot to free fallbacks TFMs
> - fixed kernel test robots warning
> - add the PM patch
>
> Changes since v2:
> - Added DMA clock back to 3288 since it dont work without it
> - fallback needed to select CBC and ECB configs
> - Added support for rk3399
> - Added more patch (style, read_poll_timeout)
>
> Changes since v3:
> - full rewrite of support for RK3399
> - splited dt-binding patch in two
>
> Changes since v4:
> - Another full rewrite of support for RK3399
> - Fixed dt-binding from Krzysztof Kozlowski's comments
> - Use readl_poll_timeout() instead of read_poll_timeout()
> - Rewrite the fallback SG tests
>
> Changes since v5:
> - fixed errors in DT binding patch
>
> Change since v6:
> - remove quotes around const values in dt-bindings
>
> Changes since v7:
> - added lot of reviewed/tested by
> - In patch 14: keep initial reset pulse.
>
> Changes since v8:
> - Removed some useless min/maxitems from dt-binding as reported by dt_binding_check
>
> Change since v9:
> - removed redundant rst_ from reset-names
> - reworked patch #25 commit message
>
> Corentin Labbe (33):
> crypto: rockchip: use dev_err for error message about interrupt
> crypto: rockchip: do not use uninitialized variable
> crypto: rockchip: do not do custom power management
> crypto: rockchip: fix privete/private typo
> crypto: rockchip: do not store mode globally
> crypto: rockchip: add fallback for cipher
> crypto: rockchip: add fallback for ahash
> crypto: rockchip: better handle cipher key
> crypto: rockchip: remove non-aligned handling
> crypto: rockchip: rework by using crypto_engine
> crypto: rockchip: rewrite type
> crypto: rockchip: add debugfs
> crypto: rockchip: introduce PM
> crypto: rockchip: handle reset also in PM
> crypto: rockchip: use clk_bulk to simplify clock management
> crypto: rockchip: add myself as maintainer
> crypto: rockchip: use read_poll_timeout
> crypto: rockchip: fix style issue
> crypto: rockchip: add support for rk3328
> crypto: rockchip: rename ablk functions to cipher
> crypto: rockchip: rework rk_handle_req function
> crypto: rockchip: use a rk_crypto_info variable instead of lot of
> indirection
> crypto: rockchip: use the rk_crypto_info given as parameter
> dt-bindings: crypto: convert rockchip-crypto to YAML
> dt-bindings: crypto: rockchip: add new compatible
> clk: rk3399: use proper crypto0 name
> arm64: dts: rockchip: add rk3328 crypto node
> arm64: dts: rockchip: rk3399: add crypto node
> crypto: rockchip: store crypto_info in request context
> crypto: rockchip: Check for clocks numbers and their frequencies
> crypto: rockchip: rk_ahash_reg_init use crypto_info from parameter
> crypto: rockchip: permit to have more than one reset
> crypto: rockchip: Add support for RK3399
>
> .../crypto/rockchip,rk3288-crypto.yaml | 127 ++++
> .../bindings/crypto/rockchip-crypto.txt | 28 -
> MAINTAINERS | 7 +
> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 11 +
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 20 +
> drivers/crypto/Kconfig | 15 +
> drivers/crypto/rockchip/rk3288_crypto.c | 506 ++++++++--------
> drivers/crypto/rockchip/rk3288_crypto.h | 107 ++--
> drivers/crypto/rockchip/rk3288_crypto_ahash.c | 267 +++++----
> .../crypto/rockchip/rk3288_crypto_skcipher.c | 543 ++++++++++--------
> include/dt-bindings/clock/rk3399-cru.h | 6 +-
> 11 files changed, 949 insertions(+), 688 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
>
> --
> 2.35.1
Patches 1-25,29-33 applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-28 5:03 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 7:54 [PATCH v10 00/33] crypto: rockchip: permit to pass self-tests Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 01/33] crypto: rockchip: use dev_err for error message about interrupt Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 02/33] crypto: rockchip: do not use uninitialized variable Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 03/33] crypto: rockchip: do not do custom power management Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 04/33] crypto: rockchip: fix privete/private typo Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 05/33] crypto: rockchip: do not store mode globally Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 06/33] crypto: rockchip: add fallback for cipher Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 07/33] crypto: rockchip: add fallback for ahash Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 08/33] crypto: rockchip: better handle cipher key Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 09/33] crypto: rockchip: remove non-aligned handling Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 10/33] crypto: rockchip: rework by using crypto_engine Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 11/33] crypto: rockchip: rewrite type Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 12/33] crypto: rockchip: add debugfs Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 13/33] crypto: rockchip: introduce PM Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 14/33] crypto: rockchip: handle reset also in PM Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 15/33] crypto: rockchip: use clk_bulk to simplify clock management Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 16/33] crypto: rockchip: add myself as maintainer Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 17/33] crypto: rockchip: use read_poll_timeout Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 18/33] crypto: rockchip: fix style issue Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 19/33] crypto: rockchip: add support for rk3328 Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 20/33] crypto: rockchip: rename ablk functions to cipher Corentin Labbe
2022-09-27 7:54 ` [PATCH v10 21/33] crypto: rockchip: rework rk_handle_req function Corentin Labbe
2022-09-27 7:55 ` [PATCH v10 22/33] crypto: rockchip: use a rk_crypto_info variable instead of lot of indirection Corentin Labbe
2022-09-27 7:55 ` [PATCH v10 23/33] crypto: rockchip: use the rk_crypto_info given as parameter Corentin Labbe
2022-09-27 7:55 ` [PATCH v10 24/33] dt-bindings: crypto: convert rockchip-crypto to YAML Corentin Labbe
2022-09-27 7:55 ` [PATCH v10 25/33] dt-bindings: crypto: rockchip: add new compatible Corentin Labbe
2022-09-29 22:14 ` Rob Herring
2022-09-27 7:55 ` [PATCH v10 26/33] clk: rk3399: use proper crypto0 name Corentin Labbe
2022-09-28 18:58 ` Stephen Boyd
2022-09-27 7:55 ` [PATCH v10 27/33] arm64: dts: rockchip: add rk3328 crypto node Corentin Labbe
2022-09-27 7:55 ` [PATCH v10 28/33] arm64: dts: rockchip: rk3399: add " Corentin Labbe
2022-12-11 15:51 ` Rob Herring
2022-12-12 12:44 ` Corentin LABBE
2022-09-27 7:55 ` [PATCH v10 29/33] crypto: rockchip: store crypto_info in request context Corentin Labbe
2022-09-27 7:55 ` [PATCH v10 30/33] crypto: rockchip: Check for clocks numbers and their frequencies Corentin Labbe
2022-09-27 7:55 ` [PATCH v10 31/33] crypto: rockchip: rk_ahash_reg_init use crypto_info from parameter Corentin Labbe
2022-09-27 7:55 ` [PATCH v10 32/33] crypto: rockchip: permit to have more than one reset Corentin Labbe
2022-09-27 7:55 ` [PATCH v10 33/33] crypto: rockchip: Add support for RK3399 Corentin Labbe
2022-10-21 13:20 ` [PATCH v10 00/33] crypto: rockchip: permit to pass self-tests Corentin LABBE
2022-10-21 17:09 ` Heiko Stübner
2022-10-26 7:41 ` Corentin LABBE
2022-10-26 10:05 ` Herbert Xu
2022-10-26 10:25 ` Heiko Stübner
2022-10-28 2:06 ` Krzysztof Kozlowski
2022-10-28 5:01 ` Herbert Xu [this message]
2022-10-29 8:12 ` (subset) " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1tiN9GSMrudUG6d@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).