From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 498E5C433FE for ; Tue, 8 Nov 2022 22:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1k/9AMIJonu4yUWD681UAzeMVLXj+O+doz58N2CrpmU=; b=rCTVUwr8Ou1E6q 4gMkmNNV95MnQbBhXbYA/VTYigBRwU8tKS2KazWwNxM9btMQFmpuWFFpGYKX8ZIBqQFCghRLmlLqI JiaSY3vO9TCSCHbeqACugn9lfDtVIp+C+4kI8LPq1IfV53xIwIeGEcZPKcQNC/V4RV7cXlMf8z5iO 808adL0KvHihI8d8AH/33wmRUiYb3JQv6i4U1ymJcbNUIE7PLJlXuC58rPBgquowc+HQXvEzSDFm+ sFoQw87koJT8W2W0TZd5RvdSGAYxNkPtUBIgD2HSfw2N/GLiGOE47bjdD2V6gXOoFgSe1FWf0hGK0 1Uo2YPdWPJx0yIg8PhVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osWze-008jfX-41; Tue, 08 Nov 2022 22:22:54 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osWza-008jer-L2 for linux-arm-kernel@lists.infradead.org; Tue, 08 Nov 2022 22:22:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zYyanDMS7UJb84EtdS7cHxe2fuNmE7aWwwPvwZsu/WI=; b=pjnD5+xh4f64K7NOSX50/VYPBb MsEwM6EU2gSrunRa0vZ39fWzYD1OEFgA1vtQZZkgJeZqH9+BhvqpyhIP6PZpIequ/SDuuYs1NUTHx s8QT1rU4aodn1PCdRmXi+9Ri0v0Kk32Hw552gF/XZ9SCxxAeOGZeRxO7g8ViHmZoaS4jHgADkOUyZ ITX+Q2kXQYptZ/Mabx+aQ6U1QkHaPRD/X/RtY7NyFSPMhs1yk8UEkvl2yvIgCwAQHj/3YQMCP9XOb KhoFWmhw6lSWIhEIpDFuuDw2HX2Ymw8bC7IHQLIlkrDStzrn/kwDdcAL/0rXY38Rd20SsXT1EsUEt 1GFZTp4Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35182) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1osWzJ-0003oD-Io; Tue, 08 Nov 2022 22:22:33 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1osWzH-00056K-Lr; Tue, 08 Nov 2022 22:22:31 +0000 Date: Tue, 8 Nov 2022 22:22:31 +0000 From: "Russell King (Oracle)" To: Krzysztof Kozlowski Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Lee Jones , Alyssa Rosenzweig , Andy Shevchenko , asahi@lists.linux.dev, devicetree@vger.kernel.org, Hector Martin , Jonathan Corbet , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Sven Peter Subject: Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller Message-ID: References: <531d88b8-75db-1d8f-1384-b8d05594e7b3@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <531d88b8-75db-1d8f-1384-b8d05594e7b3@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221108_142250_711536_086483F7 X-CRM114-Status: GOOD ( 24.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 08, 2022 at 09:55:58PM +0100, Krzysztof Kozlowski wrote: > On 08/11/2022 17:33, Russell King (Oracle) wrote: > > Add a DT binding for the Apple Mac System Management Controller. > > Drop the second, redundant "binding" from subject. It's already in prefix. Yet another thing that's been there from the start... how many more things are you going to pick up in subsequent versions of the patch? When does this stop? In any case, taking your comment literally, "dt-bindings: mfd: add for Apple Mac System Management Controller" makes no sense, so presumably you want something more than that. In any case, I see several recent cases already merged which follow the pattern that I've used and that you've reviewed. > > Signed-off-by: Russell King (Oracle) > > --- > > .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ > > 1 file changed, 67 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yaml > > > > diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > > new file mode 100644 > > index 000000000000..014eba5a1bbc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > > @@ -0,0 +1,67 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Apple Mac System Management Controller > > + > > +maintainers: > > + - Hector Martin > > + > > +description: > > + Apple Mac System Management Controller implements various functions > > + such as GPIO, RTC, power, reboot. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - apple,t6000-smc > > + - apple,t8103-smc > > + - apple,t8112-smc > > + - const: apple,smc > > + > > + reg: > > + items: > > + - description: SMC area > > + - description: SRAM area > > + > > + reg-names: > > + items: > > + - const: smc > > + - const: sram > > + > > + mboxes: > > + maxItems: 1 > > + > > + gpio: > > + $ref: /schemas/gpio/gpio-macsmc.yaml > > So this depends on other patch, so: > 1. You need mention the dependency in cover letter (nothing there), > 2. Re-order patches. > > The GPIO cannot go separate tree and this must be explicitly communicated. Sigh, getting an order that is sensible is really bloody difficult. I'm quite sure Lee is only going to want to apply the mfd bits. Then what do we do with the other bits? GPIO stuff via the GPIO tree, then wait a cycle before the rest can be merged. Or what? > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - mboxes > > + > > +examples: > > + - | > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + smc@23e400000 { > > Usually these are called system-controller, to have a generic name (as > asked by DT spec). I'll defer to Hector for his response on this one, but you've had had plenty of opportunities to bring this up in the past - it's been there since the first posting. Frustrating is definitely the word for this drip-drip-drip review. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel