From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F4A1C4332F for ; Mon, 12 Dec 2022 12:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2+DkSjVTSA/qppW4IYt76kYYagmPH5GHGsbziVkd5eU=; b=XVbRWABZ+XacCd A94cbYWd3BJ+6xIupOunWd6w4q8hPkBLhx2KJLjWezlkar75XonQAZJIQ9+u72mh4ApRTbXh8FfA4 OKf+CJLFfxmfOT/8Z7tn+EOgFdcWxLKWdvRJRIbf9baq7IJTbFDvZNb/NRFCsH/npwwo6GWpF5keh 6doSerOytaWcIBgIDJmUtV4J/XqetsNvJZAxKM+wAK4o4NhiPQ0f2qzirlb5FDXovz3CYw4ny37Qm /nrh5bozbr3aebdHEIZTpF/GfprgixcjV10oOc+JQ/r28N8OjNqkKwFXEDxTaBkSA7eycB2JVph3f wjRm9tl1BVHR42qmkaQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4iAS-00FnHl-5G; Mon, 12 Dec 2022 12:44:24 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4iAN-00Fn1q-Ej for linux-arm-kernel@lists.infradead.org; Mon, 12 Dec 2022 12:44:22 +0000 Received: by mail-wm1-x330.google.com with SMTP id v7so5207501wmn.0 for ; Mon, 12 Dec 2022 04:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=n7ey5OE4WbD1JahXkqzMDy7rEZ6qWxzQ6t8f0HPSRNs=; b=qUTeXZxuhuYycyobAALAsMsiPtMXWTK0cbENHii/uMQzfin6RsG6UXWghBAnEMZbX9 pLTDHrCfmf+gaM4wx+Z3w+++qqLWsUHw2TiVPC+gX5u0WCqV/oBny6cbQDTjmibNQ/0L J2VSja4ME/RDtxUoM2MrSDnRXuqGITyuxog8Nc5kp+WrslUqLFD/0EizAilSrVAt9Nwr b+E6Ts0aE7K07sTpFRlyxkwNHxj3RTOJy3YVPY4whhl14QrkZsIUps3ML6uX2g/LmheS 5gUiQg5x478OLPYtDTZ2U6RAJIKX7zrCS+HVXoTsDXHsfhgMWlVt3V4rxxTdZHsLYC36 qM2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n7ey5OE4WbD1JahXkqzMDy7rEZ6qWxzQ6t8f0HPSRNs=; b=Eor8oWTf+bzEZJHt4OzjkPOgfoJtKjq3ovv3tKlsKZLVtk0eB8A/9mq6wa2KWKiID7 8Fu7WwctN0tYTbgKctKsRRPKa0+B6WTvgX7ra5U3abV/mSrdTuuNNmI5gbU5PBGt7NhC h7mNjkwKDUxScLqLt36Q58G2SALZEHN733pZFE6tBvLDaOzXIvm7h8abK9PtsVuFnm+n qAptGB1/YawLw6AWnenqmdh56fD9VqmdgFi8ZobCmjdfit6h44g6hBGS0/0vh1b+ecEs rO3fqXBWQikiI3bKFJC6Mo63fWjqQebirB46wiH1ifSQ3n5ex5qlr5UwHD4yh+68Hl77 4t1A== X-Gm-Message-State: ANoB5pnYxeZkPqw1nfmmU8akXSBLlHu90/Sm/FEVrdsnJwUzoHoBZ8Mi F19ThBWJt0Sdp8TtkwCnw3MCMA== X-Google-Smtp-Source: AA0mqf5LTY9uPSvi1G6cqxJF3CcL4A+t/hPjYQhFazq21Aj9/MjvP9uQfiQ6LD0UD5sXSAcK4yzQGw== X-Received: by 2002:a05:600c:4691:b0:3d0:5254:8a43 with SMTP id p17-20020a05600c469100b003d052548a43mr15351923wmo.38.1670849057277; Mon, 12 Dec 2022 04:44:17 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:4a02:2aff:fe07:1efc]) by smtp.googlemail.com with ESMTPSA id c1-20020a05600c0a4100b003d1e3b1624dsm10251490wmq.2.2022.12.12.04.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 04:44:16 -0800 (PST) Date: Mon, 12 Dec 2022 13:44:13 +0100 From: Corentin LABBE To: Rob Herring Cc: heiko@sntech.de, ardb@kernel.org, davem@davemloft.net, herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v10 28/33] arm64: dts: rockchip: rk3399: add crypto node Message-ID: References: <20220927075511.3147847-1-clabbe@baylibre.com> <20220927075511.3147847-29-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221212_044419_701602_62DF8A6B X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Sun, Dec 11, 2022 at 09:51:42AM -0600, Rob Herring a =E9crit : > On Tue, Sep 27, 2022 at 2:56 AM Corentin Labbe wrot= e: > > > > The rk3399 has a crypto IP handled by the rk3288 crypto driver so adds a > > node for it. > > > > Tested-by Diederik de Haas > > Signed-off-by: Corentin Labbe > > --- > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot= /dts/rockchip/rk3399.dtsi > > index 92c2207e686c..4391aea25984 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > @@ -582,6 +582,26 @@ saradc: saradc@ff100000 { > > status =3D "disabled"; > > }; > > > > + crypto0: crypto@ff8b0000 { > > + compatible =3D "rockchip,rk3399-crypto"; > > + reg =3D <0x0 0xff8b0000 0x0 0x4000>; > > + interrupts =3D ; > > + clocks =3D <&cru HCLK_M_CRYPTO0>, <&cru HCLK_S_CRYPTO0>= , <&cru SCLK_CRYPTO0>; > > + clock-names =3D "hclk_master", "hclk_slave", "sclk"; > > + resets =3D <&cru SRST_CRYPTO0>, <&cru SRST_CRYPTO0_S>, = <&cru SRST_CRYPTO0_M>; > > + reset-names =3D "master", "lave", "crypto"; > = > This doesn't match the binding: > = > crypto@ff8b8000: reset-names:2: 'crypto-rst' was expected > crypto@ff8b0000: reset-names:2: 'crypto-rst' was expected > crypto@ff8b0000: reset-names:1: 'slave' was expected > = Hello I will send a patch to fix that Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel