From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AE24C46467 for ; Mon, 16 Jan 2023 10:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZHidnOY6lWQAQI0F8ArqX69VlDZu5ns1eEp0d1vYSb8=; b=p2EBp7vFmwigYv aTLzW8oOllNrf5AxcoG4ftON8+fNWHCecRFjm8btosuHJaWyqflpFJDYaHNFC5Oo9st9qov1ERUOj XY6hGaWV+RQj3oyVl13ueZqp7p+JFLnB5uyGy3rkKOSooFQwASrTt7b52gLxeNSAyvp2Hful5fvU0 K7GIp1QAYufy01y42l+NM13EjxDpMJAquwUQp4kdP9v0E33CkjBKHL334szXdLZCiqJducFbyEGuh ILMgaKhaNTuySnwHpwk4JnTlGjOxv9c0yhpbafxtS/aqXmwu2xiT4W1udHpZyuYJ5BUBdn2fAUnfL bSWrmwgHJjmBEGCG2VWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHMMB-009YfG-7N; Mon, 16 Jan 2023 10:04:47 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHMM3-009YcK-L0 for linux-arm-kernel@lists.infradead.org; Mon, 16 Jan 2023 10:04:41 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E8BF260F38; Mon, 16 Jan 2023 10:04:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D1DCC433D2; Mon, 16 Jan 2023 10:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673863478; bh=yUzwH9Ke9wKRkIj/1dw81U6sB1xyw9DLNsfLkvCxbhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KQ2b33CXN4NLnxZPZ9aUJ19rJ8lQkBrQ3AH3GKReYbpODOYh4GOX56zF2YBFSkq7g TPjDDdJP7f5T2AjEbbbdAYY50uvcQ5Eggtm0/ia1cycAVG8atX+mXGdo5skT46kAPK 79/h71ygJG5BSR+4cJxC2w03UG/RCtUzH314fhunizYYc9/BbVhTnm88i6OvUy26EC J86KrxEwOhUM/9K/1dXVgMNMOYQJHFoVni/+iisF24PaaFzySqPjZUewA4JAvlhv3q VNdgvEAsrVtn9HStWHcIWfekfKfWAAdcOyA7wZkqff36sDR8bOCONfJqD5odPU+y9g 8Smx19Evuc6XQ== Date: Mon, 16 Jan 2023 12:04:33 +0200 From: Leon Romanovsky To: Siddharth Vadapalli Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, linux@armlinux.org.uk, pabeni@redhat.com, rogerq@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, srk@ti.com Subject: Re: [PATCH net-next v2] net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action Message-ID: References: <20230116044517.310461-1-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230116_020439_799894_029A6492 X-CRM114-Status: GOOD ( 35.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 16, 2023 at 01:13:36PM +0530, Siddharth Vadapalli wrote: > > > On 16/01/23 13:00, Leon Romanovsky wrote: > > On Mon, Jan 16, 2023 at 10:15:17AM +0530, Siddharth Vadapalli wrote: > >> The am65_cpts_release() function is registered as a devm_action in the > >> am65_cpts_create() function in am65-cpts driver. When the am65-cpsw driver > >> invokes am65_cpts_create(), am65_cpts_release() is added in the set of devm > >> actions associated with the am65-cpsw driver's device. > >> > >> In the event of probe failure or probe deferral, the platform_drv_probe() > >> function invokes dev_pm_domain_detach() which powers off the CPSW and the > >> CPSW's CPTS hardware, both of which share the same power domain. Since the > >> am65_cpts_disable() function invoked by the am65_cpts_release() function > >> attempts to reset the CPTS hardware by writing to its registers, the CPTS > >> hardware is assumed to be powered on at this point. However, the hardware > >> is powered off before the devm actions are executed. > >> > >> Fix this by getting rid of the devm action for am65_cpts_release() and > >> invoking it directly on the cleanup and exit paths. > >> > >> Fixes: f6bd59526ca5 ("net: ethernet: ti: introduce am654 common platform time sync driver") > >> Signed-off-by: Siddharth Vadapalli > >> Reviewed-by: Roger Quadros > >> --- > >> Changes from v1: > >> 1. Fix the build issue when "CONFIG_TI_K3_AM65_CPTS" is not set. This > >> error was reported by kernel test robot at: > >> https://lore.kernel.org/r/202301142105.lt733Lt3-lkp@intel.com/ > >> 2. Collect Reviewed-by tag from Roger Quadros. > >> > >> v1: > >> https://lore.kernel.org/r/20230113104816.132815-1-s-vadapalli@ti.com/ > >> > >> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 8 ++++++++ > >> drivers/net/ethernet/ti/am65-cpts.c | 15 +++++---------- > >> drivers/net/ethernet/ti/am65-cpts.h | 5 +++++ > >> 3 files changed, 18 insertions(+), 10 deletions(-) > >> > >> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c > >> index 5cac98284184..00f25d8a026b 100644 > >> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c > >> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c > >> @@ -1913,6 +1913,12 @@ static int am65_cpsw_am654_get_efuse_macid(struct device_node *of_node, > >> return 0; > >> } > >> > >> +static void am65_cpsw_cpts_cleanup(struct am65_cpsw_common *common) > >> +{ > >> + if (IS_ENABLED(CONFIG_TI_K3_AM65_CPTS) && common->cpts) > > > > Why do you have IS_ENABLED(CONFIG_TI_K3_AM65_CPTS), if > > am65_cpts_release() defined as empty when CONFIG_TI_K3_AM65_CPTS not set? > > > > How is it possible to have common->cpts == NULL? > > Thank you for reviewing the patch. I realize now that checking > CONFIG_TI_K3_AM65_CPTS is unnecessary. > > common->cpts remains NULL in the following cases: > 1. am65_cpsw_init_cpts() returns 0 since CONFIG_TI_K3_AM65_CPTS is not enabled. In this case am65_cpsw_cpts_cleanup() will NOP as well. > 2. am65_cpsw_init_cpts() returns -ENOENT since the cpts node is not defined. It is an error and all callers unwind properly. > 3. The call to am65_cpts_create() fails within the am65_cpsw_init_cpts() > function with a return value of 0 when cpts is disabled. It is disabled by CONFIG_TI_K3_AM65_CPTS, which in turn will make am65_cpsw_cpts_cleanup() NOP. > 4. The call to am65_cpts_create() within the am65_cpsw_init_cpts() function > fails with an error. > > Of the above cases, the am65_cpsw_cpts_cleanup() function would have to handle > cases 1 and 3, since the probe might fail at a later point, following which the > probe cleanup path will invoke the am65_cpts_cpts_cleanup() function. This > function then checks for common->cpts not being NULL, so that it can invoke the > am65_cpts_release() function with this pointer. I still don't see how it is possible. Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel