From: <Daniel.Machon@microchip.com>
To: <petrm@nvidia.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<Lars.Povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
<UNGLinuxDriver@microchip.com>, <joe@perches.com>,
<error27@gmail.com>, <Horatiu.Vultur@microchip.com>,
<Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
<maxime.chevallier@bootlin.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 2/6] net: dcb: add new common function for set/del of app/rewr entries
Date: Mon, 16 Jan 2023 13:00:10 +0000 [thread overview]
Message-ID: <Y8VKWcqGEjPOvCQE@DEN-LT-70577> (raw)
In-Reply-To: <875ydazcfa.fsf@nvidia.com>
> > Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
> > ---
> > net/dcb/dcbnl.c | 104 +++++++++++++++++++++++-------------------------
> > 1 file changed, 49 insertions(+), 55 deletions(-)
> >
> > diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
> > index a76bdf6f0198..6d19564e19a8 100644
> > --- a/net/dcb/dcbnl.c
> > +++ b/net/dcb/dcbnl.c
> > @@ -1099,6 +1099,45 @@ static int dcbnl_getapptrust(struct net_device *netdev, struct sk_buff *skb)
> > return err;
> > }
> >
> > +/* Set or delete APP table or rewrite table entries. The APP struct is validated
> > + * and the appropriate callback function is called.
> > + */
> > +static int dcbnl_apprewr_setdel(struct nlattr *attr, struct net_device *netdev,
> > + int (*setdel)(struct net_device *dev,
> > + struct dcb_app *app),
> > + int (*ops_setdel)(struct net_device *dev,
> > + struct dcb_app *app))
>
> The name makes it look like it's rewrite-specific. Maybe make it
> _app_table_? Given both DCB app and DCB rewrite use app table as the
> database... Dunno. Not a big deal.
Yeah, the other shared funcs are called _app_* too, so lets stick with
that naming. Agreed.
> > /* Handle IEEE 802.1Qaz/802.1Qau/802.1Qbb GET commands. */
> > static int dcbnl_ieee_fill(struct sk_buff *skb, struct net_device *netdev)
> > {
> > @@ -1568,36 +1607,11 @@ static int dcbnl_ieee_set(struct net_device *netdev, struct nlmsghdr *nlh,
> > }
> >
> > if (ieee[DCB_ATTR_IEEE_APP_TABLE]) {
> > - struct nlattr *attr;
> > - int rem;
> > -
> > - nla_for_each_nested(attr, ieee[DCB_ATTR_IEEE_APP_TABLE], rem) {
> > - enum ieee_attrs_app type = nla_type(attr);
> > - struct dcb_app *app_data;
> > -
> > - if (!dcbnl_app_attr_type_validate(type))
> > - continue;
> > -
> > - if (nla_len(attr) < sizeof(struct dcb_app)) {
> > - err = -ERANGE;
> > - goto err;
> > - }
> > -
> > - app_data = nla_data(attr);
> > -
> > - if (!dcbnl_app_selector_validate(type,
> > - app_data->selector)) {
> > - err = -EINVAL;
> > - goto err;
> > - }
> > -
> > - if (ops->ieee_setapp)
> > - err = ops->ieee_setapp(netdev, app_data);
> > - else
> > - err = dcb_ieee_setapp(netdev, app_data);
> > - if (err)
> > - goto err;
> > - }
> > + err = dcbnl_apprewr_setdel(ieee[DCB_ATTR_IEEE_APP_TABLE],
> > + netdev, dcb_ieee_setapp,
> > + ops->ieee_setapp);
>
> This could pre-resolve the callback to use and pass one pointer:
>
> err = dcbnl_apprewr_setdel(ieee[DCB_ATTR_IEEE_APP_TABLE], netdev,
> ops->ieee_setapp ?: dcb_ieee_setapp);
Agreed.
Will make the suggested changes in v2 - thank you Petr.
/Daniel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-16 13:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 20:15 [PATCH net-next 0/6] Introduce new DCB rewrite table Daniel Machon
2023-01-12 20:15 ` [PATCH net-next 1/6] net: dcb: modify dcb_app_add to take list_head ptr as parameter Daniel Machon
2023-01-12 20:15 ` [PATCH net-next 2/6] net: dcb: add new common function for set/del of app/rewr entries Daniel Machon
2023-01-13 14:52 ` Petr Machata
2023-01-16 13:00 ` Daniel.Machon [this message]
2023-01-12 20:15 ` [PATCH net-next 3/6] net: dcb: add new rewrite table Daniel Machon
2023-01-13 7:04 ` Dan Carpenter
2023-01-16 12:52 ` Daniel.Machon
2023-01-13 15:51 ` Petr Machata
2023-01-12 20:15 ` [PATCH net-next 4/6] net: dcb: add helper functions to retrieve PCP and DSCP rewrite maps Daniel Machon
2023-01-12 20:15 ` [PATCH net-next 5/6] net: microchip: sparx5: add support for PCP rewrite Daniel Machon
2023-01-12 20:15 ` [PATCH net-next 6/6] net: microchip: sparx5: add support for DSCP rewrite Daniel Machon
2023-01-13 16:11 ` [PATCH net-next 0/6] Introduce new DCB rewrite table Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8VKWcqGEjPOvCQE@DEN-LT-70577 \
--to=daniel.machon@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=Julia.Lawall@inria.fr \
--cc=Lars.Povlsen@microchip.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).