From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Alexey V. Vissarionov" <gremlin@altlinux.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Jiri Slaby <jirislaby@kernel.org>,
Thomas Abraham <thomas.abraham@linaro.org>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH v2] serial: samsung: fix buffer size for clk_name
Date: Wed, 1 Feb 2023 14:06:29 +0100 [thread overview]
Message-ID: <Y9pj1Sx7Nzjkp6pw@kroah.com> (raw)
In-Reply-To: <20230201024457.GD446@altlinux.org>
On Wed, Feb 01, 2023 at 05:44:57AM +0300, Alexey V. Vissarionov wrote:
> serial: samsung: fix buffer size for clk_name
>
> Although very unlikely, the 'clk_num' value may be as big as
> 2**32 - 1 (uint32_max), so the buffer should have enough
> space for storing "clk_uart_baud4294967295\0".
> Also, the numbers in clk_name are expected to be unsigned.
>
> Found by ALT Linux Team (altlinux.org) and Linux Verification
> Center (linuxtesting.org) using SVACE.
>
> Signed-off-by: Alexey V. Vissarionov <gremlin@altlinux.org>
> Fixes: 5f5a7a5578c5 ("serial: samsung: switch to clkdev based clock lookup")
>
> ---
>
> On 2023-01-19 15:52:38 +0100, Greg Kroah-Hartman wrote:
>
> >> Fixes: 5f5a7a5578c58852 ("serial: samsung: switch to clkdev
> >> based clock lookup")
> > Please fix your scripts to use the proper number of SHA1 digits
> > in a Fixes: line as the documentation asks for.
>
> Done. Also added the comment to the source regarding the buffer size.
>
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 0fce856434dafd80..2c701dc7c6a37191 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -1407,7 +1407,7 @@ static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level,
> *
> */
>
> -#define MAX_CLK_NAME_LENGTH 15
> +#define MAX_CLK_NAME_LENGTH 24 /* "clk_uart_baud4294967295\0" */
>
> static inline int s3c24xx_serial_getsource(struct uart_port *port)
> {
> @@ -1457,7 +1457,7 @@ static unsigned int s3c24xx_serial_getclk(struct s3c24xx_uart_port *ourport,
> !(ourport->cfg->clk_sel & (1 << cnt)))
> continue;
>
> - sprintf(clkname, "clk_uart_baud%d", cnt);
> + sprintf(clkname, "clk_uart_baud%u", cnt);
So you bump the size of the buffer and continue to use an "unsafe" call
that could overflow the buffer? Is this a plan to submit a series of
patches all "fixing" something based on the last change? :)
As Krzysztof said, this whole thing is not needed at all. Please fix
your tool to generate valid changes.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-02-01 13:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 14:16 [PATCH] serial: samsung: fix buffer size for clk_name Alexey V. Vissarionov
2023-01-16 16:16 ` Krzysztof Kozlowski
2023-01-16 18:26 ` Alexey V. Vissarionov
2023-01-19 14:52 ` Greg Kroah-Hartman
2023-02-01 2:44 ` [PATCH v2] " Alexey V. Vissarionov
2023-02-01 7:09 ` Krzysztof Kozlowski
2023-02-01 13:06 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9pj1Sx7Nzjkp6pw@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alim.akhtar@samsung.com \
--cc=gremlin@altlinux.org \
--cc=jirislaby@kernel.org \
--cc=kgene.kim@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).