Linux-ARM-Kernel Archive on
 help / color / Atom feed
From: Tony Lindgren <>
To: Grygorii Strashko <>
Cc:, "Ivan J." <>,
Subject: Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
Date: Fri, 5 Feb 2021 16:46:35 +0200
Message-ID: <> (raw)
In-Reply-To: <>

* Grygorii Strashko <> [210205 14:25]:
> On 05/02/2021 15:30, Tony Lindgren wrote:
> > Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig
> > for the other cases that do not use KS8851?
> The KS8851 config was added like 10years ago and is used on some omap4 platforms,
> it does select MICREL_PHY.
> From other side, *some* am57x, am437 platforms uses MICREL PHYs with no dependency from KS8851.
> The omap2plus_defconfig is also used as base for custom configs and first thing people are doing -
> remove not needed options. As result, removal of KS8851 plus this patch will immediately
> cause MICREL_PHY=n and so breakage on existing and custom platforms.
> I do not see how it can be resolved by using Kconfig changes within much-omap2.
> So, sry, but NACK for this patch as it is.

We can wait on this patch no problem while we figure this out.
But certainly we need to fix things so make savedefconfig
produces valid configs that don't need to be manually edited.

> if some Kconfig dependencies need to be sorted out - probably the best way might be
> to get rid of select MICREL_PHY in KS8851/KS8851_MLL.

That will potentially break things too as the configs now expect
it to be selected :) Looks like that got changed with commit
f0791b92d2b6 ("net: ks8851: Select PHYLIB and MICREL_PHY in

So why can't we do similar patches to select MICREL_PHY for
the other non-ks8851 configurations in drivers/net/ethernet
Kconfig files as needed?



linux-arm-kernel mailing list

  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 11:34 [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Ivan Jelincic
2021-02-03 11:34 ` [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options Ivan Jelincic
2021-02-04  6:56   ` Tony Lindgren
2021-02-05 13:15     ` Grygorii Strashko
2021-02-05 13:17       ` Ivan J.
2021-02-05 13:30         ` Tony Lindgren
2021-02-05 14:25           ` Grygorii Strashko
2021-02-05 14:46             ` Tony Lindgren [this message]
2021-02-05 15:04               ` Grygorii Strashko
2021-02-06  7:23                 ` Tony Lindgren
2021-02-05 13:18 ` [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Grygorii Strashko
2021-02-05 13:33   ` Tony Lindgren
2021-02-05 14:01     ` Grygorii Strashko
  -- strict thread matches above, loose matches on Subject: below --
2021-01-26 12:21 [PATCH 1/2] ARM: omap2plus_defconfig: Update for moved options Tony Lindgren
2021-01-26 12:21 ` [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on

Archives are clonable:
	git clone --mirror linux-arm-kernel/git/0.git
	git clone --mirror linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ \
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone