From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC33CC433E0 for ; Fri, 5 Feb 2021 14:48:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FEFE64FFF for ; Fri, 5 Feb 2021 14:48:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FEFE64FFF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sQAVY9Tzlgwu/F801wpaEiJ0NeRTCY1JO7MopY323Wk=; b=XK0D7NWttf+6I0xm/woRFXGPG 3U8nTjzjqEi4ncUVtGYhKC8wYsYhMCR6ZqS5CGNMxgnYktmMxnNacNrU69q87FHAYESv4Qz2R69wn o9dhaTGqino3Fu7iV5VEw/Mn7k1JtzHWviPpdX8EjCmJ0x9jUoshZzNw1adV4LhW9SUQDzGdiLhrS FoUYP6omh/cRYrqtXn5mLPvJhH8/FRs0KR4Irc21qVqZAjtMQLxQh1tUy7G6ZkgmkP3pFzUu0t5Ve AhwkV3NT6wwgYutxwFo3l6ej+MEIbKShyBP4uRNVPyDg7dW8aFdge7vtJhQ5wUwCObH1kLeuoeB87 YwRvC6Kng==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l82Ni-0003iH-RI; Fri, 05 Feb 2021 14:46:46 +0000 Received: from muru.com ([72.249.23.125]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l82Nf-0003hh-UB for linux-arm-kernel@lists.infradead.org; Fri, 05 Feb 2021 14:46:44 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id BE64F8061; Fri, 5 Feb 2021 14:46:51 +0000 (UTC) Date: Fri, 5 Feb 2021 16:46:35 +0200 From: Tony Lindgren To: Grygorii Strashko Subject: Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options. Message-ID: References: <20210203113426.18964-1-parazyd@dyne.org> <20210203113426.18964-2-parazyd@dyne.org> <4b32f566-92ad-3c49-0453-b44df23f1384@ti.com> <20210205131736.3jivrc5lln4t2onr@fq> <8ab86ccf-7568-c173-75f6-0d572fd43fec@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8ab86ccf-7568-c173-75f6-0d572fd43fec@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210205_094644_035268_F46A4A10 X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-omap@vger.kernel.org, "Ivan J." , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Grygorii Strashko [210205 14:25]: > On 05/02/2021 15:30, Tony Lindgren wrote: > > Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig > > for the other cases that do not use KS8851? > > The KS8851 config was added like 10years ago and is used on some omap4 platforms, > it does select MICREL_PHY. > > From other side, *some* am57x, am437 platforms uses MICREL PHYs with no dependency from KS8851. > > The omap2plus_defconfig is also used as base for custom configs and first thing people are doing - > remove not needed options. As result, removal of KS8851 plus this patch will immediately > cause MICREL_PHY=n and so breakage on existing and custom platforms. > > I do not see how it can be resolved by using Kconfig changes within much-omap2. > > So, sry, but NACK for this patch as it is. We can wait on this patch no problem while we figure this out. But certainly we need to fix things so make savedefconfig produces valid configs that don't need to be manually edited. > if some Kconfig dependencies need to be sorted out - probably the best way might be > to get rid of select MICREL_PHY in KS8851/KS8851_MLL. That will potentially break things too as the configs now expect it to be selected :) Looks like that got changed with commit f0791b92d2b6 ("net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig"). So why can't we do similar patches to select MICREL_PHY for the other non-ks8851 configurations in drivers/net/ethernet Kconfig files as needed? Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel