From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9583C433E0 for ; Mon, 8 Feb 2021 13:22:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78B7C64E9C for ; Mon, 8 Feb 2021 13:22:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78B7C64E9C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hQV2LvDLy7akc5K0g/7CfY75l8ReX4OyyrZgjiAH6ag=; b=HXt3dZvgoutVC/Ipr1dhcxYpJ wvsdyd7y5rQzr+67QWosPD2/x4xst6O38fZHPiBxC5Qih65tiOiYtvd7YBFQWj/dzdRNaEvBl5F8H w3V7mUIczQcL10KUewfMJ9QVM3JX1GfAeFNUMO78ateZJaLjXCs9bd7imuV+wUUlaLWQIlgj5Ik48 BjUMyP1qvZIlK7zKmcui2056UF5zcSyU59PSKngTNMchF0q7dVX9iXacnYxHADlaYwvi/fC8XAvzZ IKdUcLwb+Ab6SSuG6SazndnKpCCirvuSwp+JxONahj1xZW6B2vLdcavLRwtxoXopCFQAz07+8H+KP TDDEO+HLg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l96TW-0005WC-9w; Mon, 08 Feb 2021 13:21:10 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l96TU-0005V9-5P for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2021 13:21:09 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1l96T5-004pOI-DF; Mon, 08 Feb 2021 14:20:43 +0100 Date: Mon, 8 Feb 2021 14:20:43 +0100 From: Andrew Lunn To: Samuel Holland Subject: Re: [PATCH] i2c: mv64xxx: Fix check for missing clock Message-ID: References: <20210208062859.11429-1-samuel@sholland.org> <20210208062859.11429-2-samuel@sholland.org> <4f696b13-2475-49f2-5d75-f2120e159142@sholland.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4f696b13-2475-49f2-5d75-f2120e159142@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_082108_225144_FCB9C641 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ondrej Jirman , Jernej Skrabec , Alexandre Torgue , netdev@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Jose Abreu , Corentin Labbe , Jakub Kicinski , Giuseppe Cavallaro , Dan Carpenter , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 08, 2021 at 12:31:34AM -0600, Samuel Holland wrote: > On 2/8/21 12:28 AM, Samuel Holland wrote: > > In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error > > pointers to optional clocks were replaced by NULL to simplify the resume > > callback implementation. However, that commit missed that the IS_ERR > > check in mv64xxx_of_config should be replaced with a NULL check. As a > > result, the check always passes, even for an invalid device tree. > > Sorry, please ignore this unrelated patch. I accidentally copied it to > the wrong directory before sending this series. Hi Samuel This patch looks correct. But i don't see it in i2c/for-next, where as e5c02cf54154 is. I just want to make sure it does not get lost... Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel