From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99588C433DB for ; Mon, 15 Feb 2021 06:08:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50B2664DFF for ; Mon, 15 Feb 2021 06:08:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50B2664DFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7nFH/NGRhyu2SMvCJIG1fDiYhtoUPbSQBSjCpGM1n74=; b=MvqWTSNL8L+ne0/nw/MmDIhK/ dQVsJBnoD+0kJRztPT7zfT1QmtYEMvCVCTfFD+xJqgpcMgypGWow0ItvQjRvAOq5PQkbexToG0yXi MDtaavqYJa6EbPNPq1D+JSUWSu16qBYFAeF7tkZa1BhqlA6SSA8HSjMM6G9N7zBQ+7SOsO/aG4e2K cfrE2kNABWmwxYlEAvGfaJ50rYkSIZSEWpcVWmdmvaNxbTW+TuA+KwJVk3h9uOmtm4eKwlI2t2NdL perRso/dttSZMUhgtXPAWnQMOvOMagdYc3rxU/y4nevjU3PZTvRrFGWE+tJHks6U8qst+/K49XpFU jL1kt7cSw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBX2f-00061v-5y; Mon, 15 Feb 2021 06:07:29 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBX2c-00061Y-8K for linux-arm-kernel@lists.infradead.org; Mon, 15 Feb 2021 06:07:26 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8C814600EF; Mon, 15 Feb 2021 06:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613369245; bh=CVEnXyLzFoecXT0I4kiqQUOnpqR8iRGl2uwpQ7E675E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d5+bDjC3P3EGQ13F5uheGen04hti1B0Kh6rM3RUu2pXmAOPKZcEjAyCJX7SoaeCaY YPJYYeASF6FOerTiOE8hAzC5ona5+A7brJTI3rBqP6wVxZtRg1b7C0VFkQRYKHUPAc ycLGtBXzARi0bhdgqGUR4onPekPYhY7wJYhYh82WRyx0UfC5DVAnwqWfR+eSX3Py3o EYS1VRhC3DASjKAN1fIk3K3W3iU7/8ZNWg38a3rbv5QHInPb5N/eRdIMpzSl9SxD+1 49tKg7ojMujHafBBvsUL+JbqpiFm2Z0z9acglFuzR7mDobuFfqpnOslK1e6ts5jocZ iYYdfnKnhNO7A== Date: Mon, 15 Feb 2021 08:07:21 +0200 From: Leon Romanovsky To: Nobuhiro Iwamatsu Subject: Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver Message-ID: References: <20210215050655.2532-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210215050655.2532-3-nobuhiro1.iwamatsu@toshiba.co.jp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210215050655.2532-3-nobuhiro1.iwamatsu@toshiba.co.jp> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210215_010726_368046_E7CA414D X-CRM114-Status: GOOD ( 18.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jose Abreu , punit1.agrawal@toshiba.co.jp, Alexandre Torgue , arnd@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Giuseppe Cavallaro , Jakub Kicinski , yuji2.ishikawa@toshiba.co.jp, "David S . Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 15, 2021 at 02:06:53PM +0900, Nobuhiro Iwamatsu wrote: > Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs. > This patch contains only the basic function of the device. There is no > clock control, PM, etc. yet. These will be added in the future. > > Signed-off-by: Nobuhiro Iwamatsu > --- > drivers/net/ethernet/stmicro/stmmac/Kconfig | 8 + > drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + > .../ethernet/stmicro/stmmac/dwmac-visconti.c | 285 ++++++++++++++++++ > 3 files changed, 294 insertions(+) > create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c > > diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig > index 53f14c5a9e02..55ba67a550b9 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig > +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig > @@ -219,6 +219,14 @@ config DWMAC_INTEL_PLAT > This selects the Intel platform specific glue layer support for > the stmmac device driver. This driver is used for the Intel Keem Bay > SoC. > + > +config DWMAC_VISCONTI > + bool "Toshiba Visconti DWMAC support" > + def_bool y I asked it before, but never received an answer. Why did you use "def_bool y" and not "default y"? Isn't it supposed to be "depends on STMMAC_ETH"? And probably it shouldn't be set as a default as "y". Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel