From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: kamel.bouhara@bootlin.com, gwendal@chromium.org,
a.fatoum@pengutronix.de, david@lechnology.com,
linux-iio@vger.kernel.org, patrick.havelange@essensium.com,
alexandre.belloni@bootlin.com, mcoquelin.stm32@gmail.com,
linux-kernel@vger.kernel.org, o.rempel@pengutronix.de,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
fabrice.gasnier@st.com, syednwaris@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
Jonathan Cameron <jic23@kernel.org>,
alexandre.torgue@st.com
Subject: Re: [PATCH v8 18/22] docs: counter: Document character device interface
Date: Fri, 26 Feb 2021 09:27:19 +0900 [thread overview]
Message-ID: <YDhAZ5bQ9fqd3FWB@shinobu> (raw)
In-Reply-To: <20210222101133.GB14587@amd>
[-- Attachment #1.1: Type: text/plain, Size: 2548 bytes --]
On Mon, Feb 22, 2021 at 11:11:33AM +0100, Pavel Machek wrote:
> Hi!
>
> > > +* COUNTER_ENABLE_EVENTS_IOCTL:
> > > + Enables monitoring the events specified by the Counter watches that
> > > + were queued by ``COUNTER_ADD_WATCH_IOCTL``. If events are already
> > > + enabled, the new set of watches replaces the old one. Calling this
> > > + ioctl also has the effect of clearing the queue of watches added by
> > > + ``COUNTER_ADD_WATCH_IOCTL``.
> > > +
> > > +* COUNTER_DISABLE_EVENTS_IOCTL:
> > > + Stops monitoring the previously enabled events.
> >
> > Is there a way to remove a watch?
>
> Is there a way to eat all kernel memory and crash the system by adding
> too many watches?
There can only ever be as many watches as there are Counter components
for the respective Counter device. This is enforced by
counter_set_event_node() which checks whether a particular watch has
been created before and returns an EINVAL if it so has.
> > > +For example, the following userspace code opens ``/dev/counter0``,
> > > +configures the ``COUNTER_EVENT_INDEX`` event channel 0 to gather Count 0
> > > +and Count 1, and prints out the data as it becomes available on the
> > > +character device node::
> > > +
> >
> > Consider adding an example program under tools/
> >
> > > + #include <fcntl.h>
> > > + #include <linux/counter.h>
> > > + #include <stdio.h>
> > > + #include <string.h>
> > > + #include <sys/ioctl.h>
> > > + #include <unistd.h>
> > > +
> > > + struct counter_watch watches[2] = {
> > > + {
> > > + .component.type = COUNTER_COMPONENT_COUNT,
> > > + .component.scope = COUNTER_SCOPE_COUNT,
> > > + .component.parent = 0,
> >
> > Good to add comments on what these elements actually are?
>
> > > + fd = open("/dev/counter0", O_RDWR);
> > > +
> > > + ioctl(fd, COUNTER_ADD_WATCH_IOCTL, watches);
> > > + ioctl(fd, COUNTER_ADD_WATCH_IOCTL, watches + 1);
> > > + ioctl(fd, COUNTER_ENABLE_EVENTS_IOCTL);
>
> > > + for (;;) {
> > > + read(fd, event_data, sizeof(event_data));
>
> If this goes to tools it really should have error handling and
> handling of short read.
>
> Best regards,
> Pavel
>
> --
> http://www.livejournal.com/~pavelmachek
Ack. I'll improve the error handling for this.
William Breathitt Gray
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-26 0:29 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 12:13 [PATCH v8 00/22] Introduce the Counter character device interface William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 01/22] docs: counter: Consolidate Counter sysfs attributes documentation William Breathitt Gray
2021-02-14 16:57 ` Jonathan Cameron
2021-02-15 11:05 ` William Breathitt Gray
2021-02-20 16:25 ` David Lechner
2021-02-12 12:13 ` [PATCH v8 02/22] docs: counter: Fix spelling William Breathitt Gray
2021-02-20 16:26 ` David Lechner
2021-02-12 12:13 ` [PATCH v8 03/22] counter: 104-quad-8: Return error when invalid mode during ceiling_write William Breathitt Gray
2021-02-20 16:30 ` David Lechner
2021-02-22 2:06 ` William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 04/22] counter: 104-quad-8: Annotate hardware config module parameter William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 05/22] counter: 104-quad-8: Add const qualifiers for quad8_preset_register_set William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 06/22] counter: 104-quad-8: Add const qualifier for functions_list array William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 07/22] counter: 104-quad-8: Add const qualifier for actions_list array William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 08/22] counter: ftm-quaddec: " William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 09/22] counter: Return error code on invalid modes William Breathitt Gray
2021-02-14 17:07 ` Jonathan Cameron
2021-02-20 16:43 ` David Lechner
2021-02-22 4:42 ` William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 10/22] counter: Standardize to ERANGE for limit exceeded errors William Breathitt Gray
2021-02-14 17:10 ` Jonathan Cameron
2021-02-16 1:26 ` William Breathitt Gray
2021-02-21 14:03 ` Jonathan Cameron
2021-02-20 16:48 ` David Lechner
2021-02-12 12:13 ` [PATCH v8 11/22] counter: Rename counter_signal_value to counter_signal_level William Breathitt Gray
2021-02-20 16:52 ` David Lechner
2021-02-12 12:13 ` [PATCH v8 12/22] counter: Rename counter_count_function to counter_function William Breathitt Gray
2021-02-14 17:13 ` Jonathan Cameron
2021-02-20 16:56 ` David Lechner
2021-02-23 5:14 ` William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 14/22] counter: Update counter.h comments to reflect sysfs internalization William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 15/22] docs: counter: Update " William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 16/22] counter: Move counter enums to uapi header William Breathitt Gray
2021-02-20 23:55 ` David Lechner
2021-02-12 12:13 ` [PATCH v8 17/22] counter: Add character device interface William Breathitt Gray
2021-02-14 18:06 ` Jonathan Cameron
2021-02-24 5:34 ` William Breathitt Gray
2021-02-15 9:24 ` Oleksij Rempel
2021-02-16 1:53 ` William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 18/22] docs: counter: Document " William Breathitt Gray
2021-02-14 17:48 ` Jonathan Cameron
2021-02-22 10:11 ` Pavel Machek
2021-02-26 0:27 ` William Breathitt Gray [this message]
2021-02-26 0:22 ` William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 19/22] counter: Implement extension*_name sysfs attributes William Breathitt Gray
2021-02-14 18:09 ` Jonathan Cameron
2021-02-19 8:51 ` William Breathitt Gray
2021-02-21 14:05 ` Jonathan Cameron
2021-02-25 23:32 ` William Breathitt Gray
2021-02-27 15:14 ` Jonathan Cameron
2021-02-12 12:13 ` [PATCH v8 20/22] counter: Implement events_queue_size sysfs attribute William Breathitt Gray
2021-02-14 18:11 ` Jonathan Cameron
2021-02-18 10:32 ` William Breathitt Gray
2021-02-21 15:51 ` Jonathan Cameron
2021-02-26 0:03 ` William Breathitt Gray
2021-02-27 0:14 ` David Lechner
2021-02-27 0:20 ` William Breathitt Gray
2021-02-27 15:18 ` Jonathan Cameron
2021-02-28 2:46 ` William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 21/22] counter: 104-quad-8: Replace mutex with spinlock William Breathitt Gray
2021-02-14 18:19 ` Jonathan Cameron
2021-02-16 2:16 ` William Breathitt Gray
2021-02-16 19:27 ` Jonathan Cameron
2021-02-18 10:16 ` William Breathitt Gray
2021-02-12 12:13 ` [PATCH v8 22/22] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 William Breathitt Gray
2021-02-14 18:24 ` Jonathan Cameron
2021-02-19 9:21 ` William Breathitt Gray
[not found] ` <3fc2580af0efd6312a64a0e107bd6fa758f0d466.1613131238.git.vilhelm.gray@gmail.com>
2021-02-14 17:32 ` [PATCH v8 13/22] counter: Internalize sysfs interface code Jonathan Cameron
2021-02-20 17:50 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDhAZ5bQ9fqd3FWB@shinobu \
--to=vilhelm.gray@gmail.com \
--cc=a.fatoum@pengutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=david@lechnology.com \
--cc=fabrice.gasnier@st.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=kamel.bouhara@bootlin.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=patrick.havelange@essensium.com \
--cc=pavel@ucw.cz \
--cc=syednwaris@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).