From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E6BC433E6 for ; Mon, 1 Mar 2021 11:32:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A9C26146B for ; Mon, 1 Mar 2021 11:32:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A9C26146B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uS1YsSliPUt/PErXFla5SPAuK802iwFuFdcCJ4+8WUc=; b=zUncL+PbxmdMu9OD13oFb5/ve lFbxJp1R3AO39RBnx8clCAyZn7RNYPezbHyz/fSDcehRhXUv7eWZpOdN/AOqzI7Ap3toJMBxVZT2C BsMKBZFAe49IlIXoaI6tYfsL7EcNf4mbYENa/wgi/XxQxM1l0NEczwp1W+TnSSLrcGS2dnYBQV5M3 Upqo9xPKI3/ngyM09U3lyLjHalMb2IGPMpgrLVtAqFyIcv9ubzIpBHB/kYhKo5Wg81u6yGUKmEq4j YDlobn+Ici9bijI8BH39Kb12DOe9F4ux9qKQnMIRBzLV8DiQXvyAh7Y7Vokr+f9ZyA/2CYmYt/f3+ YPfzu0SIg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lGglM-0000PM-Bl; Mon, 01 Mar 2021 11:30:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lGglI-0000Om-Vs for linux-arm-kernel@lists.infradead.org; Mon, 01 Mar 2021 11:30:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9757C64E22; Mon, 1 Mar 2021 11:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614598252; bh=XJHueoW65vLj+4kVOT6u/yTzg+bSjpuQ9NtCeZkqWGc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EE4LqhTL0kSe1iVAk++5zkvFgXmp//BQRPuzNsxqY8miqRT2Q0wLWzHggHaaQZ4CR 9BW1BjOOfa5XTDzT+xyTN0j9uhXCWobMGzcRUNi4Jo6BcmlWbaa9+D3FC5KVC8un3N yF0bTRD5neVc+YxhDpu5KDuAbR1BNqTsUTz+4dbw= Date: Mon, 1 Mar 2021 12:30:49 +0100 From: Greg KH To: huangshaobo Subject: Re: [PATCH 4.4.y] arm: kprobes: Allow to handle reentered kprobe on single-stepping Message-ID: References: <20210227091701.23944-1-huangshaobo6@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210227091701.23944-1-huangshaobo6@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210301_063053_529640_C1383977 X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tixy@linaro.org, young.liuyang@huawei.com, linux@arm.linux.org.uk, liucheng32@huawei.com, kepler.chenxin@huawei.com, xiaoqian9@huawei.com, linux-kernel@vger.kernel.org, zengweilin@huawei.com, mhiramat@kernel.org, chenzefeng2@huawei.com, nixiaoming@huawei.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 27, 2021 at 05:17:01PM +0800, huangshaobo wrote: > From: Masami Hiramatsu > > commit f3fbd7ec62dec1528fb8044034e2885f2b257941 upstream > > This is arm port of commit 6a5022a56ac3 ("kprobes/x86: Allow to > handle reentered kprobe on single-stepping") > > Since the FIQ handlers can interrupt in the single stepping > (or preparing the single stepping, do_debug etc.), we should > consider a kprobe is hit in the NMI handler. Even in that > case, the kprobe is allowed to be reentered as same as the > kprobes hit in kprobe handlers > (KPROBE_HIT_ACTIVE or KPROBE_HIT_SSDONE). > > The real issue will happen when a kprobe hit while another > reentered kprobe is processing (KPROBE_REENTER), because > we already consumed a saved-area for the previous kprobe. > > Signed-off-by: Masami Hiramatsu > Signed-off-by: Jon Medhurst > Fixes: 24ba613c9d6c ("ARM kprobes: core code") > Cc: stable@vger.kernel.org #v2.6.25~v4.11 > Signed-off-by: huangshaobo > --- > arch/arm/probes/kprobes/core.c | 6 ++++++ > 1 file changed, 6 insertions(+) What about the 4.9.y tree as well? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel