From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D84CEC433E0 for ; Mon, 15 Mar 2021 12:19:33 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50B0664E76 for ; Mon, 15 Mar 2021 12:19:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50B0664E76 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tLVSm6BuEEILGugd7qDNlvTcn21FF8ZzGs0GwH6Jtig=; b=mvgx/vWPZPLFIIOQpd0oJBO+w 9CthKldFxFk4j285KYij7JxgbJZiPMfGQxEOjImmo+VF4UtRpTXMsCo7lCYNpBk+vXxJDOFaIbROt ZXNXFU29K5+L6lL5QfIG5pYOPZFF7C9l2qZo0JwUvzJ/0nRcbhg1ZaLHSikXnJFrRIX+xDlib3ZKe Mt/YNQv672YQzvjFRUew2wOh37a/3wwwsMw3H3yk4LClOoaxoIPyijvmbRzzvBRufG6a3NJG5Vat/ uvop82u50gjOXANw7uCnrR+RTCg2ezVgwE1C6axOvZAZWlIESqAnhZjHIS4hnY0RbEdkxOTsRpa+q hkba2MeYw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLmAG-00FpZH-Jx; Mon, 15 Mar 2021 12:17:40 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLm1E-00FmV2-6p for linux-arm-kernel@lists.infradead.org; Mon, 15 Mar 2021 12:08:29 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lLm1A-00B6Bw-Sf; Mon, 15 Mar 2021 13:08:16 +0100 Date: Mon, 15 Mar 2021 13:08:16 +0100 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Marek =?iso-8859-1?Q?Beh=FAn?= , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Message-ID: References: <20210308153703.23097-1-kabel@kernel.org> <20210308153703.23097-4-kabel@kernel.org> <87czw4kath.fsf@BL-laptop> <20210312101027.1997ec75@kernel.org> <20210312161704.5e575906@kernel.org> <20210315101454.dpyfdwk43poirxlw@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210315101454.dpyfdwk43poirxlw@pali> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210315_120820_679843_426DFDDA X-CRM114-Status: GOOD ( 18.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 15, 2021 at 11:14:54AM +0100, Pali Roh=E1r wrote: > On Friday 12 March 2021 16:53:32 Andrew Lunn wrote: > > > So theoretically the turris-mox-rwtm driver can be renamed into > > > something else and we can add a different compatible in order not to > > > sound so turris-mox specific. > > = > > That would be a good idea. And if possible, try to push the hardware > > random number code upstream in the firmware repos, so everybody gets > > it by default, not just those using your build. Who is responsible for > > upstream? Marvell? > > = > > Andrew > = > Hello Andrew! > = > I do not think that renaming driver is the best option. For future it > would complicate backporting patches to stable kernel and also it would > make usage of 'gitk' harder as this tool cannot automatically track file > renames. Hi Pali I'm not suggesting renaming the .c file. What would be good is to add additional compatible strings. Add a more generic compatible. What goes into the .dtsi should use the generic name. Also, the node names should also be generic, since the node name is probably not used anywhere, just the compatible string. Keep the current compatible in the driver, for backwards compatibility with older DT blobs. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel