From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Gon Solo <gonsolo@gmail.com>
Cc: John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Leo Yan <leo.yan@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Perf: Clean generated directory, other archs.
Date: Sat, 6 Mar 2021 16:28:22 -0300 [thread overview]
Message-ID: <YEPX1oaV6vz5FW05@kernel.org> (raw)
In-Reply-To: <20210303183247.217385-1-gonsolo@gmail.com>
Em Wed, Mar 03, 2021 at 07:32:46PM +0100, Gon Solo escreveu:
You forgot to add an explanation here and to add your:
Signed-off-by: Gon Solo <gonsolo@gmail.com>
In this case a:
Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org>
Is also appropriate, since I pointed you in this direction.
Please take a look at:
Documentation/process/submitting-patches.rst
Direct link for your convenience:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst
Thanks for working on this!
- Arnaldo
> ---
> tools/perf/arch/arm64/Makefile | 5 +++--
> tools/perf/arch/powerpc/Makefile | 5 +++--
> tools/perf/arch/s390/Makefile | 5 +++--
> 3 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/arch/arm64/Makefile b/tools/perf/arch/arm64/Makefile
> index fab3095fb5d0..426aecdd0b71 100644
> --- a/tools/perf/arch/arm64/Makefile
> +++ b/tools/perf/arch/arm64/Makefile
> @@ -10,7 +10,8 @@ HAVE_KVM_STAT_SUPPORT := 1
> # Syscall table generation for perf
> #
>
> -out := $(OUTPUT)arch/arm64/include/generated/asm
> +generated := $(OUTPUT)arch/arm64/include/generated
> +out := $(generated)/asm
> header := $(out)/syscalls.c
> incpath := $(srctree)/tools
> sysdef := $(srctree)/tools/arch/arm64/include/uapi/asm/unistd.h
> @@ -24,6 +25,6 @@ $(header): $(sysdef) $(systbl)
> $(Q)$(SHELL) '$(systbl)' '$(CC)' '$(HOSTCC)' $(incpath) $(sysdef) > $@
>
> clean::
> - $(call QUIET_CLEAN, arm64) $(RM) $(header)
> + $(call QUIET_CLEAN, arm64) $(RM) -r $(header) $(generated)
>
> archheaders: $(header)
> diff --git a/tools/perf/arch/powerpc/Makefile b/tools/perf/arch/powerpc/Makefile
> index 840ea0e59287..979c2bebc167 100644
> --- a/tools/perf/arch/powerpc/Makefile
> +++ b/tools/perf/arch/powerpc/Makefile
> @@ -11,7 +11,8 @@ PERF_HAVE_JITDUMP := 1
> # Syscall table generation for perf
> #
>
> -out := $(OUTPUT)arch/powerpc/include/generated/asm
> +generated := $(OUTPUT)arch/powerpc/include/generated
> +out := $(generated)/asm
> header32 := $(out)/syscalls_32.c
> header64 := $(out)/syscalls_64.c
> sysprf := $(srctree)/tools/perf/arch/powerpc/entry/syscalls
> @@ -28,6 +29,6 @@ $(header32): $(sysdef) $(systbl)
> $(Q)$(SHELL) '$(systbl)' '32' $(sysdef) > $@
>
> clean::
> - $(call QUIET_CLEAN, powerpc) $(RM) $(header32) $(header64)
> + $(call QUIET_CLEAN, powerpc) $(RM) -r $(header32) $(header64) $(generated)
>
> archheaders: $(header32) $(header64)
> diff --git a/tools/perf/arch/s390/Makefile b/tools/perf/arch/s390/Makefile
> index 74bffbea03e2..27cf67f1cc78 100644
> --- a/tools/perf/arch/s390/Makefile
> +++ b/tools/perf/arch/s390/Makefile
> @@ -10,7 +10,8 @@ PERF_HAVE_JITDUMP := 1
> # Syscall table generation for perf
> #
>
> -out := $(OUTPUT)arch/s390/include/generated/asm
> +generated := $(OUTPUT)arch/s390/include/generated
> +out := $(generated)/asm
> header := $(out)/syscalls_64.c
> sysprf := $(srctree)/tools/perf/arch/s390/entry/syscalls
> sysdef := $(sysprf)/syscall.tbl
> @@ -23,6 +24,6 @@ $(header): $(sysdef) $(systbl)
> $(Q)$(SHELL) '$(systbl)' $(sysdef) > $@
>
> clean::
> - $(call QUIET_CLEAN, s390) $(RM) $(header)
> + $(call QUIET_CLEAN, s390) $(RM) -r $(header) $(generted)
>
> archheaders: $(header)
> --
> 2.27.0
>
--
- Arnaldo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-06 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 18:32 [PATCH 1/2] Perf: Clean generated directory, other archs Gon Solo
2021-03-06 19:28 ` Arnaldo Carvalho de Melo [this message]
2021-03-07 10:19 Gon Solo
2021-03-25 12:40 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEPX1oaV6vz5FW05@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=gonsolo@gmail.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).