From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B1D5C433DB for ; Fri, 26 Mar 2021 06:59:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2C81619CB for ; Fri, 26 Mar 2021 06:59:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2C81619CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qbglLIi0+Pw+d1s+RWmRmzfGJrtKPTBVcqhM9w+Nvss=; b=qWbyZVPScSDTuaMSl+OIuyN/b 8ZJcI/wd+GyUVEir1IlS2Kbe4BNEMn79i+xRQYEz5Yz4IwOrarilJ63vAc1qsgt6/FasPMluJGqNr oqFzRRxjHRLzvCWWgZY+8hnFQD1V7ScHqDQzFFonhjQRFIRSZ2WTTGdHjhwv56sVVGzq/R3EX8z6h 4zhCI/iNEYzGKmCrLqroSnS9SEbZYdt1m4l1p5QLWkU26tXTg4KoIPqMuEFp69s6Kxg2ekXPm1vzC 4flOP+LHRmJXjr+joA6GMXc6gb7NDhHBvVTGytObTd0LCDyUDs6whXtN0k+Rga8NmR8rsX1ZF3fG8 4nWBzf1+g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPgQ4-002vUf-Gy; Fri, 26 Mar 2021 06:58:08 +0000 Received: from mail-lj1-f177.google.com ([209.85.208.177]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPgQ1-002vUC-3B for linux-arm-kernel@lists.infradead.org; Fri, 26 Mar 2021 06:58:07 +0000 Received: by mail-lj1-f177.google.com with SMTP id r20so6212834ljk.4 for ; Thu, 25 Mar 2021 23:58:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y2qrP/+7Eqq1r7Y1EufmGR7ispG9hVe1quq8g3HloPA=; b=LxDeKtYBfIROxi7/Rf4rpqtYQsLGMuAnWp8+maihp+Sd8UWKKgqbAKP8zhneMXeqzY dxcV65cVncOsic60FtoQnvxEvkpEZCMQfwhiXY+cKPSsmjj/n3MNoNXA+Du2VFVjcCzF 0aovZL2yL1ROHN6d2DOXN+7OEMTAsWjkRfgTa2a6+Dlm7GtMQ2yBBTFsRzxC84UMdaJF nW/iVCnWgmirpS/BkC/N1wJ1kbBgd4NCcaqnCVgUGzIE0Dlz+fCPu1HuOMn0Hc7kBKvn 8uUVPlQpihJlPzNizgQnrptMMafiBkjdBggd7Aifz+30VK0Mv9GtQNRiz436qrNrFpMC ET8Q== X-Gm-Message-State: AOAM530F+FnLUTLg7umcu6AnKYtieDitcU+9oc+4XdH1qvIumS6AcI19 Nkxv+wo+yy9spwE8TWWv3hE= X-Google-Smtp-Source: ABdhPJyGi+WicJuhZegLet4p9d7lsO+uyChxmo2YFW1S9ebzuMxKHTKCHZvWdS7GKDzZnDsg4S3obQ== X-Received: by 2002:a2e:2c0d:: with SMTP id s13mr7893263ljs.105.1616741883666; Thu, 25 Mar 2021 23:58:03 -0700 (PDT) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id y16sm191038lfy.252.2021.03.25.23.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 23:58:02 -0700 (PDT) Date: Fri, 26 Mar 2021 07:58:01 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Kishon Vijay Abraham I Cc: Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Marc Zyngier , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lokesh Vutla Subject: Re: [PATCH 4/6] PCI: keystone: Convert to using hierarchy domain for legacy interrupts Message-ID: References: <20210325090026.8843-1-kishon@ti.com> <20210325090026.8843-5-kishon@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210325090026.8843-5-kishon@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_065805_218345_65320AA1 X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Kishon, Thank you for sending the series over! A few small nitpick, so feel free to ignore it. [...] > + ret = irq_domain_alloc_irqs_parent(domain, virq, 1, &parent_fwspec); > + if (ret < 0) { > + pr_err("Failed to allocate parent irq %u: %d\n", > + parent_fwspec.param[0], ret); > + return ret; [...] Use "IRQ" in the message above. Also, the error messages with both starting with upper- and lower- case letter, not sure if this is because of dev_err() vs pr_err(), but if there is no significance between these two methods, then it might be nice to keep the style consistent. Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel