* [PATCH v2 -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize()
@ 2021-04-07 13:25 YueHaibing
2021-04-08 9:56 ` Ludovic.Desroches
2021-04-20 10:32 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2021-04-07 13:25 UTC (permalink / raw)
To: ludovic.desroches, tudor.ambarus, vkoul, eugen.hristev
Cc: linux-arm-kernel, dmaengine, linux-kernel, YueHaibing
commit 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part")
left behind this, so can remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
v2: Fix commit log
---
drivers/dma/at_xdmac.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index fe45ad5d06c4..64a52bf4d737 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -344,17 +344,6 @@ static inline int at_xdmac_chan_is_paused(struct at_xdmac_chan *atchan)
return test_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status);
}
-static inline int at_xdmac_csize(u32 maxburst)
-{
- int csize;
-
- csize = ffs(maxburst) - 1;
- if (csize > 4)
- csize = -EINVAL;
-
- return csize;
-};
-
static inline bool at_xdmac_chan_is_peripheral_xfer(u32 cfg)
{
return cfg & AT_XDMAC_CC_TYPE_PER_TRAN;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize()
2021-04-07 13:25 [PATCH v2 -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize() YueHaibing
@ 2021-04-08 9:56 ` Ludovic.Desroches
2021-04-20 10:32 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Ludovic.Desroches @ 2021-04-08 9:56 UTC (permalink / raw)
To: yuehaibing
Cc: Tudor.Ambarus, vkoul, Eugen.Hristev, linux-arm-kernel, dmaengine,
linux-kernel
On Wed, Apr 07, 2021 at 09:25:43PM +0800, YueHaibing wrote:
>
> commit 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part")
> left behind this, so can remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Thanks for the cleanup.
Regards,
Ludovic
> ---
> v2: Fix commit log
> ---
> drivers/dma/at_xdmac.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index fe45ad5d06c4..64a52bf4d737 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -344,17 +344,6 @@ static inline int at_xdmac_chan_is_paused(struct at_xdmac_chan *atchan)
> return test_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status);
> }
>
> -static inline int at_xdmac_csize(u32 maxburst)
> -{
> - int csize;
> -
> - csize = ffs(maxburst) - 1;
> - if (csize > 4)
> - csize = -EINVAL;
> -
> - return csize;
> -};
> -
> static inline bool at_xdmac_chan_is_peripheral_xfer(u32 cfg)
> {
> return cfg & AT_XDMAC_CC_TYPE_PER_TRAN;
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize()
2021-04-07 13:25 [PATCH v2 -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize() YueHaibing
2021-04-08 9:56 ` Ludovic.Desroches
@ 2021-04-20 10:32 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-04-20 10:32 UTC (permalink / raw)
To: YueHaibing
Cc: ludovic.desroches, tudor.ambarus, eugen.hristev,
linux-arm-kernel, dmaengine, linux-kernel
On 07-04-21, 21:25, YueHaibing wrote:
> commit 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part")
> left behind this, so can remove it.
Applied, thanks
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-20 10:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 13:25 [PATCH v2 -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize() YueHaibing
2021-04-08 9:56 ` Ludovic.Desroches
2021-04-20 10:32 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).