From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Yicong Yang <yangyicong@hisilicon.com>,
Wei Xu <xuwei5@hisilicon.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Dmitry Osipenko <digetx@gmail.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI
Date: Tue, 13 Apr 2021 15:36:57 +0300 [thread overview]
Message-ID: <YHWQaQaw53eZtYzn@smile.fi.intel.com> (raw)
In-Reply-To: <26db9291095c1dfd81c73b0f5f1434f9b399b1f5.1618316565.git.geert+renesas@glider.be>
On Tue, Apr 13, 2021 at 02:26:15PM +0200, Geert Uytterhoeven wrote:
> The HiSilicon Kunpeng I2C controller is only present on HiSilicon
> Kunpeng SoCs, and its driver relies on ACPI to probe for its presence.
> Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user
> about this driver when configuring a kernel without Hisilicon platform
> or ACPI firmware support.
I don't by the ACPI dependency, sorry.
The driver is a pure platform driver that can be enumerated on ACPI enabled
devices, but otherwise it can be used as a platform one.
If you remove ACPI dependency, feel free to add my
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/i2c/busses/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index b5b4e0d0ff4dd0bc..3ead6d9e130b2ebc 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -647,7 +647,7 @@ config I2C_HIGHLANDER
>
> config I2C_HISI
> tristate "HiSilicon I2C controller"
> - depends on ARM64 || COMPILE_TEST
> + depends on (ARM64 && ARCH_HISI && ACPI) || COMPILE_TEST
> help
> Say Y here if you want to have Hisilicon I2C controller support
> available on the Kunpeng Server.
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-13 12:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 12:26 [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI Geert Uytterhoeven
2021-04-13 12:36 ` Andy Shevchenko [this message]
2021-04-13 12:48 ` Geert Uytterhoeven
2021-04-13 14:41 ` Andy Shevchenko
2021-04-13 14:44 ` Geert Uytterhoeven
2021-04-13 15:19 ` Andy Shevchenko
2021-04-14 9:19 ` Yicong Yang
2021-04-14 18:06 ` Geert Uytterhoeven
2021-04-14 18:18 ` Andy Shevchenko
2021-04-14 18:55 ` Geert Uytterhoeven
2021-04-14 19:14 ` Andy Shevchenko
2021-04-14 19:21 ` Geert Uytterhoeven
2021-04-15 8:50 ` Andy Shevchenko
2021-04-19 13:02 ` Geert Uytterhoeven
2021-04-19 13:31 ` Andy Shevchenko
2021-04-19 13:54 ` Geert Uytterhoeven
2021-04-19 13:58 ` Andy Shevchenko
2021-04-19 14:14 ` Andy Shevchenko
2021-04-19 14:18 ` Geert Uytterhoeven
2021-04-19 14:27 ` Andy Shevchenko
2021-04-19 14:15 ` Geert Uytterhoeven
2021-04-19 14:39 ` Andy Shevchenko
2021-04-15 8:18 ` Yicong Yang
2021-04-15 9:04 ` Yicong Yang
2021-04-15 10:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHWQaQaw53eZtYzn@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=digetx@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=xuwei5@hisilicon.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).