From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24FAFC43460 for ; Tue, 13 Apr 2021 14:44:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E400D613AB for ; Tue, 13 Apr 2021 14:44:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E400D613AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JIjeOumkqaZeYzzwob1PQsLDzBoSrx3kXYPXciagqiw=; b=i6VnazYHeQ5Gkk4mv/bVTZxjp 1fSgiV3A6RWGIIy9fLt1BWIfiYI2Cyzd0PijSpsYLQsX0txjdCOpJuiKJpno2l/4k72j6WOUG/2nQ BT3Uln1yvDwXDg1xslAcX8BFS1XIe6+Du9hfnA1YiK/2Uyd2QcvYgq3fg8YBnPPm4zGgTqadtiGLB WbORrlYA6j4p+CLZNn1h1bb3fwg1dAnDAQF2TtKhVZH/GeQb2xJ1avtjEhsc4eqUi6OkNGlKH4p8l UuNlALh3FFLO/KH2IDHJHdBYISO3dEHLNUDxjG3R50McwTG9ebkCa9Q5bA13IeXoEkveaadu2zBOY FSlWNy+wQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWKFY-009XiI-Ux; Tue, 13 Apr 2021 14:42:45 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWKEe-009XY7-KO for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 14:41:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZSMGNfJkXHXkux8QOUmyVlK01Zpe4K8GoueCkwJLfj8=; b=BkVFSoc0xAXMh9YSddsR4tC06P oDwb44k4UvXn+xAsAUr6iL0XpYSwLfLJ3Dht6+X01XqeFWF97fmyuWhRCZ4bGUYFVJSieXq4xLEKf ZpS7FW5n7WP66j5dgjd6JSUehsk9jfwUsaD+vmIjcFWhOPG2/+F1n7qVswd66iiXNOpVZFxgFDPfT mNHCgJIgK3X5XyGsPad+LdkL2DtwL4zoj/7mJckLA4/UYbn9to6uJ/34KZd541UUXGvlt76QVv1np 6Lwu31+UgnzIHDav4XFQI+r+s4FbJld5+81W+sxnISotWumn+sdOt9Epxlhc/VJfVv01HPNtOyZpq lENnZBnQ==; Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWKEb-00770I-Q4 for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 14:41:47 +0000 IronPort-SDR: nYbRRudHn9vRzjHt1KLKo5iPQ3LoYqVDwzp/9cxVorS7xeCnP8tIqpAj+6ybHZTmg9BSnfJNHg la2h5fWuf6gw== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="181941006" X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="181941006" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 07:41:35 -0700 IronPort-SDR: BHBROY0G8Rf5UwPmEOHL3w+0AYNLRlRk4f1J/QWb5YQwi0g304cW8aRWaqSUilie2N4P2HB68P 1vbxZUsjBqrg== X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="521619792" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 07:41:33 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lWKEK-003mj2-JO; Tue, 13 Apr 2021 17:41:28 +0300 Date: Tue, 13 Apr 2021 17:41:28 +0300 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Yicong Yang , Wei Xu , Wolfram Sang , Dmitry Osipenko , Linux I2C , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI Message-ID: References: <26db9291095c1dfd81c73b0f5f1434f9b399b1f5.1618316565.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_074145_921562_26CB5020 X-CRM114-Status: GOOD ( 21.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 13, 2021 at 02:48:15PM +0200, Geert Uytterhoeven wrote: > On Tue, Apr 13, 2021 at 2:37 PM Andy Shevchenko > wrote: > > On Tue, Apr 13, 2021 at 02:26:15PM +0200, Geert Uytterhoeven wrote: > > > The HiSilicon Kunpeng I2C controller is only present on HiSilicon > > > Kunpeng SoCs, and its driver relies on ACPI to probe for its presence. > > > Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user > > > about this driver when configuring a kernel without Hisilicon platform > > > or ACPI firmware support. > > > > I don't by the ACPI dependency, sorry. > > > > The driver is a pure platform driver that can be enumerated on ACPI enabled > > devices, but otherwise it can be used as a platform one. > > Sure, you can manually instantiate a platform device with a matching > name, and set up the "clk_rate" device property. > But would it make sense to do that? Would anyone ever do that? It will narrow down the possibility to have One Kernel for as many as possible platforms. > The corresponding SPI_HISI_KUNPENG depends on ACPI, too. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel