From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2711C433ED for ; Wed, 21 Apr 2021 13:19:11 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8080E6144B for ; Wed, 21 Apr 2021 13:19:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8080E6144B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cgoi/cB8hOgja+3EGnZYO02JdWVx5bSLC2g9lzVWHV4=; b=ls1fBsgkI44JUo/mKG7ptvG5u dlHxhZMnmwkbBfAKVYcwfdaMDrxIU7w+Vnq8MKQaWViqEb8SRXsrYyIgqqlNYQO5v746RCvFAKpry ht5f7Pa7Dt0zZI57+EL8lxUt2M2Z+NG5WwC5YlCTbQij0WC6lMSCf5/u7ruc6ImFqSM+qTO3iT+gh cElwtfabL7ezqRoXlK75ZKS2i3GcQwuI/qwp9Wt1bzXxh4SnJbl53UWH3wWki0nR4m8l67nqCitBf HatpTHS5MuKEpBSzXHyOdqrpbnhe5vAjANhkDCXMEr3JwEQbdS1o2SP5s0MzT/sAXPrKyuhKSryBK jrwLFVzNw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZCjU-00ERea-6e; Wed, 21 Apr 2021 13:17:32 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZCjO-00EReB-JX; Wed, 21 Apr 2021 13:17:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HDPjZMjWCZKqakVSIF2+cy5E4MqjSXUEPkpK+UOoNls=; b=ge0kb2q0GnCOpPANmX0vie1BLf 4x6FCuwz8b2ZuNE7qqipHRcLcXMcKDjQD/M+iaflkrWGJ/JYkyAueN+Eb13NL+ten7qM2QYGT06h5 AUjhkSBWy5FbjMSC4YcInG4n0izilTON1sEVrXC6Nxq1Wjj4TxT9/ltRueenhIcGPwmpqJwMFVEsj hJbPGOxx/DfOMMkVsrtAqyodriqspJ64cVqa3huyNLqpmbBMwmfoFJgffCd3Zl6yR74pvvpKhqnAw ueh7R0Yd4pOzR4vvR6xaD/cLgZboBgBy3VTTVIb7oNAIjAJLoH6RrLO1F4BLP7vzX9lfD2N325CiR 8XPfzaKQ==; Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZCjH-00CuK2-VM; Wed, 21 Apr 2021 13:17:25 +0000 Received: from maud (unknown [IPv6:2600:8800:8c03:4000::11ea]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: alyssa) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id B8F551F42E3B; Wed, 21 Apr 2021 14:17:09 +0100 (BST) Date: Wed, 21 Apr 2021 09:17:04 -0400 From: Alyssa Rosenzweig To: Nicolas Boichat Cc: Rob Herring , Steven Price , Alyssa Rosenzweig , fshao@chromium.org, hsinyi@chromium.org, hoegsberg@chromium.org, Tomeu Vizoso , Neil Armstrong , boris.brezillon@collabora.com, Daniel Vetter , David Airlie , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v13 4/4] drm/panfrost: Add mt8183-mali compatible string Message-ID: References: <20210421052855.1279713-1-drinkcat@chromium.org> <20210421132841.v13.4.I5f6b04431828ec9c3e41e65f3337cec6a127480d@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210421132841.v13.4.I5f6b04431828ec9c3e41e65f3337cec6a127480d@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210421_061720_164192_01F61817 X-CRM114-Status: GOOD ( 20.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Not that you need it but this patch is Reviewed-by: Alyssa Rosenzweig On Wed, Apr 21, 2021 at 01:28:55PM +0800, Nicolas Boichat wrote: > Add support for MT8183's G72 Bifrost. > > Signed-off-by: Nicolas Boichat > Reviewed-by: Tomeu Vizoso > Reviewed-by: Steven Price > --- > > (no changes since v7) > > Changes in v7: > - Fix GPU ID in commit message > > Changes in v6: > - Context conflicts, reflow the code. > - Use ARRAY_SIZE for power domains too. > > Changes in v5: > - Change power domain name from 2d to core2. > > Changes in v4: > - Add power domain names. > > Changes in v3: > - Match mt8183-mali instead of bifrost, as we require special > handling for the 2 regulators and 3 power domains. > > drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 83a461bdeea8..ca07098a6141 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -665,6 +665,15 @@ static const struct panfrost_compatible amlogic_data = { > .vendor_quirk = panfrost_gpu_amlogic_quirk, > }; > > +const char * const mediatek_mt8183_supplies[] = { "mali", "sram" }; > +const char * const mediatek_mt8183_pm_domains[] = { "core0", "core1", "core2" }; > +static const struct panfrost_compatible mediatek_mt8183_data = { > + .num_supplies = ARRAY_SIZE(mediatek_mt8183_supplies), > + .supply_names = mediatek_mt8183_supplies, > + .num_pm_domains = ARRAY_SIZE(mediatek_mt8183_pm_domains), > + .pm_domain_names = mediatek_mt8183_pm_domains, > +}; > + > static const struct of_device_id dt_match[] = { > /* Set first to probe before the generic compatibles */ > { .compatible = "amlogic,meson-gxm-mali", > @@ -681,6 +690,7 @@ static const struct of_device_id dt_match[] = { > { .compatible = "arm,mali-t860", .data = &default_data, }, > { .compatible = "arm,mali-t880", .data = &default_data, }, > { .compatible = "arm,mali-bifrost", .data = &default_data, }, > + { .compatible = "mediatek,mt8183-mali", .data = &mediatek_mt8183_data }, > {} > }; > MODULE_DEVICE_TABLE(of, dt_match); > -- > 2.31.1.368.gbe11c130af-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel