From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D56C433B4 for ; Mon, 26 Apr 2021 12:16:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68FE7610A2 for ; Mon, 26 Apr 2021 12:16:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68FE7610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qbK59U8Cp2BBSYVH5Nq413tQSqAkmpe/L0pJbRrzmWY=; b=loG5PUA14l2C3OqDlOyAFjaJV Apj5ZfjJPY4EY9pYFnIpG0GaTi1IVCVJmAyRhYYjtg0opijfWvogjNpZgMJ31PJpL5XJwX6ECxp1Y aB4Fl6Lo5nXR1rJnkuKIESd9E+4eCQWyuBi7VGNdkQ2RW3pBPIPE8PmScQpzjW379+/k+SyUw+pfs ysDg3D5XY1QOyCvtxmzCQ4wYCKePgIOOAq449qqOgCytAWP/KHL9GeKjzbxx4j0XKagVhekgT9T7U BcimHWTNVxaRqfYeD2LimLoxf2U1AS0HZa4eBtPJRMMWHW61y7nuifww+0hsEqPzxa5/zhTZXso9L KMwMrhuPg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lb08u-007Zl1-Pu; Mon, 26 Apr 2021 12:15:12 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb08s-007ZkZ-Ba for linux-arm-kernel@desiato.infradead.org; Mon, 26 Apr 2021 12:15:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4wpsUOWOD0Ocubs0APm8u84sDnwn2Yt011/bzQRv2wM=; b=M6F269begNbqBNQMH7c4QxxOms BgdnN+cd8lQltiJuV1C20/oRTcN7P/3LAJhKR2UMWyFIFE0seZM8pUEJ8eCH49Gd8E3rd8iPIYtwA 9i86gfxDcH3wNBJXlMBPbCTqdqob13J4igMVIlm9kynxN/B5Ji+IwBtLUBO92eOEW0P0EGx/UWtw4 K1/vGvq8P3Ym5pKYGlW0CRNpRM9oK90r2MloKCBnlbJejv1iVMYAVwkK/i7Mjff9iUL+xvARpWooB WpemW3CzhjYJpuMGAvikHidH9FLhjecHFCcgEfRpdiL2xwtdCrhYJOwRKdrSWp5csSJrELkisAhwM DNHKLdOA==; Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb08p-00FwqE-1M for linux-arm-kernel@lists.infradead.org; Mon, 26 Apr 2021 12:15:08 +0000 Received: by mail-wm1-x335.google.com with SMTP id 26-20020a05600c22dab029013efd7879b8so3177232wmg.0 for ; Mon, 26 Apr 2021 05:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4wpsUOWOD0Ocubs0APm8u84sDnwn2Yt011/bzQRv2wM=; b=WqMw0IpOBSKwBCXwRI9ov5gt/BuvGLebTAEhOg0P5Oh7iQAxlgOGdStj2tVDLXcF8s ErQF77ws/R+Z843UiOlR1IPLaTIDlgWuYMPEHXfLztz/V4dhsy6Sn8HNFuG7FewMFFZ8 /T7F28WrfFyigUqef5tbL5XcByiE5e0nLDIysrImyVcq87m+fJUrSLHf4e4xSILDZiLG qpZUOzXAseKCnrnMVxU1kTUVHkj1a1dyf0iSkoAVxT4z1+J3DhpQfeAJefyKy1XN6ZlC DsYx3VuCvlGE86pIjNtPj06IrqhfiBfb6DIq5CyasVuwP3u0K+IZPILkDfI3/MzQdIFO 7oUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4wpsUOWOD0Ocubs0APm8u84sDnwn2Yt011/bzQRv2wM=; b=pdbmNrbGfpOFAE3Ee7KvjRt4yvHzaQMR4ZD6qa3Q40hGIIP/MV2TCHqCkQtqM3sg7V V62f0+yxY5+Skl/yYgKogTmICYADQ4PDLozcMqV5hAmJy5+SEa6aiWF8PjRut9kQR9DF N1yg/ur8uKb6VuOtEXev+2c6Tf+kLEkZpeMEjDYIV8vROxH8se9x8SgMCHXlj3MkVm9N CyE1FmTB+n47dX7gWMdwXiA85Bh0CDUkUgz6II34fxx7Dtse62GTk3Tm/AwrewZMkqGN GsEgzQ822fTP6YnM+Zg5orEnWNbHIOFMcC9pzXZRO6nEaxEq4OHL7SKgUb2rI3VL3DnN wdVg== X-Gm-Message-State: AOAM530kn/eTNA0op2PxsydVHonB+aEqY6tRj89i1b/+Z7APEd/gW/sI c5oG/Umo+0k2VcKJ1ktkXrw= X-Google-Smtp-Source: ABdhPJxqXZuKLqbAqsusZ97EFd4Cjqu517b5L1DL2eJsNwwh75RxKGtPGgnU/QTkyBNleKYAroiK6g== X-Received: by 2002:a1c:c910:: with SMTP id f16mr21195064wmb.136.1619439303345; Mon, 26 Apr 2021 05:15:03 -0700 (PDT) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id s8sm20881104wrn.97.2021.04.26.05.15.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 05:15:01 -0700 (PDT) Date: Mon, 26 Apr 2021 14:15:54 +0200 From: Thierry Reding To: Dmitry Osipenko Cc: Krzysztof Kozlowski , Jon Hunter , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 08/10] memory: tegra: Unify drivers Message-ID: References: <20210420165237.3523732-1-thierry.reding@gmail.com> <20210420165237.3523732-9-thierry.reding@gmail.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_051507_106274_378A8C3E X-CRM114-Status: GOOD ( 21.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4879038170761284851==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4879038170761284851== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IxlTkvzTj8ImYZdK" Content-Disposition: inline --IxlTkvzTj8ImYZdK Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 21, 2021 at 02:46:24PM +0300, Dmitry Osipenko wrote: > 20.04.2021 19:52, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > +/* > > + * XXX The Tegra186 memory controller driver used to be able to do thi= s. Once > > + * removing the driver is supported on all chips, this can be uncommen= ted. > > + */ > > +/* > > +static int tegra_mc_remove(struct platform_device *pdev) > > +{ > > + struct tegra_mc *mc =3D platform_get_drvdata(pdev); > > + > > + if (mc->soc->ops && mc->soc->ops->remove) > > + mc->soc->ops->remove(mc); > > + > > + return 0; > > +} > > +*/ > > + > > static int __maybe_unused tegra_mc_suspend(struct device *dev) > > { > > struct tegra_mc *mc =3D dev_get_drvdata(dev); > > @@ -834,6 +856,9 @@ static struct platform_driver tegra_mc_driver =3D { > > }, > > .prevent_deferred_probe =3D true, > > .probe =3D tegra_mc_probe, > > + /* > > + .remove =3D tegra_mc_remove, > > + */ > > }; >=20 > The commented lines shouldn't be in the final version of the patch, IMO. > These lines either should be uncommented and the remove() callback > should return -EOPNOTSUPP or they should be removed for now. Fair enough, I'll drop them in v2. Thierry --IxlTkvzTj8ImYZdK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmCGrvoACgkQ3SOs138+ s6Gb4BAAgHejMsh5+k1VlGofxEYlIDYWw4+xXCU9RE/onQRU2pJSHzJlW7p36NEd WDZlp93uSw8MtHqS+FxZlVdcSUjqr896TYTLRqZtZrc40rifxrmJ9OY9KAHzL6sy llBAHvvkQp3jtIrCqbKOE8KqE0rjJ9bFy7Fcv7dLFD3nNFe+XR/wsz8rm/IQC8mO qDjrDA7LjEZkIXzxO3YRfzCwOS12gLWELwub6Bjzq/at7sebzPGyS3n9ZmuBM3vO B7dVqd3JwrhbJ8SocpUS99Eh6WuYMzDnlvdIiWSyMBjhIUHvlNODRg0nUHcgun1r z/AEOfmdDyyRR7FYerWeGYSScxmaYOTfxecW6vV/F3b6LzTzRMgnoLqxBQx7gfex IsqpEdmwumRgw1c4H6FiH2w1G9dgHiUDNxX/vCEWW1UPhQrWY9AeJiXReoTbje7Y Ae9J2vt2WmsHG6XAc2hXl1kXdpp+NJ80JsrDlxyP5uvu2Ae5V0sFhQzyVlnkd2OA ufJTpQ+jVylSu8tARiyUgHPZe3jOE0Kdom2vpfDzq5arKQNcFBnQRoO3FJUFV22n TFaMlkHvGJ142rREIhLQ5AtbbqLzjsmF29eVWWEVMpdvQeq0pssJcRADuDPSrXux XeWxxCziMFkqaQfkGyLXpMQDL6ohRiCAGw2PvI1bb/EcUujrtYk= =MFr/ -----END PGP SIGNATURE----- --IxlTkvzTj8ImYZdK-- --===============4879038170761284851== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4879038170761284851==--