From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A38BC433B4 for ; Fri, 30 Apr 2021 07:31:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAFC3613B3 for ; Fri, 30 Apr 2021 07:31:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAFC3613B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2rPoftzhq0ExONlIKAvSC6MLxpSsHo1ythYjsdt6iEI=; b=J9O58bOjN1yyw8KzZYmMYWS6U p9KI/zaSeLesDXn24qjtsaJ2PP/ICwlk9eif9J4kxVFPlMDGpmk4+HgH4jKjEkbfAopAkX6EVbmQU 6zPtg3Jj8S2fGdVcAkSNuDLQXHx8EZTrmSINgh8fV/24zvvM9uYCaw9DdLdgFq8BARj1KrGNFYAz/ BIEupzX10V4BvKGvzXkwPmumcnro5gAtUc33TZpC3N3h3EB7szCMM1DMPY/sieVAeiX7UCPvFKg60 7xqRcsLx/TE1z9c4RI23KL8+6GO5dskujo0KsyhcProk+2xOjbS2jn+unxIsjbDXba5mzYLyJD4MT kPnvtQgwg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lcNaV-007Qig-Nh; Fri, 30 Apr 2021 07:29:23 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lcNaS-007Qhx-Rv; Fri, 30 Apr 2021 07:29:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IgK3ze1LZCQFzkp0GEBFB8++Nwq+njhHwBa/cbmTwkk=; b=a5ItKrPr3y3xpDAVlFOxjmgHkr AOdDPNtiCF/QNIcT4jWNUA2y+fxqKdMU1PrxIKzUsXbvMj/ykKxjQZx2CQYqlpTg1agPN2+MOsLzc aPlFoR4FXENhFO0xDRsJBZEKVIPdsjNzI/DX4eisxhBFbMLtKxDoSNC6O5rn9gYFG/fw4Rm55Udd7 BNHxO0SGIK/eDOmAzixLeLSL8GeTHF7O6j6Um7+aFFekfOqN1LsCoqaIiPjD/S9ht50ifHv5ssycT 8sqTXUNc7EugnhZUqVgokHqjzMM+6coGkyKlpEH87Q6K8HuIYRDq4ktCnFlxPlwVP3hhah0juLWiX uTeQ4GYw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lcNaQ-001CPM-5Q; Fri, 30 Apr 2021 07:29:19 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B005613B3; Fri, 30 Apr 2021 07:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619767757; bh=UOwbjp9n6THAwLNXnYFCjvVARM6laoU+YRJMD42KQK4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gU4BEDg0/+ToTZ2RLKPtxpLCkg1nhxGnQ8RspU3df5YPn62XPsoMgFcKABoGFTnx7 YUIfcIP6MgesZP9FsgkR7YT08dqiAwb8Cv2LhNv2B1USKPFknp/7VsE5Sy+yKcDRVx QJFIR5QVt7Lu3Aa5x8NalJDFND8ufOJeLUfFHgdk= Date: Fri, 30 Apr 2021 09:29:15 +0200 From: Greg Kroah-Hartman To: Chunfeng Yun Cc: Mathias Nyman , Matthias Brugger , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Ikjoon Jang , Eddie Hung Subject: Re: [PATCH 1/3] usb: xhci-mtk: use bitfield instead of bool Message-ID: References: <20210430071532.51794-1-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210430071532.51794-1-chunfeng.yun@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210430_002918_261305_BC158F34 X-CRM114-Status: GOOD ( 16.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 30, 2021 at 03:15:30PM +0800, Chunfeng Yun wrote: > Use bitfield instead of bool in struct That says what you did, but not why you did it. Why? > > Signed-off-by: Chunfeng Yun > --- > drivers/usb/host/xhci-mtk.c | 2 -- > drivers/usb/host/xhci-mtk.h | 8 ++++---- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c > index b2058b3bc834..2548976bcf05 100644 > --- a/drivers/usb/host/xhci-mtk.c > +++ b/drivers/usb/host/xhci-mtk.c > @@ -495,8 +495,6 @@ static int xhci_mtk_probe(struct platform_device *pdev) > goto put_usb2_hcd; > } > mtk->has_ippc = true; > - } else { > - mtk->has_ippc = false; Why did you remove this chunk? That is not described in the changelog at all. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel