From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF32C433ED for ; Fri, 14 May 2021 13:15:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2ACE36121E for ; Fri, 14 May 2021 13:15:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2ACE36121E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=95eo7ZUqHQNjq7B5LZfeNJyu8qstuPdUOtafjL7fe18=; b=Rp5sI8XgBoDfpW0DRjGVjRTkg vFFvxGAfyBhM/iraFmXEKUMYKndAvt7cWu+7/yjcOkxbSdAYqg9uUBBR+MlQQiw2DzJfNtDPcKxJs hfNHoA02hRn1ovyb5wkSImNYmbFWbEr1UNzKEkiGGPjTZnY4rfhvAv6NQ3qJKp3BwK4B495xFM+Ke vV3eoSMQv7CbsfQai94FzeRjYzBw4PWCEr2uhxl5pZfZG4MYxhC+FXk6roQskSJjZar1G0QPglV+e +OkHyPRPx7GOuIVJME5iLZgFLJcpx7UepgvLbZid4MTIuo6km7VrnhoPxP+bRmtnXgJUs7HEuKY/W Z4UTiWMJQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhXdV-0086q1-8y; Fri, 14 May 2021 13:13:49 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhXdS-0086pv-Us for linux-arm-kernel@desiato.infradead.org; Fri, 14 May 2021 13:13:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vRiIp0EYXChE74A6lvCEEye0aLhazJ8b+E/Uzqt1rzg=; b=tHt+vjnsDlkVt3tyjpjbjQaZS4 wDAfO/SYfHHjMXKObGiIcFYMRkCkBNn08eZVuCCDLGR/YfSz4y4T2P9jxaavypMZvKt2KvKDJH3iv DmNYAFMyiu1nMy5azbMEMc/+y6MFYc0dc9MA9vYCdMIt0kzknzK5haC15zhZuXJaDemNieXAja7B+ 3PRWXpABihEQaBIkLyIEoaGv5QuoZZsIYuxlcyhw1rrdxks7nmwgWWSLc98M6sSGAad4FyHWwbA0J NcZOzaBVl41q2WJ8mEkQQheqNQ1Ttnr0oyhT7F3/FssoDh+Lj+IdggddOhC7L1HvvbFgqLRIkjmnz wrY4ZLfg==; Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhXdO-00Bznk-Tz for linux-arm-kernel@lists.infradead.org; Fri, 14 May 2021 13:13:45 +0000 IronPort-SDR: DRdAJoiHSd76NJZTWtwmfIcega5B5wF0cUvTpeZ1oAq8Xlc1C/llI+tclFhPXnFPznqfuA7sZX RUQfdiTebvlw== X-IronPort-AV: E=McAfee;i="6200,9189,9983"; a="197089352" X-IronPort-AV: E=Sophos;i="5.82,299,1613462400"; d="scan'208";a="197089352" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2021 06:13:32 -0700 IronPort-SDR: 74l511Rb9o5gDukdPDL6bOeNbq6KgQcj3lP8iDQqaTWrXmxK5XUlenpjvEJBgSBvCJ8LpyEenR NV3AelhCj7QA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,299,1613462400"; d="scan'208";a="538806639" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 14 May 2021 06:13:28 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 14 May 2021 16:13:28 +0300 Date: Fri, 14 May 2021 16:13:28 +0300 From: Heikki Krogerus To: Lorenzo Pieralisi Cc: Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Jean-Philippe Brucker , Joerg Roedel , Eric Auger , Will Deacon , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI/IORT: Handle device properties with software node API Message-ID: References: <20210511125528.18525-1-heikki.krogerus@linux.intel.com> <20210514103912.GA16131@lpieralisi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210514103912.GA16131@lpieralisi> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_061343_005518_9232779C X-CRM114-Status: GOOD ( 26.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 14, 2021 at 11:39:12AM +0100, Lorenzo Pieralisi wrote: > On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote: > > The older device property API is going to be removed. > > Replacing the device_add_properties() call with software > > node API equivalent device_create_managed_software_node(). > > > > Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits") > > Is this really fixing anything ? I am not sure I understand what you > would like to achieve with this tag. Right now it's not possible to simply remove the old API because some of the maintainers want to take care of the conversion themselves, but at the same time I also do not want to see any new releases of the kernel that introduce more users for it. That's why it's a fix. > > Signed-off-by: Heikki Krogerus > > --- > > drivers/acpi/arm64/iort.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > With the above comment clarified: > > Acked-by: Lorenzo Pieralisi > > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > > index 3912a1f6058e5..e34937e11186a 100644 > > --- a/drivers/acpi/arm64/iort.c > > +++ b/drivers/acpi/arm64/iort.c > > @@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev, > > FIELD_GET(ACPI_IORT_NC_PASID_BITS, > > nc->node_flags)); > > > > - if (device_add_properties(dev, props)) > > + if (device_create_managed_software_node(dev, props, NULL)) > > dev_warn(dev, "Could not add device properties\n"); > > } > > > > -- > > 2.30.2 > > thanks, -- heikki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel