From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C814C433B4 for ; Fri, 14 May 2021 10:26:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22B3D61353 for ; Fri, 14 May 2021 10:26:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22B3D61353 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZYVAbRYa9Ga879UIA+k0pQv3dFVX8KExQi5Su3hnYKw=; b=DrixftAgbA/b3X3E4PCHLymmK 8XTjURwalO3Vl+q6OV6KaohoLwDmXfDFn8aX96N/+Oi5li9FAC+6OQWt3ET4uQCEcjob4Kj/HZjmY VTY4ZqozHunrr1uBq/DJOloEAbagLGEeUqnYF+XRAOhvt/+SVboGePS8NMhBz8i6IwZAk494yXd/l H9U7LsVIoxgOVCJTVYG54gdvf9UJ2SVE8jV1XAj+5GfKwnrOfxuXjhq4O0wXtT7te15unAl93D+pP FEC6EORbDYhB26QqhtTK51Vemhql7OY5bhIV77CZmdO4fV7pREDxcncM+Vex96Zm6Km3nPx1IyzCx u5lw/uVIw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhV02-007ku1-3o; Fri, 14 May 2021 10:24:54 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhUzz-007ktq-BC for linux-arm-kernel@desiato.infradead.org; Fri, 14 May 2021 10:24:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9t2pgY4Q7XksOj4Znq1Ogm0MEV0PR+hGksUEegqxWy4=; b=Hx78nzUGxxoidCZI2NJJMpkpPU ptnryVytL8X/KlY4vorPbwlOFH3oZu0iT0QVBZs+cGaU9L7VRy2bPlCzy0QeO/vJ0VLDzIuNM48tP M5t30Rnxc9bQEkdpe9WjXdSUiIOWFKfWl1mE6YZqr/QJLts/a45j+YRCTxZGcQzsHdNCzgw3iZcKF KfNF+GUrm7S33Ya/PMy2tdllkyW/CMeU31sKuXItwtMnM9CA9IBX8UBLVEU3O1/DPoUboNxFvKtiI vZvBRoTvCz/jYLu34BzJftLrAte+7iQlkeSmSOINgzSnPTPmTaL2RbLl9FZ2R8+PS9KCKbH6WPll2 Z3FJvcsg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhUzw-00BtbY-Jn for linux-arm-kernel@lists.infradead.org; Fri, 14 May 2021 10:24:50 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B7E5061353; Fri, 14 May 2021 10:24:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620987887; bh=z/miKyvmY7M8tNXyT/t8zRBrMdfgoa7t4pQ+ZnLdxB0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E9N/LBStsXpDQmWrGLlzHoMKpcQe4SQXulr8OyJ0SFFwJvv6DKbDirmB3ve6f958c efxVpm/fxrIAOE1kUb5RBoduJwsW9iHb6HcYCuw0FFVgRk0vxbI7dCt+h6SIr1Y2hf lDgdinh35eI09Z5YdOjbm5HYFHwXeOENzkDkenEUlfQ9of+Y/BmrIgpTC3pTYVOtkg ZgdhC0L7rdYUibpNtDENp6/q92x6Aul7VBt/tktdlWdm0q4Ps9I00IpWHFEEmmaHGh P6NoRiEBbtprQ20U1KDpCnSzQTcKhICH/0NQdkQiY0cN1UUVz5/+WKIt+l5rVwLrhs y4zBNQzixtMsg== Date: Fri, 14 May 2021 13:24:41 +0300 From: Abel Vesa To: Shawn Guo Cc: "Mirela Rabulea (OSS)" , robh+dt@kernel.org, aisheng.dong@nxp.com, guoniu.zhou@nxp.com, linux-arm-kernel@lists.infradead.org, peng.fan@nxp.com, s.hauer@pengutronix.de, linux-imx@nxp.com, devicetree@vger.kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, paul.kocialkowski@bootlin.com, daniel.baluta@nxp.com, robert.chiras@nxp.com, laurentiu.palcu@nxp.com, p.zabel@pengutronix.de, ezequiel@collabora.com, Mirela Rabulea Subject: Re: [PATCH v11] arm64: dts: imx8qxp: Add jpeg encoder/decoder nodes Message-ID: References: <20210423101414.20068-1-mirela.rabulea@oss.nxp.com> <20210513073832.GS3425@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210513073832.GS3425@dragon> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_032448_729474_E4A641E8 X-CRM114-Status: GOOD ( 23.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21-05-13 15:38:33, Shawn Guo wrote: > On Fri, Apr 23, 2021 at 01:14:14PM +0300, Mirela Rabulea (OSS) wrote: > > From: Mirela Rabulea > > > > Add dts for imaging subsytem, include jpeg nodes here. > > Tested on imx8qxp only, should work on imx8qm, but it was not tested. > > > > Signed-off-by: Mirela Rabulea > > So the bindings and driver parts have been accepted already? > > > --- > > Changes in v11: > > Adress feedback from Aisheng Dong: > > - Rename img_jpeg_dec_clk/img_jpeg_enc_clk to jpeg_dec_lpcg/jpeg_enc_lpcg to make it visible it's lpcg not other type of clk > > - Drop the cameradev node, not needed for jpeg > > - Match assigned-clocks & assigned-clock-rates > > > > .../arm64/boot/dts/freescale/imx8-ss-img.dtsi | 82 +++++++++++++++++++ > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 1 + > > 2 files changed, 83 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi > > new file mode 100644 > > index 000000000000..c508e5d0c92b > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi > > @@ -0,0 +1,82 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Copyright 2019-2021 NXP > > + * Zhou Guoniu > > + */ > > +img_subsys: bus@58000000 { > > + compatible = "simple-bus"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0x58000000 0x0 0x58000000 0x1000000>; > > + > > + img_ipg_clk: clock-img-ipg { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <200000000>; > > + clock-output-names = "img_ipg_clk"; > > + }; > > Hmm, not sure a fixed-clock should be in the subsystem. > Agreed. Assuming the img_ipg_clk is only used on 8QXP, you could move it into imx8qxp-ss-img.dtsi. This way every other platform that uses this ss file will not be impacted. > > + > > + img_jpeg_dec_lpcg: clock-controller@585d0000 { > > + compatible = "fsl,imx8qxp-lpcg"; > > + reg = <0x585d0000 0x10000>; > > + #clock-cells = <1>; > > + clocks = <&img_ipg_clk>, <&img_ipg_clk>; > > + clock-indices = , > > + ; > > + clock-output-names = "img_jpeg_dec_lpcg_clk", > > + "img_jpeg_dec_lpcg_ipg_clk"; > > + power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>; > > + }; > > + > > + img_jpeg_enc_lpcg: clock-controller@585f0000 { > > + compatible = "fsl,imx8qxp-lpcg"; > > + reg = <0x585f0000 0x10000>; > > + #clock-cells = <1>; > > + clocks = <&img_ipg_clk>, <&img_ipg_clk>; > > + clock-indices = , > > + ; > > + clock-output-names = "img_jpeg_enc_lpcg_clk", > > + "img_jpeg_enc_lpcg_ipg_clk"; > > + power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>; > > + }; > > + > > + jpegdec: jpegdec@58400000 { > > Keep nodes sorted in unit address. > > Shawn > > > + compatible = "nxp,imx8qxp-jpgdec"; > > + reg = <0x58400000 0x00050000 >; > > + interrupts = , > > + , > > + , > > + ; > > + clocks = <&img_jpeg_dec_lpcg 0>, > > + <&img_jpeg_dec_lpcg 1>; > > + clock-names = "per", "ipg"; > > + assigned-clocks = <&img_jpeg_dec_lpcg 0>, > > + <&img_jpeg_dec_lpcg 1>; > > + assigned-clock-rates = <200000000>, <200000000>; > > + power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>, > > + <&pd IMX_SC_R_MJPEG_DEC_S0>, > > + <&pd IMX_SC_R_MJPEG_DEC_S1>, > > + <&pd IMX_SC_R_MJPEG_DEC_S2>, > > + <&pd IMX_SC_R_MJPEG_DEC_S3>; > > + }; > > + > > + jpegenc: jpegenc@58450000 { > > + compatible = "nxp,imx8qxp-jpgenc"; > > + reg = <0x58450000 0x00050000 >; > > + interrupts = , > > + , > > + , > > + ; > > + clocks = <&img_jpeg_enc_lpcg 0>, > > + <&img_jpeg_enc_lpcg 1>; > > + clock-names = "per", "ipg"; > > + assigned-clocks = <&img_jpeg_enc_lpcg 0>, > > + <&img_jpeg_enc_lpcg 1>; > > + assigned-clock-rates = <200000000>, <200000000>; > > + power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>, > > + <&pd IMX_SC_R_MJPEG_ENC_S0>, > > + <&pd IMX_SC_R_MJPEG_ENC_S1>, > > + <&pd IMX_SC_R_MJPEG_ENC_S2>, > > + <&pd IMX_SC_R_MJPEG_ENC_S3>; > > + }; > > +}; > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > index 1e6b4995091e..2d9589309bd0 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > @@ -258,6 +258,7 @@ > > }; > > > > /* sorted in register address */ > > + #include "imx8-ss-img.dtsi" > > #include "imx8-ss-adma.dtsi" > > #include "imx8-ss-conn.dtsi" > > #include "imx8-ss-ddr.dtsi" > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel