From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A4CAC43460 for ; Fri, 7 May 2021 16:36:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F62B61458 for ; Fri, 7 May 2021 16:36:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F62B61458 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KklFD1J0OhstY5jow73YQ+MywhKAdHS/MR8IbH3Hi+M=; b=qgH+Y4t1tE/KH09JDG+ogqEsk AwlsCo7hXGb0ANFAFjajxCYSfcwLjm5E+SBHjpKB1dhjRpLnLeJnR/EkwqniIE+x85WXnaoFSbrBt w8pT9/m0gOZDKWmCMPz+HaJb5iCuYRCxyK5SMQcdvQO5NWFJ8PzjG2Itb2ZHw0vJoMP0Rhkep8v9P WHvv7PdR4KvsiQtO3NVyFDhqqzh8VDL9tfwos1fKfTaYLdenCA6ZV93YXK7j3cwe3366A0jgG8VSh WTM5D+z1LJPaIVQYQy5oYPAR9JNLI6S6YA5yFNpQu09dDv3owS4k+VAaiIPAK5gvGgNA5H03vX165 jSmyxHC3A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lf3R8-007Zrl-9k; Fri, 07 May 2021 16:34:46 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lf3R4-007Zqy-L6 for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 16:34:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=O99QLS/XuXmi5sOenN2CFxQz7Q5z0xeHfl0XAzi4THc=; b=DC2EXUNAvfOBAcgN+it/DAKpQH RTK3i8XvEL42xnzGHLbkg2ztWOZagCb3ruy2vLYPEvaxZ0xyx2OmUp8FdogGrgTqbv9iNtlguNsVS hrZ9TkIy5fOzGldYsrayLZgH9/YsMoLzmfQUMXVZgzZMwGKhDTbR/UJ2DX2wspgRxyJUWAOKpG0XM IWzWq9ebrAJS0xsiV+1ViPI+bS0xPXY5sNOln+pZAV/JQcloD8Xz92IKyfNYZL7EruCLVnz1B+1CV NCxeU2aQgGZQO6n4zqKTxFZsQp3o4/s3das/PunHQ3Rmg+w1aUDfeRx0Uyq/GjKDDoiGg/LTzCraf CEY5BCpQ==; Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lf3R1-0070W7-QZ for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 16:34:41 +0000 Received: by mail-wr1-x436.google.com with SMTP id v12so9884773wrq.6 for ; Fri, 07 May 2021 09:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=O99QLS/XuXmi5sOenN2CFxQz7Q5z0xeHfl0XAzi4THc=; b=U+IByuCcxULK3nxRVkk7JSImKY8trLGHWZcfLZTgiCNxRgComAbd5SB0Cfj6jYZ996 9lS6uV6uHIiiE4JuSIZxyPiEFBQLgBWjXWWpjAxbl8UM05Asr4O0C2J4hfCVuPJJkeXk Lp1lfV5LSbB4AJ6q9iEoC6lTzRO2xg0DHZElM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=O99QLS/XuXmi5sOenN2CFxQz7Q5z0xeHfl0XAzi4THc=; b=VQIP+V0n0sE7FDbdlp8lBcJtJ9lr9RIihNUroCeHZnNwH+/55uo5MqXXjYl9fqf0X1 98RlrEDbkAngTHMyXK38NTTMLQpiJagMQyN6C9Mei7yLBEd7eN0Yf5nZFMIxlz+9I9W3 5sghV8bOrLTNPgqH0zoMJFIgRhk3jZhNdKXECDXWTYKzB4g2Suetp4CSgocdR9s2d6BZ byim4zu94LGZA/0zFMN0SV7RWFMD53F6mZn5u3OJbhQ8IOIFX/IOFPXOUS5O80VXsr9H /VwN4aMDATXfOZON92YCXrs/LAJr40Tbn/9KxwwBLhokmle/GeO/L9DLAnKTaAkwssWI KO6Q== X-Gm-Message-State: AOAM530h38VqjkqhpLXSDcnXlXlPk1OBQsJ6vKvXE0LFG71dCi5oYhrf mOv4G4JvuDROacaDttdM9r8G1g== X-Google-Smtp-Source: ABdhPJz9eV+VjyShaXPfAx4WvqHMrnt9SIWVOMU/ZLtthyBfUy5zg6ri6iuFlihrahEEp1TfX0GW8g== X-Received: by 2002:a5d:6181:: with SMTP id j1mr13620583wru.16.1620405276947; Fri, 07 May 2021 09:34:36 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id r2sm8702898wrt.79.2021.05.07.09.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 09:34:36 -0700 (PDT) Date: Fri, 7 May 2021 18:34:34 +0200 From: Daniel Vetter To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Christophe JAILLET , linux-fbdev@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel-janitors@vger.kernel.org, krzysztof.h1@poczta.fm, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, j.beisert@pengutronix.de, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] video: fbdev: imxfb: Fix an error message Message-ID: Mail-Followup-To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Christophe JAILLET , linux-fbdev@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel-janitors@vger.kernel.org, krzysztof.h1@poczta.fm, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, j.beisert@pengutronix.de, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org References: <20210507050503.iwrcis2xzhjjthmp@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210507050503.iwrcis2xzhjjthmp@pengutronix.de> X-Operating-System: Linux phenom 5.10.32scarlett+ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_093439_883225_92664DD4 X-CRM114-Status: GOOD ( 26.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 07, 2021 at 07:05:03AM +0200, Uwe Kleine-K=F6nig wrote: > Hello Christophe, > = > On Thu, May 06, 2021 at 08:57:05PM +0200, Christophe JAILLET wrote: > > 'ret' is known to be 0 here. > > No error code is available, so just remove it from the error message. > > = > > Fixes: 72330b0eeefc ("i.MX Framebuffer: Use readl/writel instead of dir= ect pointer deref") > > Signed-off-by: Christophe JAILLET > > --- > > drivers/video/fbdev/imxfb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > = > > diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c > > index 7f8debd2da06..ad598257ab38 100644 > > --- a/drivers/video/fbdev/imxfb.c > > +++ b/drivers/video/fbdev/imxfb.c > > @@ -992,7 +992,7 @@ static int imxfb_probe(struct platform_device *pdev) > > info->screen_buffer =3D dma_alloc_wc(&pdev->dev, fbi->map_size, > > &fbi->map_dma, GFP_KERNEL); > > if (!info->screen_buffer) { > > - dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret); > > + dev_err(&pdev->dev, "Failed to allocate video RAM\n"); > > ret =3D -ENOMEM; > > goto failed_map; > > } > = > Reviewed-by: Uwe Kleine-K=F6nig Thanks for patch& review, queued for 5.14 in drm-misc-next. -Daniel > = > Are you using this driver, or did you find that problem using some > static checker? > = > Best regards > Uwe > = > -- = > Pengutronix e.K. | Uwe Kleine-K=F6nig = | > Industrial Linux Solutions | https://www.pengutronix.de/ | -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel